Making a myString class

[gibnihtmus]

Hi, I'm creating a myString class. I can't get the reverse, = operator, and + operator to work. I posted the .h and the .cpp file below.

Problem with reverse:
My reverse function is not assigning buf[i] to temp[j] in my for loop

Problem with = operator:
this works!

	String b("I am b");


	String a = b;
	cout << "***A: " << a << endl;

however this doesn't, abort gets called

String c;
c = b;
cout << c << endl;

#include<iostream>
using namespace std;

class String
{
public:
	String(const char * s = "");//
	String(const String & s);//
	String operator = (const String & s);//
	char & operator [] (int index);//
	int size();//
	String reverse(); // NEEDS WORK
	int indexOf(char c);//
	int indexOf(String pattern); // do later
	bool operator == (String & s);//
	bool operator != (String & s);//
	bool operator > (String & s);//
	bool operator < (String & s);//
	bool operator <= (String & s);//
	bool operator >= (String & s);//
	/// concatenates this and s to return result
	String operator + (String & s);
	/// concatenates s onto end of this
	String operator += (String & s);
	void print(ostream & out);//
	void read(istream & in);//
	~String();
private:
	
	bool inBounds(int i)
	{
		return i >= 0 && i < len;
	}
	char * buf;
	int len;
};
ostream & operator << (ostream & out, String & str);
istream & operator >> (istream & in, String & str);

#include"myString.h"

String::String(const char * s)
	:len(strlen(s) + 1), buf(new char){
	strcpy_s(buf, len, s);
}

String::String(const String & s)
	: len(s.len), buf(new char){
	strcpy_s(buf, len, s.buf);
}

String String::operator = (const String &s)
{
	return String(s);
}

char & String::operator [](int index){ 
	if (inBounds(index))
		return buf[index];
	else
		return buf[len];
}

int String::size(){ return len-1; }

String String::reverse()
{
	char *temp = new char[len];
	int j = 0;
	for (int i = len - 1; i >= 0; --i)
		temp[j++] = buf[i];
	temp[j] = '\0';
	return String(temp);
}


int String::indexOf(char c){
	for (int i = 0; i < len - 1; i++){
		if (buf[i] == c)
			return i;
	}
	return -1;
}













void String::print(ostream & out){
	out << buf;
}

void String::read(istream & in){
	in >> buf;
}

String::~String(){
	cout << buf << " ";
	delete[] buf;
	cout << "destructed" << endl;
}


ostream & operator << (ostream & out, String & str){
	str.print(out);
	return out;
}

istream & operator >> (istream & in, String &str){
	str.read(in);
	return in;
}

int main(){
	String a("I am a");
	cout << a << endl;
	cout << "Size is " << a.size() << endl;
	cout << a.reverse() << endl;
	

	String b(a);
	cout << b << endl;

	cout << a.indexOf('a') << endl;

	String c = b;
	cout << c << endl;


	system("PAUSE");
	return 0;
}

[dhayden]

Operator=() should replace the current value of the string with the new value. It should return *this. Your operator=() just returns a copy of the right hand side of the statement.

There are other problems:
String::String(const char * s) and String::String(const String & s) allocate only 1 byte. You need to allocate enough room in buf for the entire string.

The read() method assumes that buf already has enough room and it doesn't update len