Need a little assistance counting a sort

[guglaak]

I am writing a program that will sort two separate arrays of 20 integers one as a bubble sort and the other as a selection sort. The program works great but, now I need to add in a way to count the number times the exchange happens and also display that.

  #include<iostream>

using namespace std;

void bubbleSort(int [], int);
void bubbleShow(const int[], int);
void selectSort(int [], int);
void selectShow(const int[], int);

int main()
{
	const int SIZE = 20;
	int values[SIZE] = {20,1,19,2,18,3,17,4,16,5,15,6,14,7,13,8,12,9,10,11};
	int values2[SIZE] = {20,1,19,2,18,3,17,4,16,5,15,6,14,7,13,8,12,9,10,11};

	cout<<"The unsorted values of the Bubble sort array are\n";
	bubbleShow(values, SIZE);

	bubbleSort(values, SIZE);

	cout<<"The sorted values of the Bubble sort array are\n";
	bubbleShow(values, SIZE);

	cout<<"The unsorted values of the Selection sort array are\n";
	selectShow(values2, SIZE);

	selectSort(values2, SIZE);

	cout<<"The sorted values of the Selection sort array are\n";
	selectShow(values2, SIZE);

	system("pause");
	return 0;
}

//////////////////////////////////////////////////////////////////////////////////////////////////////////

void bubbleSort(int array[], int size)
{
	bool swap;
	int temp;

	do
	{
		swap=false;
		for(int count =0; count < (size -1); count++)
		{
			if (array[count] > array[count +1])
			{
				temp = array[count];
				array[count] = array[count +1];
				array[count+1] = temp;
				swap = true;
			}
		}
	}
	while (swap);
}

/////////////////////////////////////////////////////////////////////////////////////////////

void bubbleShow(const int array[], int size)
{
	for(int count = 0; count < size; count++)
			
		cout<<array[count]<<" ";
	cout<<endl;
}

/////////////////////////////////////////////////////////////////////////////////////////////

void selectSort(int array[], int size)
{
	int startScan, minIndex, minValue;

	for (startScan =0; startScan< (size -1); startScan++)
	{
		minIndex = startScan;
		minValue = array[startScan];
		for(int index = startScan +1; index <size; index++)
		{
			if (array[index] <minValue)
			{
				minValue = array[index];
				minIndex = index;
			}
		}
		array[minIndex] = array[startScan];
		array[startScan] = minValue;
	}
}

////////////////////////////////////////////////////////////////////////////////////////////////

void selectShow(const int array[], int size)
{
	for (int count = 0; count < size; count++)
		cout<< array[count] <<" ";
	cout<<endl;
}

[shadowCODE]

add a count to your swap functions

int bubbleSort(int array[], int size)
{
        int count = 0;  //here
	bool swap;
	int temp;

	do
	{
		swap=false;
		for(int count =0; count < (size -1); count++)
		{
			if (array[count] > array[count +1])
			{
                                count++;
				temp = array[count];
				array[count] = array[count +1];
				array[count+1] = temp;
				swap = true;
			}
		}
	}
	while (swap);
        return count;
}

Remember that the prototype has changed from (void to int)

[guglaak]

So turn both my sorts from voids into int and then add in the counters?
Since count i already initiated inside the for loop should I use a different variable?

[shadowCODE]

So turn both my sorts from voids into int and then add in the counters?

YES

Since count i already initiated inside the for loop should I use a different variable?

NO.

[dhayden]

Since count i already initiated inside the for loop should I use a different variable?

Yes. You need to use different variables for the for loop and for counting the number of times you swap. I suggest you change the for loop to use i, simply because it's common.

[Duthomhas]

To follow up on dhayden's response to shadowCode, do you see where you are trying to use two different variables with the same name?

You do need a different variable to count a different thing. The 'count' on line 14 should be the same 'count' as line 3 (but it isn't, because a loop 'count' on line 10 eclipses it).

The loop does the sorting.

The 'number of swaps count' counts the number of times a swap was made.

@guglaak
Remember that in selection sort you need to swap values. Right now you are finding a small value and simply copying it over the older value.

Hope this helps.

[guglaak]

Thanks to everyone for the help!