There's a problem with the flow of control in my program

[SomeAmazingGuy]

....

[mobotus]

The program would not compile for me as is. Made a change compiled and it worked fine.

int main()
{
	char choice[25];
	char choice2 ='D';

	do
	{
		if (toupper(choice2) == 'D')
		{
			std::cout << "Enter a string: ";
			std::cin.getline(choice, 25);
			std::cout << choice << "\n";
		}

		std::cout << "\t";
		std::cout << "A) Count the vowels in the string" << "\n";
		std::cout << "\t";
		std::cout << "B) Count the consonants in the string" << "\n";
		std::cout << "\t";
		std::cout << "C) Count both vowels and consonants" << "\n";
		std::cout << "\t";
		std::cout << "D) Enter another string" << "\n";
		std::cout << "\t";
		std::cout << "E) Exit this program" << "\n";
		std::cout << "\n";
		std::cout << "Enter A, B, C, D, or E." << "\n";
		std::cin >> choice2;

		if (toupper(choice2) != 'E' || toupper(choice2) != 'D')
			testString(choice, choice2);

	} while (toupper(choice2) != 'E');

	return 0;
}

[dhayden]

When you do std::cin.getline(choice,25) at line 13 it will read up to 25 characters and store them in choice. If you enter 10 characters, it will store those 10 and a terminating null byte, but the remaining 14 characters contain whatever undefined bytes happen to be at that location.

Then at line 64 you are looping through all 25 characters instead of just the 10 that are valid. To fix this, change line 64 to:
for (int n = 0; choice1[n]; n++)

[SomeAmazingGuy]

Thank you so much dhayden, if it wasn't for you I would have NEVER figured that out.

[SomeAmazingGuy]

........

[mobotus]

Line 66 getline is where this is failing.

if (toupper(choice2) == 'D') // Works
	{
		std::cin.sync();
		std::cout << "Enter a string: ";
		std::cin.getline(choice, 25);
		std::cout << "\"" << choice << "\"" << "\n";
	}