Entering values to a vector and print it

[patriic48]

I can´t get all the values to print and I get a value printed at the first row that isn´t supposed to be printed. Th build should be successful. No errors.

  #include <iostream>
#include <vector>

using namespace std;

vector<int> myVector;

int main()
{
	cout << "Type in a list of 5 numbers " << endl;

	for (int i = 0; i < 5; i++) 
	{
		int input;
		myVector.push_back(input);
		cin >> input;
	}

	for (int i = 0; i < 5; i++) 
	{
		cout << myVector[i] << endl;
	}

		return 0;
}

[Z e r e o]

I can´t get all the values to print and I get a value printed at the first row that isn´t supposed to be printed

The problem has to deal with you assigning the input into the vector before you are even taking it in.

int input;  // Non initialized so a random number will print first (Undefined behavior)
myVector.push_back(input); // Pushing to vector before getting input from user
cin >> input; // Finally get input. 

This results in undefined behavior on the first storage in the vector. The rest of the numbers you push back into the vector will be the previous loop iteration's input instead. That is why you are getting a wierd number and why not all numbers are showing up (Or seems that way).

[patriic48]

Solved it. Thank you :)

#include <iostream>
#include <vector>

using namespace std;

vector<int> myVector;

int main()
{
	cout << "Type in a list of 5 numbers " << endl;

	int input = 0;

	for (int i = 0; i < 5; i++) 
	{
		cin >> input;
		myVector.push_back(input);
		
	}

	for (int i = 0; i < 5; i++) 
	{
		cout << myVector[i] << endl;
	}

		return 0;
}