C++

Forum

 
Whats wrong with my Switch Statement?

arcadiu (82)
Basically I have this calculator program, and its going very well except one problem when using a switch statement.

This is my code, and whenever I use a switch statement OUTSIDE of int main() {}
it won't work and will just logout as soon as it runs the switch statement. As I said the one in int main works but for example in the area() {} function it wont work? I was wondering if anyone could help me solve this.

P.S If I try using an if statement it works as you can see in one of my functions however I think its best using a switch statement and I would like to know whats wrong for future reference.

Thanks in advance

Arc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
 
#include <iostream>
#include <math.h>
using namespace std;

int One;
int Two;
int choose;


void area() {
	
	cout << "Type one to find the area of a triangle, two to find the area of a square, three to find the area of a rectangle and four to find the area of a circle. ";
	
switch (choose) { // It won't work here though?
	case 1: 
		cout << "Please enter the base length of the triangle, followed by the height. ";
		cin >> One >> Two;
		cout << "The area of the triangle is" << "t" << One / 2 * Two;
		break;
	case 2:
		cout << "Please enter the length of one of the sides of the square please. ";
		cin >> One;
		cout << "The area of the square is" << "/t" << One * 2;
		break;
	case 3:	
		cout << "Please enter the length of the rectangle, followed by the height. ";
		cin >> One >> Two;
		cout << "The area of the rectangle is " << "/t" << One * Two;
		break;
	case 4:
		Two = 3.14;
		cout << "Please enter the radius of the cirlce please. ";
		cin >> One;
		cout << "The area of the cirlce is" << "/t" << Two * One * One;
		break;
}
}

void powers() {
float power;
	
	cout << "Please enter 1 for powers and 2 for square roots. ";
	cin >> choose;
	
	if (choose == 1) { // If statement works here rather than switch
		
		cout << "Please enter the number you would like to square and the number /nof times you would like to times it by it. ";
			cin >> One >> Two;
			cout << "\t" << pow(One, Two);
	}
			
	if (choose == 2) {
		
			cout << "Enter a number to find its square route. ";
			cin >> power;
			cout << "\t" << sqrt(power);
		
	}

}
	
void division() {
	
	cin >> One >> Two;
	cout << "\t" << One / Two;
	
}
	
void multiplication() {
	
	cin >> One >> Two;
	cout << "\t" << One * Two;
	
}

void addition() {

	cin >> One >> Two;
	cout << "\t" << One + Two;
	
}

void subtraction() {
	
	cin >> One >> Two;
	cout << "\t" << One - Two;
	
}

int main () {

	
	system ("clear");
	
	cout << "Press one for subtracting, two for adding, three, multiplication and four for division, five for powers and six for area.";
	cin >> choose;
	
	switch (choose) { // Works here
		case 1:
			subtraction();
			break;
		case 2:
			addition();
			break;
		case 3:
			multiplication();
			break;
		case 4:
			division();
			break;
		case 5:
			powers();
			break;
		case 6:
			area();
			break;
	
	
	}
	
		return 0;
}

R0mai (730)
Didn't you forget to ask for input in area()?
arcadiu (82)
oh ye LOL thanks sorry :)
Duthomhas (13212)
Line 13 is missing a cin >> choose;

By the way, I would recommend a more readable menu. For example:

1
2
3
4
5
6
7
8
9
10
 
    cout << "Choose one of the following:\n"
            "  1  Subtraction\n"
            "  2  Addition\n"
            "  3  Multiplication\n"
            "  4  Division\n"
            "  5  Exponentiation\n"
            "  6  Areas\n"
            "  7  Quit\n"
            "> ";
    cin >> choose;

The main menu could also go in a loop that only quits when the user chooses the "Quit" option.

Hope this helps.
arcadiu (82)
Yup thanks, any constructive critisim will be implemented.
Topic archived. No new replies allowed.