Variable Field Swap declared void??

[iggi]

Can anyone tell me what I am doing wrong here, this was simply meant to show the bubble sorting method, however it fails to compile with a Variable Field Swap Declared Void Message.

#include <iostream>
using namespace std;

void bubblesort(int *);
void swap(int *, int *);
int comp = 0;

int main(){
    int numbers[10] = {23,22,12,23,37,69,3,89,4,99};
    
    cout << "Original Data" << endl;
    for(int i = 0; i < 10; i++){
            cout << "\t" << numbers[i];
            }
bubblesort(numbers);
    cout << "Data items in ascending order" << endl;
    for(int i = 0; i < 10; i++){
            cout << "\t" << numbers[i];
            }
}

void bubblesort(int *numbers){
   for (int comp=1; comp < 10; comp++) {

       for (int i=0; i < (10-comp); i++) {
           if (numbers[i] > numbers[i+1]) {
           swap(&numbers[i], &numbers[i+1]);
           }
       }
   }
          }

void swap(*number1,*number2){
     int *temp = number1;
     number1 = number2;
     number2 = temp;
     return 1;
     }

[yang]

void swap(int *number1,int *number2)
{
	int temp = *number1;
	*number1 = *number2;
	*number2 = temp;
}

you should use pointers to change the value instead of change the pointers.

[guruplus]

@iggi

You declared the swap function return void, and, in the function, you return 1,
it does not work, delete the line it works
and use as what @yang said.

void swap(*number1,*number2){
     int *temp = number1;
     number1 = number2;
     number2 = temp;
     return 1;
     }

[jsmith]

One other thing, swap() is a standard algorithm which is implemented as a template
function. Instead of writing the swap() function yourself, just delete it, and #include
<algorithm> and it should work correctly.

[iggi]

Return 1 was my bad, I originally had no return, however I had changed the function to int and tested it that way, but with no avail. I was specifically directed to code my own swap function using pass by reference by pointers.

[iggi]

Return 1 was my bad, I originally had no return, however I had changed the function to int and tested it that way, but with no avail. I was specifically directed to code my own swap function using pass by reference by pointers.

[yang]

in your function,you just swap two pointers. At the begining number1 pointed to number[i] and number2 pointed to number[i+1], after the swap, number1 pointed to number[i+1] and number2 pointed to number[i], but the value of number[i] and number[i+1] are not changed.