second largest factor

[ssandha]

need to find the second largest factor but my function keeps returning 1 all the time.

#include <iostream>
using namespace std;

int second_largest_factor(int n)
{
	int secondLargest=1;
	
	int i = 0;
	int count = 0;
	while( i < n/2  && count < 2)
	{
		if (n%i == 0 )
		{
			secondLargest = i;
			count++;
			i--;
		}

	}
	return secondLargest;
}

int main ()
{
	int f = 48;
	cout << second_largest_factor(f) << endl;
}

[novellof]

your while loop never starts because you set i = n/2 yet you want you loop to start when i is less than n/2...and on top of that you have another condition...

the second condition is met but the first condition is never met...

the && symbol means that both conditions have to be met for the while loop to execute.

[ssandha]

made change, still doesnt work

[novellof]

Sorry it doesn't work..I didn't know the solution but I just figured I would let you know that logic error in the code..

If you can please comment your code so I can better understand how you are thinking this out and what you expect to happen.

[ssandha]

i got it now man. anyways thanks for the help; appreciate it.
this was the sol

int second_largest_factor(int n)
{
int secondLargest=1;

int i = n/2;
int count = 0;
while( i >0 && count < 2)
{
if (n%i == 0 )
{
secondLargest = i;
count++;

}
i--;

}
return secondLargest;
}