using the find function

[Jhub]

Hello,
I am trying to use the find function to find when there is a period in a sentence.
The code I have written always finds a period even when there is not one.

  {
        bool found=false;
        cout<<"Enter a sentence: "<<endl;
        cin>>sentence;
    {
        if (found=sentence.find('.',0));
        found=true;
    }
        if (found=true)
        {
            cout << "Period found"<<endl;
        }
    }

For some reason it skips over my find code and goes strait to the cout?

[Stewbond]

Change line 6 to:
if ( sentence.find('.') != std::string::npos)

and line 9 to:
if (found == true)

[Jhub]

Of course..... I feel really dumb now

Thank you!

[Jhub]

one last thing I tried to add the word "stop" to find, it finds it if it is not entered with a period '.' but when I try to find "stop." it only finds '.'

why is that?

 {
        bool pfound=false;
        bool sfound=false;
        cout<<"Enter a sentence: "<<endl;
        cin>>sentence;
    {
        if (sentence.find('.') != std::string::npos)
        pfound=true;
        else if (sentence.find("stop")!= std::string::npos)
        sfound=true;
    }
        if (pfound)
        
            cout << "Period found"<<endl;
        
        if (sfound)
        
            cout<<"stop found"<<endl;
        

    }

[Jhub]

My code now only outputs if stop or period are found but not if they are not found why will it not display the not found if it does not find a period or the word stop?

{
        bool pfound=false;
        bool sfound=false;
        cout<<"Enter a sentence: "<<endl;
        cin>>sentence;
    
        if (sentence.find('.') != std::string::npos)
        pfound=true;
        
    
        if (pfound)
        
            cout << "Period found"<<endl;
            
        else (sentence.find('.')== std::string::npos);
        pfound=false;
        if (pfound)
        
            cout<<"period not found"<<endl;
        
        
        else if (sentence.find("stop")!= std::string::npos)
        sfound=true;
        
        if (sfound)
        
            cout<<"stop found"<<endl;
            
        else (sentence.find("stop")== std::string::npos);
        sfound=false;
        if (sfound)
        
            cout<<"stop not found"<<endl;
        
        
            
    }

[MiiNiPaa]

Because you messed up code blocks. That is how your program looks after proper identation and separating code into logic blocks:

if (sentence.find('.') != std::string::npos)
    pfound=true;
        
if (pfound)
    cout << "Period found"<<endl;
else 
    (sentence.find('.')== std::string::npos); //does nothing here

pfound=false; // always executed
if (pfound)
    cout<<"period not found"<<endl;
else if (sentence.find("stop")!= std::string::npos)
    sfound=true;

if (sfound)
    cout<<"stop found"<<endl;
else 
    (sentence.find("stop")== std::string::npos); //does nothing here

sfound=false;
if (sfound)
    cout<<"stop not found"<<endl;

use curly brackets if your if/else block will contain more than one line of code.

[Jhub]

got it, this worked

{
        bool pfound=false;
        bool sfound=false;
        cout<<"Enter a sentence: "<<endl;
        cin>>sentence;
    
        {if (sentence.find('.') != std::string::npos)
        pfound=true;
        
    
        if (pfound)
        
            cout << "Period found"<<endl;
            
        else 
        
            cout<<"period not found"<<endl;
        }
        
        {if (sentence.find("stop")!= std::string::npos)
        sfound=true;
        
        if (sfound)
        
            cout<<"stop found"<<endl;
        
            
        else 
        
            cout<<"stop not found"<<endl;
        }
        
            
    }

is this ugly code?

[Jhub]

I added the find function to say where "stop" was found or where '.' was found, but then I noticed it would not allow me to input sentences, so I change the cin to getline and now it skips over all my code?

{
        bool pfound=false;
        bool sfound=false;
        cout<<"Enter a sentence: "<<endl;
        getline(cin,sentence);
    std::size_t found=sentence.find('.');
        {if (sentence.find('.') != std::string::npos)
        pfound=true;
        
    
        if (pfound)
        
            cout << "The character '.' is located at index "<<found<<endl;
            
        else 
        
            cout<<"Your sentence does not contain the character '.'"<<endl;
        }
        std::size_t found1=sentence.find("stop");
        {if (sentence.find("stop")!= std::string::npos)
        sfound=true;
        
        if (sfound)
        
            cout<<"The word "<< "stop"<<" starts at index "<<found1<<endl;
        
            
        else 
        
            cout<<"Your sentence does not contain the word "<< "stop"<<endl;
        }
        
            
    }

[MiiNiPaa]

Is there std::cin >> something earlier in your code? if so: http://stackoverflow.com/questions/21567291/why-does-stdgetline-skip-input-after-a-formatted-extraction

[Jhub]

It can find '.' and/or "stop" now in a sentence, but the location it gives is incorrect. why would the getline change how it computes the location of what its looking for?

{
        bool pfound=false;
        bool sfound=false;
        cout<<"Enter a sentence: "<<endl;
        ((cin >> sentence).get() && std::getline(cin, sentence));
    std::size_t found=sentence.find('.');
        {if (sentence.find('.') != std::string::npos)
        pfound=true;
        
    
        if (pfound)
        
            cout << "The character '.' is located at index "<<found<<endl;
            
        else 
        
            cout<<"Your sentence does not contain the character '.'"<<endl;
        }
        std::size_t found1=sentence.find("stop");
        {if (sentence.find("stop")!= std::string::npos)
        sfound=true;
        
        if (sfound)
        
            cout<<"The word "<< "stop"<<" starts at index "<<found1<<endl;
        
            
        else 
        
            cout<<"Your sentence does not contain the word "<< "stop"<<endl;
        }
        
            
    }

[MiiNiPaa]

Csn you post both your input and result of your program?

[Jhub]

got it thank you, I found the error of my ways