Reading the rest of a string after a certain character

[Keri4141]

So what I am trying to do is have the program read a txt file, and have it spit out the list of strings after the @ sign in a new file.

So for example if I have a file named Emails.txt, containing [e-mail]
The program would spit out @yahoo.com in a new file, and continue to read the list of emails and repeat this process until eof.

For some reason it seems to be giving me a segmentation fault, which I have no idea how to work around.

 #include<iostream>
#include<fstream>

using namespace std;

int main() {

  string STRING;
	ifstream infile;
	ofstream outfile;
	outfile.open("myEMAILS.txt");
	infile.open ("domains.txt");
        while(!infile.eof())
        {
            int atsign;
	        getline(infile,STRING);
            for (int i = 0; i < STRING.size(); i++) //checks for the emails char length.
                {

                    if(STRING[i]=='@')
                    {
                        atsign=i; //assigns atsign where the STRING has @ char
                        break; //skips this for loop and goes to next for loop
                    }
                }
            for(int y=atsign;atsign<=STRING.size();y++)
                {
                    outfile<<STRING[y]; //write down the rest of the string starting at @ sign
                }

                    outfile<<"\n"; //after loop is done skip a line in the file.

        }
 infile.close();
    outfile.close();
        }

[coder777]

What happens if the '@' is not found?

string offers functions that simplifies the problem:

http://www.cplusplus.com/reference/string/string/find/
http://www.cplusplus.com/reference/string/string/substr/

[Yanson]

you need to #include <string> because you use std::string and std::getline.

string STRING; usually all uppercase letters means that its a constant you should use lowercase and a descriptive name.

	outfile.open("myEMAILS.txt");
	infile.open ("domains.txt");

just out of curiosity isn't this backwards? Shouldn't the infile be myEMAILS and the outfile be domains?

while(!infile.eof()) looping on eof is almost always wrong it should be more like while (getline(infile, STRING))

for(int y=atsign;atsign<=STRING.size();y++) should look more like this for (int y = atsign; y < STRING.size(); y++)

[Keri4141]

For the outfile.open("myEmails.txt") it has the domains and such, I was just too lazy to change the file names.

But I'll try and see if anything works thanks for your suggestions

[Keri4141]

Thanks for the suggestions it worked.

But it seemed to have a NULL symbol at the end of each domain name
why is this?

@yahooNUL
@gmailNUL

[Keri4141]

Nvm I fixed it