Sorting a vector problem

[patriic48]

Can´t sort array in ascending order of age in vector

// Bubblesort.cpp : Defines the entry point for the console application.
//

#include <iostream>
#include "stdafx.h"

using namespace std;

//Klass: contain a person with name and age
class Person
{
public:
	char* name;
	int age;

	//Metod: Sets the necessary info
	void SetInfo(char* _name, int _age)
	{
		name = _name;
		age = _age;
	}
};

// Funktion: LinearSearch: Search for a person in a list
int LinearSearch(Person* personArray, int key)
{
	for (int i = 0; i < 10; i++) //Go through the whole list
	{
		// Is it the number we are searching for?
		if (personArray[i].age == key)
			return i;
	}
	return -1; // Person were not found
}

// Function BubbleSort, sorting Person p[] by age
void BubbleSort(Person* p[], int _age)
{
	int age = _age;
	int max = 9;
	// The outer loop, going through all list
    for(int i = 0; i < max; i++)
	{
		//Inner loop, going through element by element
		int nrLeft = max - i; // To se how many has been gone through
		for (int j = 0; j < nrLeft; j++)
		{
			if (p[i].age[j] > p[i].age[j+1]) // Compare the elements
			{
				// Change place
				int temp = p[i].age[j];
				p[i].age[j] = p[i].age[j+1];
				p[i].age[j+1] = temp;


			}
		}
	}

		// Write the list
	for (int i = 0; i < 9; i++)
	{
		cout << p[i] << "\n";
	}
}

/*
void swap(Person &p, Person &q) 
{ 
	Person temp; 
	temp.name = p.name; 
	temp.age = p.age; 
	p.name = q.name; 
	p.age = q.age; 
	q.name = temp.name; 
	q.age = temp.age; 
}
*/

// Function: Main, start on program
int main()
{
	//Create a list with persons and fill it:
	Person myList[10];
	myList[0].SetInfo("Charles", 22);
	myList[1].SetInfo("Darwin", 21);
	myList[2].SetInfo("Phytagoras", 23);
	myList[3].SetInfo("Michelle", 65);
	myList[4].SetInfo("Carl", 76);
	myList[5].SetInfo("Cathrine", 54);
	myList[6].SetInfo("Marielle", 25);
	myList[7].SetInfo("Patrick", 85);
	myList[8].SetInfo("Oliver", 48);
	myList[9].SetInfo("Elinette", 52);

	//Search for a person in the list 
	int index = LinearSearch(myList, 54);

	//Write out searchresults
	if(index == -1)
		cout << "Person wasn´t found!";
	else
		cout << "The person you are looking for is named" << myList[index].name << " and is on index " << index << "\n\n";
	
	BubbleSort(p);

	cin.get();

	return 0;
};

[wildblue]

line 105 - main won't know what p is - did you mean to send myList? and your function definition takes two arguments but you're only sending one.

You have an array of 10 people who each have a name and an age. I'm not sure what you're trying to do with this? p[i].age[j] - You'd use p[i].age to access the age of the ith person. There is no separate array of ages to access with an index of j.

Also - it looks like you're trying to just switch the ages between the different records. You'd want to swap the whole person, not switch people's ages. (It looks like you started to write a function to swap the full identity?)


Edit: I stand to be corrected, but I believe #include "stdafx.h" needs to be listed first.

[patriic48]

Yes! I meant to send myList. How do I send two arguments to it? I have char* _name and int _age and it´s in the class?

I´m trying to use a bubblesort funtion to search through an array with name and age and sort the array in ascending order with the youngest age first. Person with age.

// Bubblesort.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include <iostream>

using namespace std;

//Klass: contain a person with name and age
class Person
{
public:
	char* name;
	int age;

	//Metod: Sets the necessary info
	void SetInfo(char* _name, int _age)
	{
		name = _name;
		age = _age;
	}
};

// Funktion: LinearSearch: Search for a person in a list
int LinearSearch(Person* personArray, int key)
{
	for (int i = 0; i < 10; i++) //Go through the whole list
	{
		// Is it the number we are searching for?
		if (personArray[i].age == key)
			return i;
	}
	return -1; // Person were not found
}

// Function BubbleSort, sorting Person myList[] by age
void BubbleSort(Person* myList[], char* _name, int _age)
{
	char* name = _name;
	int age = _age;
	int max = 9;
	// The outer loop, going through all list
    for(int i = 0; i < max; i++)
	{
		//Inner loop, going through element by element
		int nrLeft = max - i; // To se how many has been gone through
		for (int j = 0; j < nrLeft; j++)
		{
			if (myList[j] > myList[j+1]) // Compare the elements
			{
				// Change place
				Person temp; 
				temp.name = p.name; 
				temp.age = p.age; 
				p.name = q.name; 
				p.age = q.age; 
				q.name = temp.name; 
				q.age = temp.age; 


			}
		}
	}

		// Write the list
	for (int i = 0; i < 9; i++)
	{
		cout << myList[i] << "\n";
	}
}

/*
void swap(Person &p, Person &q) 
{ 
	Person temp; 
	temp.name = p.name; 
	temp.age = p.age; 
	p.name = q.name; 
	p.age = q.age; 
	q.name = temp.name; 
	q.age = temp.age; 
}
*/

// Function: Main, start on program
int main()
{
	//Create a list with persons and fill it:
	Person myList[10];
	myList[0].SetInfo("Charles", 22);
	myList[1].SetInfo("Darwin", 21);
	myList[2].SetInfo("Phytagoras", 23);
	myList[3].SetInfo("Michelle", 65);
	myList[4].SetInfo("Carl", 76);
	myList[5].SetInfo("Cathrine", 54);
	myList[6].SetInfo("Marielle", 25);
	myList[7].SetInfo("Patrick", 85);
	myList[8].SetInfo("Oliver", 48);
	myList[9].SetInfo("Elinette", 52);

	//Search for a person in the list 
	int index = LinearSearch(myList, 54);

	//Write out searchresults
	if(index == -1)
		cout << "Person wasn´t found!";
	else
		cout << "The person you are looking for is named" << myList[index].name << " and is on index " << index << "\n\n";
	
	BubbleSort(myList);

	cin.get();

	return 0;
};

[wildblue]

The name and age are public, so you wouldn't really need to send them as arguments. You could send the array, (and possibly the array size), into the function.

void BubbleSort(Person* myList[]) <- take out the []

You'd need to replace the p and q with the appropriate myList element. The sort function doesn't know what p and q are. If you're allowed to use the algorithm header, you could use the swap function to simplify the swapping here.

http://www.cplusplus.com/reference/algorithm/swap/