Help with output

[pals123]

My program runs, but when it doesn't display right output for management level, category, hours. Total employee counter is off by 1. Thank you!

#include <iostream>
#include <string>
#include <iomanip>
#include <sstream>


using namespace std;
string GetInput(string);
class Benefit{
private:
	string healthInsurance;
	double lifeInsurance;
	int vacationDays;

public:
	Benefit::Benefit();
	Benefit::Benefit(string healthInsurance, double lifeInsurance, int vacationDays);
	
	void displayBenefit();
	string getHealthInsurance();
	void setHealthInsurance(string heaIns);
	double getLifeInsurance();
	void setLifeInsurance(double lifeIns);
	int getVacationDays();
	void setVacationDays(int vacDays);

};


Benefit::Benefit(){
	healthInsurance = "Not Available";
	lifeInsurance = 0;
	vacationDays = 0;
}

Benefit::Benefit(string healthInsurance, double lifeInsurance, int vacationDays){
	this->healthInsurance = healthInsurance;
	this->lifeInsurance = lifeInsurance;
	this->vacationDays = vacationDays;
}
void Benefit::displayBenefit(){
		cout << "\nBenefit Information" << endl;
		cout << "________________________________" << endl;
		cout << "Health Insurance Company: " << getHealthInsurance() << endl;
		cout << "Life Insurance Amount: " << setprecision(2) << showpoint << fixed << getLifeInsurance() << endl;
		cout << "Vacation Days: " << getVacationDays() << " Days" << endl;
}

string Benefit::getHealthInsurance(){
	return healthInsurance;
}

void Benefit::setHealthInsurance(string heaIns){
	this->healthInsurance = heaIns;
}

double Benefit::getLifeInsurance(){
	return lifeInsurance;
}

void Benefit::setLifeInsurance(double lifeIns){
	this->lifeInsurance = lifeIns;

}
int Benefit::getVacationDays(){
	return vacationDays;
}

void Benefit::setVacationDays(int vacDays){
	this->vacationDays = vacDays;
}

//class iEmployee {
//public:
	//virtual double calculatePay() = 0;
//};

class Employee {
private:
	static int numEmployees;
	
protected:
	string firstName;
	string lastName;
	char gender;
	int dependents;
	double annualSalary;
	Benefit benefit;
	
	
public:
	
	Employee();
	Employee(string fname, string lname, char gen, int dep, double sal);
	string getFirstName();
	void setFirstName(string firstName);
	string getLastName();
	void setLastName(string lastName);
	char getGender();
	void setGender(char gen);
	int getDependents();
	void setDependents(int dep);
	void setDependents(string dep);
	double getAnnualSalary();
	void setAnnualSalary(double sal);
	void setAnnualSalary(string sal);
	void displayEmployee();
	void setBenefit(Benefit benenfit);
	Benefit getBenefit();
	static int getNumEmployees();
	double calculatePay();
	//Benefit Benefit;
};
int Employee::numEmployees = 0;
int Employee::getNumEmployees(){
	return numEmployees;
}
Employee::Employee() {
	firstName = "not given";
	lastName = "not given";
	gender = 'U';
	dependents = 0;
	annualSalary = 20000;
	numEmployees++;
}

Employee::Employee(string fname, string lname, char gen, int dep, double sal)
{
	this->firstName = fname;
	this->lastName = lname;
	this->gender = gen;
	this->dependents = dep;
	this->annualSalary = sal;
	numEmployees++;
}

int convertToInt(string thestring){
	int num;
	std::istringstream cin(thestring);
	cin >> num;
	return num;
}

double convertToDouble(string thestring) {
	double num;
	std::istringstream cin(thestring);
	cin >> num;
	return num;
}

string Employee::getFirstName() {
	return firstName;
}

string Employee::getLastName() {
	return lastName;
}

char Employee::getGender() {
	return gender;
}

int Employee::getDependents() {
	return dependents;
}

double Employee::getAnnualSalary() {
	return annualSalary;
}

void Employee::setFirstName(string fname) {
	this->firstName = fname;
}

void Employee::setLastName(string lname) {
	this->lastName = lname;
}

void Employee::setGender(char gen) {
	this->gender = gen;
}

void Employee::setDependents(int dep) {
	this->dependents = dep;
}

void Employee::setDependents(string dep) {
	int depInt = convertToInt(dep);
	this->dependents = depInt;
}

void Employee::setAnnualSalary(double sal) {
	this->annualSalary = sal;
}

void Employee::setAnnualSalary(string sal) {
	double salaryDouble = convertToDouble(sal);
	this->annualSalary = salaryDouble;
}

double Employee::calculatePay() {
	return annualSalary / 52.0;
}

void Employee::setBenefit(Benefit ben){
	benefit = ben;

}

Benefit Employee::getBenefit(){
	return benefit;
}





void Employee::displayEmployee() {
	cout << "First Name: \t" << firstName << "\n";
	cout << "Last Name:  \t" << lastName << "\n";
	cout << "Gender:\t\t" << gender << "\n";
	cout << "Dependents: \t" << dependents << "\n";
	cout << "Annual Salary:\t$" << annualSalary << "\n";
	cout << "Weekly Salary:\t$" << calculatePay() << endl;
	
	//benefit.displayBenefit();
	cout << endl << endl;
}



class Salaried :public Employee
{
private:
	const int MIN_MANAGEMENT_LEVEL = 0;
	const int MAX_MANAGEMENT_LEVEL = 3;
	const double BONUS_PERCENT = 10;
	int managementLevel;
public:

	Salaried();
	Salaried(string firstName, string lastName, char gen, int dep, double sal, Benefit ben, int manLevel), 
	Salaried(double sal, int manLevel);
	double Salaried::calculatePay();
	void Salaried::displayEmployee();
	
	int Salaried::getManagementLevel();
	void Salaried::setManagementLevel(int manLevel);
	
};
Salaried::Salaried():Employee(),MAX_MANAGEMENT_LEVEL(), MIN_MANAGEMENT_LEVEL(), BONUS_PERCENT(){
	setManagementLevel(MIN_MANAGEMENT_LEVEL);
}
	
Salaried::Salaried(string firstName, string lastName, char gen, int dep, double sal, Benefit ben, int manLevel) : Employee(firstName, lastName, gen, dep, sal), MIN_MANAGEMENT_LEVEL(0), MAX_MANAGEMENT_LEVEL(3), BONUS_PERCENT(10)
{
	setManagementLevel(manLevel);
}
	
Salaried::Salaried(double sal, int manLevel){
	setManagementLevel(manLevel);
	setAnnualSalary(sal);
}
	
int Salaried::getManagementLevel(){
	return managementLevel;
}
	
void Salaried::setManagementLevel(int manLevel){
	if (manLevel >= MIN_MANAGEMENT_LEVEL && manLevel <= MAX_MANAGEMENT_LEVEL)
		managementLevel = manLevel;
	else if (manLevel < MIN_MANAGEMENT_LEVEL)
	{
		managementLevel = MIN_MANAGEMENT_LEVEL;
	}
	else if (manLevel > MAX_MANAGEMENT_LEVEL)
	{
		managementLevel = MAX_MANAGEMENT_LEVEL;
	}
}
double Salaried::calculatePay(){
	double bPercent = managementLevel * BONUS_PERCENT;
	double bonus = bPercent * getAnnualSalary();
	setAnnualSalary(getAnnualSalary() + bonus);
	return Salaried::getAnnualSalary()/52;
}

void Salaried::displayEmployee(){
	//Employee::displayEmployee();
	
	cout << "Salaried Employee:\t" << endl;
	cout << "Management Level:\t" << Salaried::getManagementLevel() << endl;
}

[pals123]

class Hourly :public Employee{

private:
	const int MIN_WAGE = 10;
	const int MAX_WAGE = 75;
	const int MIN_HOURS = 0;
	const int MAX_HOURS = 50;
	double wage;
	double hours;
	string category;

public:
	Hourly();
	Hourly(double wage, double hours, string cat);
	Hourly(string firstName, string lastName, char gen, int dep, double wage, double hours, Benefit Benefit, string cat);
	double calculatePay();
	void setAnnualSalary();
	void displayEmployee();

	double getWage();
	void setWage(double wage);
	double getHours();
	void setHours(double hours);
	string getCategory();
	void setCategory(string cat);


};
Hourly::Hourly():Employee(){
	wage = MIN_WAGE;
	hours = MIN_HOURS;
	category = "Not Available";
}



Hourly::Hourly(string firstName, string lastName, char gen, int dep, double wage, double hours, Benefit Benefit, string cat){
	setWage(wage);
	setHours(hours);
	setCategory(cat);
}

Hourly::Hourly(double wage, double hours, string category){
	setWage(wage);
	setHours(hours);
	setCategory(category);
}
double Hourly::calculatePay(){
	double calcPay = getHours() * getWage();
	return calcPay;
}

void Hourly::setAnnualSalary(){
	Employee::setAnnualSalary(calculatePay() * 52);
}



double Hourly::getWage(){
	return wage;
}
void Hourly::setWage(double wage){
	if (wage >= MIN_WAGE && wage < MAX_WAGE)
	{
		wage = wage;
	}
	else if (wage < MIN_WAGE)
	{
		wage = MIN_WAGE;
	}
	else if (wage > MAX_WAGE)
	{
		wage = MAX_WAGE;
	}
}

double Hourly::getHours(){
	return hours;
}
void Hourly::setHours(double hours){
	if (hours >= MIN_HOURS && hours <= MAX_HOURS)
	{
		hours = hours;
	}
	else if (hours < MIN_HOURS)
	{
		hours = MIN_HOURS;
	}
	else if ( hours > MIN_HOURS)
	{
		hours = MAX_HOURS;
	}
}
string Hourly::getCategory(){
	return category;
}

void Hourly::setCategory(string cat){
	if (category == "full time" || category == "part time" || category == "temporary")
	{
		category = cat;
	}
	else
	{
		category = "Not Available";
	}
}
void Hourly::displayEmployee(){
	//Employee::displayEmployee();
	cout << "Hourly Employee: " << endl;
	cout << "Category: \t\t" << getCategory() << endl;
	cout << "Wage: \t\t" << getWage()<< endl;
	cout << "Hours: \t\t" << getHours() << endl;

}


void DisplayDivider(string outputTitle)	{
	cout << "**************** " << outputTitle << " ****************" << endl;
}

void DisplayApplicationInformation(){
	cout << "Welcome to your first Object Oriented Program -- Employee ClassCIS247C.  Week 4 Lab" << endl;
	cout << "Name: " << endl;


}

string GetInput(string inputType){
	string strInput;
	cout << "Enter the " << inputType << ": ";
	cin >> strInput;
	return strInput;
}

int main()
{
	
	Employee employee1;
	string input;
	char gen;
	int dep;
	double salary;
	int manLevel;
	//Benefit benefit;
	DisplayApplicationInformation();
	DisplayDivider("Employee 1");
	input = GetInput("First Name");
	employee1.setFirstName(input);
	input = GetInput("Last Name");
	employee1.setLastName(input);
	cout << "Please enter your Gender: ";
	cin >> gen;
	employee1.setGender(gen);
	input = GetInput("Dependents");
	employee1.setDependents(input);
	input = GetInput("Annual Salary");
	employee1.setAnnualSalary(input);
	
	Benefit benefitEmp;
	//employee1.setBenefit(benefitEmp);
	
	input = GetInput("Life Insurance Amount");
	benefitEmp.setLifeInsurance(atof(input.c_str()));
	input = GetInput("Vacation Days");
	benefitEmp.setVacationDays(atoi(input.c_str()));
	input = GetInput("Health Insurance Company");
	benefitEmp.setHealthInsurance(input);
	
	DisplayDivider("Employee Information");
	employee1.displayEmployee();
	benefitEmp.displayBenefit();
	//employee1->getNumEmployees();
	
	cout << "Total employees: " << employee1.getNumEmployees() << endl;
	
	
	DisplayDivider("Employee 2");
	

	Employee employee2;
	
	
	Salaried salariedEmp;
	Benefit benefitEmp2;
	input = GetInput("First Name");
	employee2.setFirstName(input);
	input = GetInput("Last Name");
	employee2.setLastName(input);
	cout << "Please enter your Gender: ";
	cin >> gen;
	employee2.setGender(gen);
	input = GetInput("Dependents");
	employee2.setDependents(input);
	input = GetInput("Annual Salary");
	employee2.setAnnualSalary(input);
	salariedEmp.calculatePay();
	input = GetInput("Life Insurance Amount");
	benefitEmp2.setLifeInsurance(atof(input.c_str()));
	input = GetInput("Vacation Days");
	benefitEmp2.setVacationDays(atoi(input.c_str()));
	input = GetInput("Health Insurance Company");
	benefitEmp2.setHealthInsurance(input);
	
	input = GetInput("Management Level");
	salariedEmp.setManagementLevel(atoi(input.c_str()));
	

	DisplayDivider("Employee Information");

	employee2.displayEmployee();
	salariedEmp.displayEmployee();

	cout << "Total employees: " << employee2.getNumEmployees() << endl;
	DisplayDivider("Employee 3");
	

	Employee employee3;
	Benefit benefitEmp3;
	
	Hourly hourlyEmp;
	input = GetInput("First Name");
	employee3.setFirstName(input);
	input = GetInput("Last Name");
	employee3.setLastName(input);
	cout << "Please enter your Gender: ";
	cin >> gen;
	employee3.setGender(gen);
	input = GetInput("Dependents");
	employee3.setDependents(input);
	input = GetInput("Annual Salary");
	employee3.setAnnualSalary(input);
	input = GetInput("Life Insurance Amount");
	benefitEmp3.setLifeInsurance(atof(input.c_str()));
	input = GetInput("Vacation Days");
	benefitEmp3.setVacationDays(atoi(input.c_str()));
	input = GetInput("Health Insurance Company");
	benefitEmp3.setHealthInsurance(input);



	input = GetInput("Management Level");
	salariedEmp.setManagementLevel(atoi(input.c_str()));
	input = GetInput("Wage");
	hourlyEmp.setWage(atof(input.c_str()));
	input = GetInput("Hours");
	hourlyEmp.setHours(atoi(input.c_str()));
	hourlyEmp.calculatePay();
	
	
	input = GetInput("Category");
	hourlyEmp.setCategory(input);
	DisplayDivider("Employee Information");

	employee3.displayEmployee();
	benefitEmp3.displayBenefit();
	hourlyEmp.displayEmployee();

	cout << "Total employees: " << employee3.getNumEmployees() << endl;
	system("pause");
	return 0;
}

[pals123]

Can someone help me?

[coder777]

but when it doesn't display right output for management level, category, hour

What does that mean?

[pals123]

It gives me the default settings as output. So, whatever I initialized them to is what I'm getting as output no matter what I enter as input.

[coder777]

What is 'it'? Please describe your problem more in detail. There's too much code to skim through

[wildblue]

Total employee counter is off by 1

When you create a class that inherits from another, for example, Salaried and Hourly both inherit from Employee, the default constructor of the base class is called. The default constructor of the Employee class increments the employee counter, so when you create both an Employee object and a Salaried object to represent the same person, you are incrementing the employee counter twice.

	Employee employee2;
	
	Salaried salariedEmp;

	Employee employee3;
	//Benefit benefitEmp3;
	
	Hourly hourlyEmp;

http://www.cplusplus.com/doc/tutorial/inheritance/

Although the constructors and destructors of the base class are not inherited as constructors and destructors in the derived class, they are still called by the derived class's constructor. Unless otherwise specified, the constructors of derived classes call the default constructors of their base classes (i.e., the constructor taking no arguments), which must exist.

Edit: When you are within the class declaration, you don't need the class scope resolution Salaried, for example here, in the function prototypes. This gave me a compiler error.

	int Salaried::getManagementLevel();
	void Salaried::setManagementLevel(int manLevel);

The third employee is an hourly employee, but you're asking for management level which only applies to salaried employees? (line 242-243) Not sure if you should also ask for annual salary for an hourly employee if you're going to ask for wage and hour info?

[pals123]

I fixed the counter - thank you. Employee 3 is also going to have an annual salary. He also needs wage and hour info. I still don't know why the other functions are not working.

[wildblue]

You have constant variables here. They have values and can't be changed.

private:
	const int MIN_MANAGEMENT_LEVEL = 0;
	const int MAX_MANAGEMENT_LEVEL = 3;
	const double BONUS_PERCENT = 10;

I'm not sure what you're trying to do with them in the constructors? I'd take out the references to those constant variables in the constructors. Then your set management level function seems to work. (and then you'll print out the value you expect for mgmt level).

Salaried::Salaried():Employee(),MAX_MANAGEMENT_LEVEL(), MIN_MANAGEMENT_LEVEL(), BONUS_PERCENT(){
	setManagementLevel(MIN_MANAGEMENT_LEVEL);
}
	
Salaried::Salaried(string firstName, string lastName, char gen, int dep, double sal, Benefit ben, int manLevel) : Employee(firstName, lastName, gen, dep, sal), MIN_MANAGEMENT_LEVEL(0), MAX_MANAGEMENT_LEVEL(3), BONUS_PERCENT(10)
{
	setManagementLevel(manLevel);
}

[pals123]

I got everything to work except category. I cannot get it to display any of the options in category. Can someone help?

string Hourly::getCategory(){
	return category;
}

void Hourly::setCategory(string cat){
	if (category == "full time" || category == "part time" || category == "temporary")
	{
		category = cat;
	}
	else
	{
		category = "Not Available";
	}
}

[darkstorm1212]

i think you can try changing form 0 into 1 . the best way, you can assess into this web http://www.tuicoding.com/, then you post your code into a program and it will fix your mistake

[wildblue]

If you're checking the value that was sent into the function, you'd want to compare cat, not category.

void Hourly::setCategory(string cat){
	if (category == "full time" || category == "part time" || category == "temporary")
	{
		category = cat;
	}
	else
	{
		category = "Not Available";
	}
}