Bad Output

[pals123]

Hi,

I've been working on this program since last week. Can someone help? It's suppose to display benefit information for employee 1 and 2, but is only displaying information for employee 2.

Thank you!

 using namespace std;
string GetInput(string);



class iEmployee {
public:
	virtual double calculatePay() = 0;
};

class Benefit{
private:
	string healthInsurance;
	double lifeInsurance;
	int vacationDays;



public:
	Benefit();
	Benefit(string healthInsurance, double lifeInsurance, int vacationDays);
	void displayBenefit();
	string getHealthInsurance();
	void setHealthInsurance(string heaIns);
	double getLifeInsurance();
	void setLifeInsurance(double lifeIns);
	int getVacationDays();
	void setVacationDays(int vacDays);



};



Benefit::Benefit(){


	healthInsurance = "Not Available";
	lifeInsurance = 0;
	vacationDays = 0;

}

Benefit::Benefit(string healthInsurance, double lifeInsurance, int vacationDays){
	this->healthInsurance = healthInsurance;
	this->lifeInsurance = lifeInsurance;
	this->vacationDays = vacationDays;
}




void Benefit::displayBenefit(){

	cout << "\nBenefit Information" << endl;
	cout << "________________________________" << endl;

	
	cout << "Health Insurance Company: " << healthInsurance << endl;
	cout << "Life Insurance Amount: " << setprecision(2) << showpoint << fixed << lifeInsurance << endl;
	cout << "Vacation Days: " << vacationDays << endl;
}

string Benefit::getHealthInsurance(){
	return healthInsurance;
}


void Benefit::setHealthInsurance(string heaIns){
	this->healthInsurance = heaIns;
}

double Benefit::getLifeInsurance(){
	return lifeInsurance;
}

void Benefit::setLifeInsurance(double lifeIns){
	this->lifeInsurance = lifeIns;

}
int Benefit::getVacationDays(){
	return vacationDays;
}

void Benefit::setVacationDays(int vacDays){
	this->vacationDays = vacDays;

}

class Employee{
private:
	static int numEmployee;

//protected:
	string firstName;
	string lastName;
	char gender;
	int dependents;
	double annualSalary;
	//Benefit Benefit;
public:
	Employee();
	Employee(string firstName, string lastName, char gender, int dependents, double salary);
	void virtual displayEmployee();
	string getFirstName();
	void setFirstName(string firstName);
	string getLastName();
	void setLastName(string lastName);
	char getGender();
	void setGender(char gen);
	int getDependents();
	void setDependents(int dep);
	void setDependents(string dep);
	double getAnnualSalary();
	void setAnnualSalary(double salary);
	void setAnnualSalary(string salary);
	//void displayEmployee();
	double calculatePay();
	static int numEmployees;
	Benefit Benefit;


};

int Employee::numEmployees = 0;

Employee::Employee() {
	firstName = "not given";
	lastName = "not given";
	gender = 'U';
	dependents = 0;
	annualSalary = 20000;
	numEmployees++;
}

Employee::Employee(string firstName, string lastName, char gender, int dependents, double salary)
{
	this->firstName = firstName;
	this->lastName = lastName;
	this->gender = gender;
	this->dependents = dependents;
	this->annualSalary = salary;
	numEmployees++;
}

int convertToInt(string thestring){
	int num;
	std::istringstream cin(thestring);
	cin >> num;
	return num;
}

double convertToDouble(string thestring) {
	double num;
	std::istringstream cin(thestring);
	cin >> num;
	return num;
}

string Employee::getFirstName() {
	return firstName;
}

string Employee::getLastName() {
	return lastName;
}

char Employee::getGender() {
	return gender;
}

int Employee::getDependents() {
	return dependents;
}

double Employee::getAnnualSalary() {
	return annualSalary;
}

void Employee::setFirstName(string firstName) {
	this->firstName = firstName;
}

void Employee::setLastName(string lastName) {
	this->lastName = lastName;
}

void Employee::setGender(char gen) {
	this->gender = gen;
}

void Employee::setDependents(int dep) {
	this->dependents = dep;
}

void Employee::setDependents(string dep) {
	int depInt = convertToInt(dep);
	this->dependents = depInt;
}

void Employee::setAnnualSalary(double salary) {
	this->annualSalary = salary;
}

void Employee::setAnnualSalary(string salary) {
	double salaryDouble = convertToDouble(salary);
	this->annualSalary = salaryDouble;
}

double Employee::calculatePay() {
	return annualSalary / 52.0;
}

void Employee::displayEmployee() {
	cout << "First Name: \t" << firstName << "\n";
	cout << "Last Name:  \t" << lastName << "\n";
	cout << "Gender:\t\t" << gender << "\n";
	cout << "Dependents: \t" << dependents << "\n";
	cout << "Annual Salary:\t$" << annualSalary << "\n";
	cout << "Weekly Salary:\t$" << calculatePay() << endl;
	this->Benefit.displayBenefit();
	cout << endl << endl;
}


void DisplayDivider(string outputTitle)	{
	cout << "**************** " << outputTitle << " ****************" << endl;
}

void DisplayApplicationInformation(){
	cout << "Welcome to your first Object Oriented Program -- Employee ClassCIS247C.  Week 4 Lab" << endl;
	cout << "" << endl;


}

string GetInput(string inputType){
	string strInput;
	cout << "Enter the " << inputType << ": ";
	cin >> strInput;
	return strInput;
}

int main()
{
	Employee* employee1 = new Employee();

	Benefit* benefit1 = new Benefit();

	string input;
	char gen;
	int dep;
	double salary;
	DisplayApplicationInformation();
	DisplayDivider("Employee 1");
	input = GetInput("First Name");
	employee1->setFirstName(input);
	input = GetInput("Last Name");
	employee1->setLastName(input);
	cout << "Please enter your Gender: ";
	cin >> gen;
	employee1->setGender(gen);
	input = GetInput("Dependents");
	employee1->setDependents(input);
	input = GetInput("Annual Salary");
	employee1->setAnnualSalary(input);

	input = GetInput("Life Insurance Amount");
	employee1->Benefit.setLifeInsurance(atof(input.c_str()));
	input = GetInput("Vacation Days");
	employee1->Benefit.setVacationDays(atoi(input.c_str()));
	input = GetInput("Health Insurance Company");
	employee1->Benefit.setHealthInsurance(input);

	DisplayDivider("Employee Information");
	employee1->displayEmployee();
	benefit1->displayBenefit();

	cout << "Total employees: " << employee1->numEmployees << endl;
	DisplayDivider("Employee 2");
	Employee* employee2 = new Employee("Mary", "Noia", 'F', 5, 24000.0);

	Benefit* benefit2 = new Benefit("Washington Mutual", 500000, 7);


	DisplayDivider("Employee Information");

	employee2->displayEmployee();
	benefit2->displayBenefit();

	cout << "Total employees: " << employee2->numEmployees << endl;
	system("pause");
	return 0;
}

[Chervil]

It looks a bit mixed-up.
Inside class Employee, is declared a public member variable at line 121,

	Benefit Benefit;

(though it's probably not a good choice to make the name of the variable the same as that of the class).

For employee1 that data member is used, and at lines 269 to 274, the data input is collected from cin. At line 277 the details, including benefit, are output.

There is also an extraneous benefit1 defined at line 249 and output at line 278, That is simply not needed.


In the case of employee2, the opposite pattern is followed, The internal Benefit member is ignored, and instead a separate external benefit2 is used.

I've no idea what is the goal of this project, but employee1 looks more likely to be the correct approach, and employee2 similarly should be making use of its internal Benefit data member. (Both benefit1 and benefit2 can be removed).

[pals123]

I took out line 249, 278, and 290. But now benefit2 will not display properly. The information is not passing before it outputs. Also, if I take out
Benefit Benefit as a public member, I get errors. What is another way to declare Benefiit inside Employee class? Thank you!

[Chervil]

Maybe like this, instead of a standalone Benefit,

    //Benefit*  benefit2  = new Benefit("Washington Mutual", 500000, 7); 

use the one which is part of the Employee class

    employee2->benefit  = Benefit("Washington Mutual", 500000, 7);

[pals123]

I typed in employee2->Benefit = Benefit ("Washington Mutual", 500000, 7);
and it's working! Thank you!!