Doing arithmetic in functions

[jlken]

Hi. I'm trying to make a program to do some simple arithmetic for random numbers but for some reason, my getResult function isn't working. It's compiling fine but it seems to just put some random number as my results instead of what I specified in my function. Thanks in advance.

#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;

void generate2Digits (int&, int&);
void generateOperation (char&);
void printExpression (int, int, char);
int getResult (int, int, char);

int main ()
{
int a, b, result;
char operand;
srand (time (NULL));

printExpression (a, b, operand);
getResult (a, b, operand);
cout << result;
}

void generate2Digits (int& a, int& b)
{
	a = rand () % (9 - 1) + 1;
	b = rand () % (9 - 1) + 1;
}

void generateOperation (char& operand)
{
	operand = rand () % 3;
		
		switch (operand)
		{
			case 0: cout << "+";
					break;
			case 1: cout << "-";
					break;
			case 2: cout << "*";
					break;
		}
	
}

void printExpression (int a, int b, char operand)
{
	generate2Digits (a, b);
		{
		cout << a << " "; 
		generateOperation (operand);
		cout <<  " " << b << "=" << " ?" << endl;
	
		}
	
}

int getResult (int a, int b, char operand)
{
	int result;
	
	if (operand = 0)
		result = a + b;
	else if (operand = 1)
		result = a - b;
	else result = a * b;
	
	return result;
	
}

[Cody0023]

You are using the assignment operator in your logic conditions.

use ==

[jlken]

Sorry but which logic conditions are you referring to.

[Chervil]

Line 18, getResult() returns a value, it should be assigned to the variable result.

Function printExpression(), despite its name, doesn't just print. It actually generates the values. Therefore its parameters should each be passed by reference.

As already mentioned, you should use the == operator to test for equality rather than the = assignment operator. That's in the if statements within function getResult().

[jlken]

I see. Thank you very much for the help.