Is my code written correct ?

[jakvrh1]

I am new to pointers... I am just interest if my code is written correct. I know it has calculator ( ex. 5 + 10 ) + swap function inside which is kinda stupid...

#include <iostream>

using namespace std;

void calculator(char oper, int x, int y);
void swap1 (int *x, int *y);

int main ()
{
    int number1, number2;
    char oper;
    int *p_number1 = & number1;
    int *p_number2 = & number2;

    cout << "Enter your number" << '\n';
    cin >> *p_number1 >> oper >> *p_number2;
    calculator(oper, number1, number2);
    cout << '\n';

    cout << "number1 = " << *p_number1 << endl;
    cout << "number2 = " << *p_number2 << endl;

    swap1 (p_number1, p_number2);
    cout << *p_number1 << " " << *p_number2 << endl;
    cout << number1 << " " << number2;
}

void calculator (char oper, int x, int y)
{
    switch (oper)
    {
case '/':
    cout << x / y;
    break;

case '*':
    cout << x * y;
    break;

case '+':
    cout << x + y;
    break;

case '-':
    cout << x - y;
    break;
    }
}

void swap1 (int *x, int *y)
{
    swap(*x, *y);
}

[MiiNiPaa]

Yes. It is correctly written.

Just FYI: there is std::iter_swap() function which does exacly what you have written in your swap1 function

[jakvrh1]

I do know that you can make it simpler, tho I used function because of pointers :D. And thanks for your answer!