Roguelike wont draw character movement in array

[Antone333]

if you compile this program and test out the arrow keys it appears like nothing is happening. but pay attention to how many presses you make and move the character towards a + or a -. when you touch one then it takes you to the next map. but the character does not get shown moving.

please help me understand what i am doing wrong.

#include <iostream>
#include "windows.h"

using namespace std;

int World1();
int World2();
int World3();

char Map[100][100];

int x = 1;
int y = 1;

int Level_Sel = 2;

int Enter_Level = 0;

bool Game_Running = true;

int main()
{
    while(Game_Running)
    {
        system("cls");
        
        if(Level_Sel == 1)
        {
             World1();
        }
        else if(Level_Sel == 2)
        {
             World2();
        }
        else if(Level_Sel == 3)
        {
             World3();
        }

        if(GetAsyncKeyState(VK_DOWN))
         {
              int y2 = y+1;
            
              if(Map[y2][x] == '+')
              {
                   Level_Sel = Level_Sel + 1;
                   Enter_Level = 0;
              }
              else if(Map[y2][x] == '-')
              {
                   Level_Sel = Level_Sel - 1;
                   Enter_Level = 0;
              }
              else if(Map[y2][x] == ' ') //this should move the character
              {
                   Map[y][x] = ' ';
                   y++;
                   Map[y][x] = '@';
              }
         }
         
         if(GetAsyncKeyState(VK_UP))
         {
              int y2 = y-1;
            
              if(Map[y2][x] == '+')
              {
                   Level_Sel = Level_Sel + 1;
                   Enter_Level = 0;
              }
              else if(Map[y2][x] == '-')
              {
                   Level_Sel = Level_Sel - 1;
                   Enter_Level = 0;
              }
              else if(Map[y2][x] == ' ')//this should move the character
              {
                   Map[y][x] = ' ';
                   y--;
                   Map[y][x] = '@';
              }
         }
         if(GetAsyncKeyState(VK_RIGHT))
         {
              int x2 = x+1;
              
              if(Map[y][x2] == '+')
              {
                   Level_Sel = Level_Sel + 1;
                   Enter_Level = 0;
              }
              else if(Map[y][x2] == '-')
              {
                   Level_Sel = Level_Sel - 1;
                   Enter_Level = 0;
              }
              else if(Map[y][x2] == ' ')//this should move the character
              {
                   Map[y][x] = ' ';
                   x++;
                   Map[y][x] = '@';
              }
         }
         
         if(GetAsyncKeyState(VK_LEFT))
         {
              int x2 = x-1;
            
              if(Map[y][x2] == '+')
              {
                   Level_Sel = Level_Sel + 1;
                   Enter_Level = 0;
              }
              else if(Map[y][x2] == '-')
              {
                   Level_Sel = Level_Sel - 1;
                   Enter_Level = 0;
              }
              else if(Map[y][x2] == ' ')//this should move the character
              {
                   Map[y][x] = ' ';
                   x--;
                   Map[y][x] = '@';
              }
         }
    } 
    
    system("PAUSE");
    return 0;
}

int World1()
{
    if(Enter_Level == 0)
    {
         x = 1;
         y = 1;
         Enter_Level = 1;
    }
    
    char Level[100][100] =
    {
         "##########",
         "#@       #",
         "#        #",
         "#        #",
         "#      + #",
         "##########"
    };
    memcpy(Map, Level, sizeof(Level));
    
    for(int display=0; display<10; display++)
    {
         cout << Map[display] << endl;
    }
    
    system("pause>nul");
}

int World2()
{
        if(Enter_Level == 0)
    {
         x = 1;
         y = 1;
         Enter_Level = 1;
    }
    
    char Level[100][100] =
    {
         "##########",
         "#@       #",
         "#        #",
         "#        #",
         "# -    + #",
         "##########"
    };
    memcpy(Map, Level, sizeof(Level));
    
    for(int display=0; display<10; display++)
    {
         cout << Map[display] << endl;
    }
    
    system("pause>nul");
}

int World3()
{
    if(Enter_Level == 0)
    {
         x = 1;
         y = 1;
         Enter_Level = 1;
    }
    
    char Level[100][100] =
    {
         "##########",
         "#@       #",
         "#        #",
         "#        #",
         "# -      #",
         "##########"
    };
    memcpy(Map, Level, sizeof(Level));
    
    for(int display=0; display<10; display++)
    {
         cout << Map[display] << endl;
    }
    
    system("pause>nul");
}

[MiiNiPaa]

On each iteration of the loop it calls World2() which completely overwrites your Map array with default values.

[Antone333]

and how would you suggest i fix it?

i tried doing this but it still does not work

if(Enter_Level == 0)
{
if(Level_Sel == 1)
{
World1();
}
else if(Level_Sel == 2)
{
World2();
}
else if(Level_Sel == 3)
{
World3();
}
}

[MiiNiPaa]

Move it before the loop so it would not be called on each iteration

[Antone333]

so do this?

it makes it appear like really nothing is happening

int main()
{
if(Level_Sel == 1)
{
World1();
}
else if(Level_Sel == 2)
{
World2();
}
else if(Level_Sel == 3)
{
World3();
}

while(Game_Running)
{

}

}

[Antone333]

ok i figured it out. Thanks a lot!

[MiiNiPaa]

You are not drawing anything in your loop either. So you will not see any changes.

Also I must note that you have WorldX function declared as returnin int, but you are not returning anything.