ifstream overflow in while loop

[MrBeavis]

Hi Guys,

Im stuck on how to break out of this loop when it hits eof(it out puts the last line twice). all the research ive done says to use a break statement however we are not allowed to do that in this class. any help would be greatly appreciated.

#include <iostream>
#include <fstream>
#include <cstring>

using namespace std;

struct student{
	char name[128];
	int mark;
};

void insertionSortStrings(student array[100], int length);

int main ()
{
	int size = sizeof(student);

	ifstream ins;
	ins.open("marks.txt");

	student record[100];

	if(!ins.good())
	{
	cout << "Error reading file." << endl;
	return 0;
	}

	else
	{

		int i = 0;
		while(!ins.eof());
		{
			ins >> record[i].name;
            		ins >> record[i].mark;
			i++;
		}

	insertionSortStrings(record, i);

	for (int j=0; j<i; j++)
	{
		cout << record[j].name << "\t" << record[j].mark << endl;
	}
	}


	return 0;
}



void insertionSortStrings(student array[], int length)
{
	for (int i = 1; i < length; i++)
	{
		for (int k = i; k > 0 && array[k].mark > array[k-1].mark; k--)
		{
		student temp;
		temp = array[k];
		array[k] = array[k-1];
		array[k-1] = temp;
		}
	}
}

[gudeh]

you have a ';' closing your while btw, you sure it's reaching the end?

[gudeh]

I'd use something like:
while(getline(ins,string my_string))
thats the only way I know to stop the while before the last loop you are getting. I suppose you can use C++ features.

[coder777]

The best would be:

		int i = 0;
		while(ins >> record[i].name >> record[i].mark) // Note: no ;
		{
			i++;
		}

But you can also do this

		int i = 0;
		while(!ins.eof()) // Note: no ;
		{
			ins >> record[i].name;
            		ins >> record[i].mark;
            		if(!ins.eof())
			  i++;
		}

[MrBeavis]

oh i didnt see that ;
that was from when i was messing about with other ideas. thanks guys they worked perfectly :)