C++ Vector Swap with multiple objects - not working propperly

[venros]

Hi guys,

I'm having an issue with my show rank function:

  void HighScore::ShowRank(HighScore & account) {
  if(account.highScore.size() == 0){ cout << "The score board is empty." << endl; }
  for (int i = 0; i < account.highScore.size() - 2; i++) {
    if (account.highScore[i] > account.highScore[i + 1]) {
      swap(account.highScore[i], account.highScore[i + 1]);
    }

    for (int j = 0; j < account.highScore.size(); j++) {
      cout << "Rank " << j+1 << ". " << account.highScore[j] << endl;
    }
  }
  system("pause");
  system("cls");
}

Currently the way I have set it up is: aManager.ManageAccounts(aManager;
inside ManageAccounts aManager allocates a new Object: AccountManager NEWUSER = account.newUser();

It currently does not swap and when it COUTS it couts 3x for all 3 objects (I only want it to cout NEWUSER. I will link my full code bellow (Too long):

https://gist.github.com/Lawrence-Abadier/731b0db651fd7d6f9568#file-fstreamuserscore-cpp-L74-L87

Mind you I want to simply run in the last object and not multiple objects:

score.ShowRank(score); to score.ShowRank(); but have it still work via reference.

Thank you,

Sorry if this was complicated, feel free to ask me questions if I was too confusing.

[helios]

1. What are lines 3-6 supposed to be accomplishing? Is it a sort?
2. Why does a function with "Show" in its name modify the data it shows?
3. Why is an output loop inside another loop that modifies what is displayed?
4. Don't pass an object of the class to class member functions. This construction: object.function(object) is particularly unnecessary. Just object.function() is enough. You can refer to object inside the function by means of the this pointer.

[venros]

1. What are lines 3-6 supposed to be accomplishing? Is it a sort?
It is a sort

2. Why does a function with "Show" in its name modify the data it shows?
Am I better off having a print and a sort function?

3. Why is an output loop inside another loop that modifies what is displayed?
Typo, which fixed both the cout and swap.

4. Don't pass an object of the class to class member functions. This construction: object.function(object) is particularly unnecessary. Just object.function() is enough. You can refer to object inside the function by means of the this pointer.

I was just working on this, for this situation must I use THIS-> every time? or can I simply do:

swap(highScore[i], highScore[i + 1]);


Thank you for your help, that pretty much fixed my issue. The small problems always get me.

[helios]

It is a sort

Then it's incorrect.

Am I better off having a print and a sort function?

Yes, as long as the print function doesn't call the sort function.

You don't have to explicitly use this, but IMO it's preferable. For the most part it's just a matter of style, though.

[venros]

The swap function is a simple bubble sort which def works for me. What would be a better way to do this? mind you im a newbie.

EDIT:
I updated my code, everything works well now even the swap.