access reading and writing violation for no apparent reason.

[mahnoorhaneef]

okay so my program is about Little Alchemy. I have made the game actually. Four different classes. Earth, Water, Fire and Air. which combine to form more elements and further combine to form more elements. Now my problem is related to file handling. I am discussing here just my water class. Though the combinations are not complete but still it'll give you all an idea. I have made function for not repeating any element while storing in the file. (Using Sequential) Now if i keep on adding water and water as input, it gives me sea. Without displaying, if a keep on adding water and any other element in a row. At a specific point, it throws an exception on access reading violation. In water class, it's after five elements i guess while in other after three it crashes. However if I make random elements and also keep on displaying them after few elements, the program runs fine but even then, randomly at any point it again crashes. Like I don't know why it crashes and what the point for abnormal termination. If there is anything different, it's in the alreadyExists function.

Kindly go through the code very carefully. I hope you'll get it what i am trying to say. Like it is totally going random. Suddenly it crashes and when i keep on adding elements in a row, it crashes at any random point. What should I do!

#ifndef WATER_H
#define WATER_H
#include <iostream>
#include <fstream>
#include <vector>
#include <algorithm>
#include <string>
#include "element.h"
#include "Fire.h"
#include "Earth.h"
#include "Air.h"
using namespace std;

class Water :public Element 
{
public:
	
	Water ()
	{

	}


	Water(string n): lineCount (0), Element (n)
	{
		water = n;
		i=0;	
		
	}

	string water;
	int i;
	string Elements[4];
	int lineCount;

	void alreadyExists (string a)
	{
		
		ifstream read;
		read.open ("Water.txt", ios::in | ios::app);
		while(!read.eof())
			{
				string x;
				read>>x;
				lineCount++;

			}
			lineCount--;
			string *elements = new string[lineCount]; //length of the string array increasing with increase in line count//
			read.close();
			read.open("Water.txt", ios::in|ios::app);
			for(int i = 0; i < lineCount; i++)
			{
				read>>elements[i];
			}
			bool Found = false;
			for(int i = 0; i < lineCount; i++) {
				if(a == elements[i]) 
				{
					Found = true;
					break;
				}
			}
			if(!Found) 
			{
				write2file (a);
				//write << newE.air << endl;
			}

	}


/*void PushW (string newElement)
{
	
			
	if(i>=8)
	{
		cout<<"Cannot be added"<<endl;
	}
	else
	{
		Elements[i] == newElement;
		i++;
	}

}*/





void write2file (string water)
{
	
	ofstream write;
	
	write.open ("Water.txt", ios::out|ios::app);
	
			{
				write<<water<<endl;
				
			}			
}



 void DisplayW ()
	 {
		
		ifstream read ("Water.txt", ios::in|ios::app);
		 
		string x;
		 while (read >> x)
				 {
					 cout<<x<<endl;
				 }
				//(Link List)
				
	 }



	

	string getnameWater()
	{
		return water;
	}

	 Water operator+(const Air& air) //combining an element of water with an element of air. return water instance
	{                                    
		Water newElement ("NULL");       
		if ((this->water == "Water"||this->water=="water") && (air.air == "Air"||air.air=="air")) 

		{
			newElement.water = "Rain";
			cout<<"You've made: "<<newElement.water<<endl;
			
			alreadyExists (newElement.water);
			
				return newElement;
		}
		else return newElement;

	} //rain,

	 Water operator+(const Fire & fire) //combining an element of water with an element of fire. return water instance
	{
		Water newElement ("NULL");
		if ((this->water == "Water"||this->water=="water") && (fire.fire == "Fire"||fire.fire=="fire"))
		{
			newElement.water = "Steam";
			cout<<"You've made: "<<newElement.water<<endl;
			
			alreadyExists (newElement.water);
			
			return newElement;
		}
		else return newElement;

	}//steam, 

	Water operator+ (const Earth & earth) //combining an element of water with an element of earth. return water instance
	{
		Water newElement ("NULL");
		if ((this->water == "Water"||this->water=="water") && (earth.earth == "Earth"||earth.earth=="earth"))
		{
			newElement.water = "Mud";
			cout<<"You've made: "<<newElement.water<<endl;
			alreadyExists (newElement.water);
			
			return newElement;
		}
		else return newElement;
	}//mud


	 Water operator+ (const Water & water)
	{
		Water newElement ("NULL");
		if ((this->water == "Water"||this->water=="water") && (water.water == "Water"||water.water=="water"))
		{
			newElement.water = "Sea";
			cout<<"You've made: "<<newElement.water<<endl;
			alreadyExists (newElement.water);
			
			
			return newElement;
		}
		else return newElement;
	}//sea



};
#endif