Trouble overloading the + operator

[MsPhelix]

Hi,
I can overload the + operator as follows:

#include <iostream>
using namespace std;

class CVector
{
public:
	int x, y;
	CVector() {};
	CVector(int a, int b) : x(a), y(b) {}
	CVector operator + (const CVector&);
};

CVector CVector::operator+ (const CVector& param)
{
	CVector temp;
	temp.x = x + param.x;
	temp.y = y + param.y;
	return temp;
}

int main()
{
	CVector foo(3, 1);
	CVector bar(1, 2);
	CVector result;
	result = foo + bar;
	cout << result.x << ',' << result.y << '\n';

	cout << endl;
	cout << "Press any key to exit.";
	cin.get();
}

However, I am trying something else and having problems. I know this is weird but I have a class with two string members; in my +operator overload, I want to return a class object for which one of the strings gets its value from the first operand and the other string gets its value from the second operand.
Obj1: rider = Jane, horse = Rosie, Obj2: rider = Ian, horse = Ben
Obj3 = Obj1 + Obj2 : rider = Jane, horse = Ben

Here's my code

#include <iostream>
using namespace std;

class Team
{
	string rider;
	string horse;

public:
	Team();
	Team(string ridername, string horsename);

	void setRider(string name) { rider = name; }
	void setHorse(string name) { horse = name; }

	string getRider() { return rider; }
	string getHorse() { return horse; }
	
	Team operator + (const Team&);
};

Team Team::operator+ (const Team& team2)
{
	Team temp{};
	temp.setRider(team2.getRider());
	temp.setHorse(horse);

	return temp;
}

Team::Team(string ridername, string horsename)
{
	rider = ridername;
	horse = horsename;
}

int main() 
{
	Team USA("Felicity", "Rosie");
	Team Canada("Ian", "Big Ben");
	Team Combined = USA + Canada;

	cout << endl;
	cout << "Press any key to exit.";
	cin.get();
}

I get 2 errors I don't know what to do about:
Error 1 error C2662: 'std::string Team::getRider(void)' : cannot convert 'this' pointer from 'const Team' to 'Team &' c:\users\felicity\dropbox\c++\tutorial\024advanced_class\advanced_class.cpp Line 25 1 024Advanced_class

Error 2 IntelliSense: the object has type qualifiers that are not compatible with the member function object type is: const Team c:\Users\Felicity\Dropbox\C++\Tutorial\024Advanced_class\Advanced_class.cpp Line 25 16 024Advanced_class


Any help would be appreciated :)

[Hippogriff]

You can not call non-const functions from a const object (As the compiler doesn't know if that function will try and change the data on that object or not).
Team Team::operator+ (const Team& team2)

The easier way to fix this and keep const correctness is just to make your getRider() function constant.
string getRider() const { return rider; }

There are also minor things like you don't define your default constructor anywhere.

[MsPhelix]

Thank you for responding.

Putting const in

string getRider() const { return rider; }

caused other issues.

I thought

Team();

was a default constructor. After your help I changed the code to the following:

#include <iostream>
#include <string>
using namespace std;

class Team
{
	string rider;
	string horse;

public:
	Team(){};
	Team(string ridername, string horsename);

	void setRider(string name) { rider = name; }
	void setHorse(string name) { horse = name; };

	string getRider() { return rider; }
	string getHorse() { return horse; }
	
	Team operator + (const Team&);
};

Team Team::operator+ (const Team& team2)
{
	Team temp;
	temp.rider = team2.rider;
	temp.setHorse(horse);

	return temp;
}

Team::Team(string ridername, string horsename)
{
	rider = ridername;
	horse = horsename;
}

int main() 
{
	Team USA("Felicity", "Rosie");
	Team Canada("Ian", "Big Ben");
	Team Combined = USA + Canada;

	cout << "Team Combined is " << Combined.getRider() << " on " << Combined.getHorse() << endl;

	cout << endl;
	cout << "Press any key to exit.";
	cin.get();
}

and it now works!!! HURRAY!!
Check lines 11 and 25 compared to lines 10 and 24 in the original code (I added a #include <string> so I could use cout to display a string; that's why the lines are 1 down in the new code.)

Thank you for the help :)