Help Needed

[lonewolf1]

when i compile the following program it gives an error ISO forbid comparison between pointer and integer can anyone tell me what is the problem ??

#include<iostream>
#include<string>
#include<sstream>
using namespace std;
class car
{
      private:
      char make[20];
      char model[20];
      char color[20];
      int capacity;
      int xpos;
      int ypos;
      
      public:
      car()
      {
      strcpy(make,"Toyota");
      strcpy(model,"Corolla");
      strcpy(color,"White");
      capacity = 1300;
      xpos = 2;
      ypos = 3;
      }
      car(int xp, int yp, char*ma, char*mo, char*co, int ca)
      {
      xpos = xp;
      ypos = yp;
      strcpy(make,ma);
      strcpy(model,mo);
      strcpy(color,co);
      capacity = ca;
      }
      void setmake(char* n)
      {
           strcpy(make,n);
      }
      char* getmake(void)
      {
            return make;
      }
      void setmodel(char* m)
      {
           strcpy(model,m);
      }
      char* getmodel(void)
      {
            return model;
      }
            void setcolor(char* b)
      {
           strcpy(color,b);
      }
      char* getcolor(void)
      {
            return color;
      }
            void setcap(int c)
      {
           capacity = c;
      }
      int getcap(void)
      {
            return capacity;
      }
      void mov_fwd(void)
      {   
      xpos++;
      }
      void mov_back(void)
      {
      xpos--;
      //x--;
      }
      void mov_right(void)
      {
      ypos++;
      //y++;
      }
      void mov_left(void)
      {
      ypos--;
      //y--;
      } 
     int get_pos(void)
      {
      return xpos;
      }
      int get_pos1(void)
      {
      return ypos;
      }
};
int main()
{
    car c1(2,3,"Toyota","Corolla","White",1300);
    char g;
    cout<<"Data Of Car: "<<endl<<endl;
    cout<<"Make: "<<c1.getmake()<<endl<<"Model: "<<c1.getmodel()<<endl;
    cout<<"Color: "<<c1.getcolor()<<endl<<"Capacity(cc): "<<c1.getcap()<<endl;
    cout<<"\nTest Drive: "<<endl<<endl;
    while(g!="q")
    {
     cout<<"Waiting for command: ";
     cin>>g;    
     if(g=="f")
     {
     c1.mov_fwd();
     }
     else if(g=="b")
     {
     c1.mov_back();
     }
     else if(g=="r")
     {
     c1.mov_right();
     }
     else if(g=="l")
     {
     c1.mov_left();
     }
     else
     {
     cout<<"Invalid Command"<<endl;
     }
     } 
     cout<<"X= "<<c1.get_pos()<<endl<<"Y= "<<c1.get_pos1()<<endl;
     system("PAUSE");
}

[CodeGoggles]

Please use the code format for displaying code. It's the <> button on the right of the text box.

// Your code is hard to understand when laid out like that.

// The error seems to indicate you are comparing a integer
// to a memory address contained in a pointer. 
// You may need to dereference the pointer before 
// making the comparison. But that is just a guess 
// as I am not looking at code like that.

[Ispil]

Well, this is actually rather simple. You declare 'g' as a character in main(); you then compare it to strings (look at lines such as while(g!="q")). The fix is simple- replace those quotes around each string (q, f, b, r, and l) with single-quotes. For example. while(g!='q') is valid code.

[lonewolf1]

thanks it worked :)