Student Directory Search/ Ifstream C++

[barnold]

I am trying to read the prog8in.txt file so I can search through roster using an ID # or a Last Name but I cannot get the program to read my .txt file correctly

 #include <cstdio>
#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
using namespace std;
ifstream inStream;
struct student{
        int id;
        char fname[20];
        char lname[20];
        char email[40];
        double gpa;
};
struct roster{
    struct student;
};

// list all function prototypes here
int displayMenu(int recNum);
bool getRecord(int& recNum, int& id, char fname[20], char lname[20], char email[40], double& gpa);
void displayStudents();

int main(){
    int recNum = 0, x = 0, id;
    char fname, lname, email;
    double gpa;
    getRecord(recNum, id, &fname, &lname, &email, gpa);
    while (x == 0){
    displayMenu(recNum);
        cout << ">> ";
    int choice = 0;
    cin >> choice;
    if (choice == 1) {
            
    } else if (choice == 2) {
        
    }else if (choice == 3){
        
    }else if (choice == 4){
        break;
    }
}
    system("PAUSE");
    return 0;
}

// List all function definitions here
int displayMenu(int recNum){
    cout << "********** Class Roster ******* Total Students = ";
    cin >> recNum;
    cout << "1. Display all student" << endl;
    cout<<  "2. Search a student by ID" << endl;
    cout << "3. Search a student by Last Name" << endl;
    cout << "4. Exit" << endl;
    return recNum;
}
void displayStudents(){
    
}

bool getRecord(int& recNum, int& id, char fname[20], char lname[20], char email[40], double& gpa){
    if (recNum==0) {
        inStream.open("prog8in.txt");
        if (inStream.fail()){
            cout<<"File \"prog8in.txt\" cannot be opened."<<endl;
            system("pause");
            exit(1);
        } else cout<<"File \"prog8in.txt\" opened."<<endl;
    }
    inStream >>id >>fname >>lname >>email >>gpa;
    if (inStream.eof()) return false;
    else {
        recNum++;
        return true;
    }      
}

My Output:

File "prog8.txt" opened.
Press any key to continue...

My .txt file

9990001 Stephen Smith  [e-mail] 2.33
9990002 Jane Doe [e-mail] 3.00
1110003 Barbara Fisher [e-mail] 3.50
2220004 Olin Johnson [e-mail] 2.99
9990003 Albert Jones [e-mail] 3.67
9990004 Lennard Johnson [e-mail] 3.00

[Cody0023]

Your character arrays are too small. By the time Albert Jones is reached your name arrays are already full.

[barnold]

I increased the size of my character arrays but got the same output. Any other suggestions?

[Cody0023]

You don't have a while loop. You will only read the first line of the file.

while(inStream)
inStream>>id>>fname<<lname<<email<<gpa;

For more clarity, what exactly are you trying to do?

[barnold]

I am trying to read the file so I can display the .txt file like so
Record
Student ID: 9990001
Student Name: Stephen Smith
Student Email: [e-mail]
Student GPA: 2.33

and be able to read the file so I can be able to search for the students individually.

[Cody0023]

while(inStream)
{
inStream>>id>>fname<<lname<<email<<gpa;
cout<<"Student ID: "<<ID<<endl;
cout<<"Student Name: "<<fname<<" "<<lname<<endl;
cout<<"Student Email: "<<email<<endl;
cout<<"Student GPA: "<<gpa<endl;
}

try this.

EDIT: I was wrong earlier about the character array being too small.

[barnold]

Thank You! That's just what I needed, I think I'll be able to finish it from this point