Program Outputting Incorrect Values

[ATAndTruong]

Hello all,

I'm trying to get through an assignment for class and I'm a little lost on the two parts. The homework assignment is asking us to determine pay increase for employee's based on ID number. The user inputs the employee's ID, name, and current salary. If the user's ID is even, their salary receives a 5% increase, and if it is odd, their salary receives a 3% increase.

The program then outputs the employee's ID, name, current salary, monetary value of salary increase, and their updated salary, then the program asks to repeat, and stores the data in the process, until the user inputs the employee ID as negative, or if the user command to repeat as anything but 'y'. In that case, the program outputs the total number of employees getting 3% increases, the monetary sum of all 3% increases, the total number of employees getting 5% increases, and the monetary sum of all 5% increases.

I ran into a roadblock. I got the function calls down, but when I run the code, nothing is displayed for the salary increase or their new total salary. As you can see from my code, I tried returning the salary increase and the new total, to no avail. Am I going about it the wrong way?

My default function calls (for user input as well as the line of code that describes what the program does):

// Compiler directives
#include <iostream>		
#include <string>
#include <iomanip>
using namespace std;

// Function prototypes
void instruct(string);
long inputdata_integer(int, int, string);	
float inputdata_float(float, float, string);
char inputdata_char(string);
string inputdata_string(string);

void instruct(string whatitdoes)
{

	// Post:	Instructions on how to use the program will be displayed 
	cout << "This program: " << whatitdoes << endl << endl;
} // end instruct

long inputdata_integer(int minim, int maxim, string messg)
{
long goback = minim - 1;

		while ( goback < minim || goback > maxim)   //  While loop to check input validity
		 {
		//2.0	Get input from the user
			cout << endl << messg << ": ";
			cin>> goback;
	
		//2.2	Is input between minim and maxim
			if ( goback < minim )
				cout << "input less than " << minim << endl;
			if ( goback > maxim )
				cout << "input greater than " << maxim << endl;

		}
	return goback;
}

float inputdata_float(float minim, float maxim, string messg)
{
float goback = minim - 1.;

		while ( goback < minim || goback > maxim)   //  While loop to check input validity
		 {
		//2.0	Get input from the user
			cout << endl << messg << ": ";
			cin>> goback;
	
		//2.2	Is input between minim and maxim
			if ( goback < minim )
				cout << "input less than " << minim << endl;
			if ( goback > maxim )
				cout << "input greater than " << maxim << endl;

		}
	return goback;
}
char inputdata_char(string messg)
{
char getchar;
			cout << endl << messg << ": ";
			cin>> getchar;

	return getchar;
}
string inputdata_string(string messg)
{
string getstring;
			cout << endl << messg << ": ";
			cin>> getstring;

	return getstring;
}

The main program (consists only of function calls per the assignment requirement):

// Compiler directives
#include <iostream>				
#include <iomanip>
#include <string>
using namespace std;

// Function prototypes
void instruct(string);				
long inputdata_integer(int, int, string);	// Function to get input
float inputdata_float(float, float, string);
char inputdata_char(string);
string inputdata_string(string);
float percent_increase(float, int, float, float);
void display_individual(int, string, float, float, float);

int main()	
{
// Declaration statements
char repeat = 'y';				// Input - to repeat
int number;					// Input - employee ID number
string name;
float current;
float percentage;
float increase;
float total;
//Program Inputs

	
	// 1.0	Display instructions to the program user
	instruct("Calculates employee salary increase based on user input.");

    while ( repeat == 'y' )        // While loop to repeat entire input
    {
		//2.0	Get input from the user
		//2.1	Prompt user to enter ID number
		number = inputdata_integer(1, 1000000, "Please enter the employee's ID number");

		//	2.2	Prompt user to enter employee name
		name = inputdata_string("Please enter the employee's full name");
		
		//	2.3	Prompt user to enter current salary
		current = inputdata_float(10000, 1000000, "Please enter the employee's current salary");	

		//3.0	Calculate answers
		percentage = percent_increase(current, number, increase, total);
		
		//4.0	Display results to the user
		display_individual(number, name, current, increase, total);
		
		
		cout << endl << "Type y to repeat: ";
		cin >> repeat;
	}

	return 0;				// indicate that the program ended successfully

}   // end of main 

Function calls specifically made for this program (and the main area of my struggle):

// Compiler directives
#include <iostream>		// for cin, cout, endl
#include <string>
#include <iomanip>
using namespace std;

float percent_increase(float salary, int id, float added, float updated)
{
	float current = salary;
	int number = id;
	float increase = added;
	float total = updated;
	
	
	if (id % 2 == 0) {// if employee ID is even
    updated = salary * 1.05; // 5% increase
    added = salary * .05; }
	else
    updated = salary * 1.03;
	added = salary * .03;	
	
	return updated;
	return added;
}

void display_individual(int id, string employee, float salary, float added, float updated)
{
		
	cout << "Employee identification number: " << id << endl;
	cout << "Employee Name: " << employee << endl;
	cout << "Current Salary = $" << salary << endl;
	cout << "Salary Increase = $" << added << endl;
	cout << "New Salary = $" << updated << endl;
}

[long double main]

number % 2 returns the remainder that you get when you divide number by 2.
If number is even, then there will be no remainder and so number % 2 == 0.
If number is odd, then there will be a remainder of 1 so number % 2 == 1.

So it would probably be something like (warning: these variable names are not necessarily from your code; adjust them accordingly)

if (employeeID % 2 == 0) // if employee ID is even
    salary *= 1.05; // 5% increase
else
    salary *= 1.03;

[ATAndTruong]

long, thanks for replying.

I ran into a roadblock. I got the function calls down, but when I run the code, nothing is displayed for the salary increase or their new total salary. As you can see from my code, I tried returning the salary increase and the new total, to no avail. Am I going about it the wrong way?

Also, I'm stuck at the part where the user inputs the employee ID as negative, or if the user command to repeat as anything but 'y'. In that case, the program outputs the total number of employees getting 3% increases, the monetary sum of all 3% increases, the total number of employees getting 5% increases, and the monetary sum of all 5% increases.


My default function calls (for user input as well as the line of code that describes what the program does)

// Compiler directives
#include <iostream>		
#include <string>
#include <iomanip>
using namespace std;

// Function prototypes
void instruct(string);
long inputdata_integer(int, int, string);	
float inputdata_float(float, float, string);
char inputdata_char(string);
string inputdata_string(string);

void instruct(string whatitdoes)
{

	// Post:	Instructions on how to use the program will be displayed 
	cout << "This program: " << whatitdoes << endl << endl;
} // end instruct

long inputdata_integer(int minim, int maxim, string messg)
{
long goback = minim - 1;

		while ( goback < minim || goback > maxim)   //  While loop to check input validity
		 {
		//2.0	Get input from the user
			cout << endl << messg << ": ";
			cin>> goback;
	
		//2.2	Is input between minim and maxim
			if ( goback < minim )
				cout << "input less than " << minim << endl;
			if ( goback > maxim )
				cout << "input greater than " << maxim << endl;

		}
	return goback;
}

float inputdata_float(float minim, float maxim, string messg)
{
float goback = minim - 1.;

		while ( goback < minim || goback > maxim)   //  While loop to check input validity
		 {
		//2.0	Get input from the user
			cout << endl << messg << ": ";
			cin>> goback;
	
		//2.2	Is input between minim and maxim
			if ( goback < minim )
				cout << "input less than " << minim << endl;
			if ( goback > maxim )
				cout << "input greater than " << maxim << endl;

		}
	return goback;
}
char inputdata_char(string messg)
{
char getchar;
			cout << endl << messg << ": ";
			cin>> getchar;

	return getchar;
}
string inputdata_string(string messg)
{
string getstring;
			cout << endl << messg << ": ";
			cin>> getstring;

	return getstring;
}

The main program (consists only of function calls per the assignment requirement).

// Compiler directives
#include <iostream>				
#include <iomanip>
#include <string>
using namespace std;

// Function prototypes
void instruct(string);				
long inputdata_integer(int, int, string);	// Function to get input
float inputdata_float(float, float, string);
char inputdata_char(string);
string inputdata_string(string);
float percent_increase(float, int, float, float);
void display_individual(int, string, float, float, float);

int main()	
{
// Declaration statements
char repeat = 'y';				// Input - to repeat
int number;					// Input - employee ID number
string name;
float current;
float percentage;
float increase;
float total;
//Program Inputs

	
	// 1.0	Display instructions to the program user
	instruct("Calculates employee salary increase based on user input.");

    while ( repeat == 'y' )        // While loop to repeat entire input
    {
		//2.0	Get input from the user
		//2.1	Prompt user to enter ID number
		number = inputdata_integer(1, 1000000, "Please enter the employee's ID number");

		//	2.2	Prompt user to enter employee name
		name = inputdata_string("Please enter the employee's full name");
		
		//	2.3	Prompt user to enter current salary
		current = inputdata_float(10000, 1000000, "Please enter the employee's current salary");	

		//3.0	Calculate answers
		percentage = percent_increase(current, number, increase, total);
		
		//4.0	Display results to the user
		display_individual(number, name, current, increase, total);
		
		
		cout << endl << "Type y to repeat: ";
		cin >> repeat;
	}

	return 0;				// indicate that the program ended successfully

}   // end of main 

Function calls specifically made for this program (and the main area of my struggle).

// Compiler directives
#include <iostream>		// for cin, cout, endl
#include <string>
#include <iomanip>
using namespace std;

float percent_increase(float salary, int id, float added, float updated)
{
	float current = salary;
	int number = id;
	float increase = added;
	float total = updated;
	
	
	if (id % 2 == 0) {// if employee ID is even
    updated = salary * 1.05; // 5% increase
    added = salary * .05; }
	else
    updated = salary * 1.03;
	added = salary * .03;	
	
	return updated;
	return added;
}

void display_individual(int id, string employee, float salary, float added, float updated)
{
		
	cout << "Employee identification number: " << id << endl;
	cout << "Employee Name: " << employee << endl;
	cout << "Current Salary = $" << salary << endl;
	cout << "Salary Increase = $" << added << endl;
	cout << "New Salary = $" << updated << endl;
}