How to use arrays from user input in seperate functions

[liquifiednate]

This is really hard to describe but for computer science we have to create an array that asks for ten numbers, which I got working great, then it has to print out the order in reverse if the user is asked. After that it has to print out the even order of the array and then the odd. I have all this working perfectly fine in int main() but then I read on in the assignment and I have to put every section the teacher is asking for in a separate function. I don't really get functions well enough yet and can't tell how to pass one array that I have in its own function that also gets all the user input into several other functions.

#include<iostream>
#include<string>


using namespace std;

float fill_numbers()
{
	float number[10];
	for(int count = 1; count <= 10; ++count)
	{
		cout << "Enter the " << count << " number: ";
		cin >> number[count];
	}

	//return number[10];
}

float print_reverse(float number[10])
{
	
			for(int count = 10-1; count >= 0; --count)
			{
				cout << "The reverse order of what you entered is: " << number[count] << endl;
			}
}

float print_odd_indices()
{
	for (int count1 = 1; count1 <= 10; count1 = count1+2)
	{
		cout << "Odd Indice " << count1 << ": " << number[count1] << endl;
	}

}

float print_even_indices()
{
		for (int count2 = 1; count2 <= 10; ++count2)
		{
			if (count2 % 2 == 0)
			{
				cout << "Even Indice " << count2 << ": " << number[count2] << endl;
			}
			
		}	
}

float print_average()
{
		float sum;
		float average;

			for (int count3 = 1; count3 <= 10; ++count3)
		{
			sum = sum + number[count3];

			average = sum / 10;
		}

		cout << "The average is: " << average << endl;
}

int main()
{
	string input;



	
	fill_numbers();
	

	cout << "Do you want to print the numbers in reverse order, odd indices, even indices, average of the ten numbers, or exit this program?: ";
	cin.ignore();
	getline (cin, input);
	
	if (input == "Reverse Order")
	{
		print_reverse(fill_numbers);	
	}

	if (input == "Odd Indices")
	{
		print_odd_indices();
	}

	if (input == "Even Indices")
	{
		print_even_indices();
	}

	if (input == "Average")
	{
		print_average();
	}

	if (input == "Exit")
	{
		return 0;
	}



}

[liquifiednate]

I know my code is a mess at the moment but it's because originally none of these functions existed I had everything in int main() working perfectly fine; but once I read my CSCI teacher wanted us to put them all in their own functions I tried to do it in the last hour or so and can't figure out what to do now. I can't figure out how to carry over my number[] array.

[xismn]

First of all, you can pass an array to a function, like so:

void function(int array[], const unsigned short size) {
	/**/
}

int main() {
	const unsigned short size = 10;
	int array[size];

	function(array, size);

	return 0;
}

The way you have it, your fill_numbers() function creates a temporary array of ten integers. The array ceases to exist after the function is done, so anything you've done to the array was pointless, and you're unable to use the same array elsewhere in your code.

It would make more sense if your fill_numbers() function took an array parameter, as well as a size parameter (number of elements).

Also, keep in mind that array indecies begin at zero, so that makes some of your for loops dangerous, since they're accessing memory that's not part of the array.

To iterate through an array of ten elements, something like this would be safe:

for(int i=0; i<9; ++i) {
	/**/
}

Finally, accepting input where uppercase and non-alphabetic characters are important is scary. "Odd Indecies" is not the same as "Odd indecies", which is also not the same as "odd Indecies" or "odd indecies".

[liquifiednate]

Thank you so much! Helped a lot!