Changing upper to lower case and vice versa for a string?

[gotsleep]

ex: "My Name Is John" should be "mY nAME iS jOHN"

i have a really long code that has other stuff but i'll put it anyway

  #include <iostream>
#include <cctype>
#include <string>
using namespace std;

int main ()
{
	string xstring; 
	char choice;
	char Q, q;
	


	cout << "Enter a string: ";
	getline(cin, xstring);
	
	do
	{
		cout << "USE THIS MENU TO MANIPULATE YOUR STRING\n";
		cout << "----------------------------------------\n";
		cout << "1) Inverse the string\n";
		cout <<	"2) Reverse the string\n";
		cout <<	"3) To Uppercase\n";
		cout <<	"4) Jumble String\n";
		cout <<	"5) Count Number of Words\n";
		cout <<	"6) Count Constants\n";
		cout <<	"7) Enter a Different String\n";
		cout <<	"8) Print The String\n";
		cout <<	"Q) Quit\n";
		cout << "Enter your choice: ";

		cin >> choice;
		cout << endl;

		if (choice == '1')
		{

			
		}

		else if (choice == '2')
		{
			xstring = string( xstring.rbegin(), xstring.rend() );
			//cout << xstring;
		}

		else if (choice == '3')
		{
			for(int i = 0; i < xstring.length(); i++)
			{
				xstring[i] = toupper(xstring[i]);
				//cout << xstring[i];
				
				
			}

		}

		else if (choice == '4')
		{
		}

		else if (choice == '5')
		{
		}

		else if (choice == '6')
		{
		}

		else if (choice == '7')
		{
		}

		else if (choice = '8')
		{
		}

		//else
			//cout << "Error! Please type in a valid choice\n";
		

	}
	
	while (choice != 'Q' && choice != 'q');
	{
		
	}
	
	




	system("PAUSE");
	return 0;

}

[giblit]

You can use the islower/upper and tolower/upper functions if you want.
http://www.cplusplus.com/reference/cctype/

Or you could iterate through the string and check manually with something like:

if(str[i] >= 'a' && str[i] <= 'z') //lowercase found
{
    str[i] -= ' '; //'a' == 97, 'A' == 65, ' ' == 32, if you prefer you can subtract 32
}
else if(str[i] >= 'A' && str[i] <= 'Z') //uppercase
{
    str[i] += ' '; //as mentioned earlier
}

Looking at your code earlier it looks like you can use the to/is(upper/lower) functions so use those instead of what I mentioned.

To get your code working you should check if the character is tolower(or upper) then either make it upper or lower depending so instead of: xstring[i] = toupper(xstring[i]); try something like:

if(islower(xstring[i]))
{
    xstring[i] = toupper(xstring[i]);
}
else
{
    xstring[i] = tolower(xstring[i]);
}

[edit]
You seem to know what iterators are based on your reverse function why not iterate over the string instead of using a 0->n loop?

for(const auto &it : str) //you can use char instead of auto I suppose
{
    // 'it' is the character
}

for(auto it = str.begin(); it != str.end(); ++it)
{
    // '*it" is the character
}

[/code]

[cire]

giblit wrote:

if(str[i] >= 'a' && str[i] <= 'z') //lowercase found
{
    str[i] -= ' '; //'a' == 97, 'A' == 65, ' ' == 32, if you prefer you can subtract 32
}
else if(str[i] >= 'A' && str[i] <= 'Z') //uppercase
{
    str[i] += ' '; //as mentioned earlier
}

That is a bit obfuscated. The space character has nothing to do with the conversion from or to different cases, logically speaking. It just happens to have the same value in ascii as the distance from 'a' to 'A'.

if(str[i] >= 'a' && str[i] <= 'z') //lowercase found
    str[i] = str[i] - 'a' + 'A';
else if(str[i] >= 'A' && str[i] <= 'Z') //uppercase
    str[i]  = str[i] - 'A' + 'a';

[gotsleep]

i don't know what iterators are at all. I got that from the internet....

[giblit]

I wouldn't suggest using it if you copy/pasted it..

[gotsleep]

Thank you very much giblit, I really appreciate your help so much