Cin dot getline problem

I'm struggling to get the last function to work correctly. Everytime I engage in option 2 I get a double output of

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
#include<iostream>
#include<fstream>
#include<string>

using namespace std;
const int BK_MK_LEN = 50;
const int CAT_LEN = 30;
const int NUM_URLS = 50;

int read_bookmarks(char[][BK_MK_LEN], char[][CAT_LEN]);
void sort_bookmarks(int, char[][BK_MK_LEN], char [][CAT_LEN]);
int menu();
void display_bookmark(int, char [][BK_MK_LEN], char [][CAT_LEN]);
int add_bookmark(int, char [][BK_MK_LEN], char [][CAT_LEN], int);
int search(int, char[], char[][BK_MK_LEN]);
void quit(int,  char [][BK_MK_LEN], char [][CAT_LEN]);
int delete_bookmark(int, char[][BK_MK_LEN], char[][CAT_LEN]);


void main()
{
	int count, choice;

	char bookmark[NUM_URLS][CAT_LEN];
	char URL[NUM_URLS][BK_MK_LEN];
		
	count = read_bookmarks(URL, bookmark);
	sort_bookmarks(count, URL, bookmark);
	choice = menu();
	display_bookmark(count, URL, bookmark);
    
	add_bookmark(count, URL, bookmark, choice);
	/*quit(count, URL, bookmark);
	delete_bookmark(count, URL, bookmark);
	
	cout<<"Please enter the URL you would like to search for: ";
	cin.getline(search,25);
	
	search(count,URL,BK_MK_LEN);*/
	
	system("pause");

}


int read_bookmarks(char URL[][BK_MK_LEN], char bookmark[][CAT_LEN])
{  
	int count = 0;

	ifstream in;
	in.open("bookmark.txt");

	if(in.is_open())
	{
		in >> bookmark[count];
		in >> URL[count];
		
		while(!in.eof())
		{
			count++;
			in >> bookmark[count];
			in >> URL[count];
			
				}

	cout<<"The number of URLs read is "<<count<<endl<<endl;
	}

	else 
		cout<<"Unable to open file";

	in.close();
	return count;
}

void sort_bookmarks(int count, char URL[][BK_MK_LEN], char bookmark[][CAT_LEN])
{ 
	char temp1[CAT_LEN];
	char temp2[BK_MK_LEN];

	for (int i = 1; i < count; i++)
	{
		for (int j = 0; j<count-1; j++)
		{
        
			if (strcmp(bookmark[j],bookmark[j+1])>0)
			{
				strcpy(temp1, bookmark[j]);
				strcpy(bookmark[j], bookmark[j+1]);
				strcpy(bookmark[j+1], temp1);
            
				strcpy(temp2, URL[j]);
				strcpy(URL[j], URL[j+1]);
				strcpy(URL[j+1], temp2);
		
			}
	
		}
	}

	ofstream out;
	out.open("bookmark.txt");

	if(out.is_open())
	{	
		for(int i = 0; i < count; i++)
		{
			out<<bookmark[i]<<" "<<URL[i]<<endl;
		}
	}
	
	else 
	{ 
		cout<<"Unable to open file";
	}

	out.close();
	
}


int menu()
{		
		int choice = 0; 

		cout<<"Please choose whether you would like to amend your bookmarks."<<endl;
		cout<<"To delete a bookmark, please enter 1. To add a bookmark, please enter 2. To quit, please enter 3: ";
		cin>>choice;
		
		cout<<endl;

		if(choice == 1 || choice == 2 || choice == 3)
		{
			cout<<"You entered a valid choice."<<endl<<endl;

		}
		else
		{	while(choice != 1 && choice != 2 && choice !=3)
			{
				cout<<"You entered an invalid number. Please enter 1 to delete a bookmark, 2 to add a bookmark or 3 to quit."<<endl;
				cin>>choice;
			}

			cout<<"You entered a valid choice."<<endl<<endl;
			
		}
		
		return choice;
}


void display_bookmark(int count, char URL[][BK_MK_LEN], char bookmark[][CAT_LEN])
{
	
	cout<<"Your original list of bookmarks is: "<<endl<<endl;

	for(int j=0; j<count; j++)
	cout<<bookmark[j]<<" "<<URL[j]<<endl;

	cout<<endl;
}


int add_bookmark(int count,  char URL[][BK_MK_LEN], char bookmark[][CAT_LEN], int choice)
{ 	
	int i = 0;
	char newBookmark[40][80];
	bool answer = 1;

			
	

			if(choice == 2)
		
				{
						
						cout<<"You chose to add a bookmark. Please enter the bookmark and URL, separated by a space: "<<endl;
						cin.getline(newBookmark[i],80);
						cout<<endl;
						cout<<newBookmark[i]<<endl;
					
					
						ofstream out;
						out.open("bookmark.txt");

						if(out.is_open())
							{	
								out<<newBookmark[i]<<endl;
							
							}
		
						else 
							{ 
								cout<<"Unable to open file"<<endl;
							}

						out.close();
		
						sort_bookmarks(count, URL, bookmark);

						count++;
						i++;

						
						cout<<"Would you like to add another bookmark? Please answer 1 for yes or 0 for no: "<<endl;
						cin>>answer;
				}
			
				while((answer == 1) && i<40)
					{	
						
						if(choice==2)

						{	cout<<"You chose to add a bookmark. Please enter the bookmark and URL, separated by a space: "<<endl;
							cin.getline(newBookmark[i],80);
							cout<<newBookmark[i]<<endl;
					
					
							ofstream out;
							out.open("bookmark.txt");

							if(out.is_open())
							{	
								out<<newBookmark[i]<<endl;
							
							}
		
							else 
							{ 
								cout<<"Unable to open file"<<endl;
							}

							out.close();
		
							sort_bookmarks(count, URL, bookmark);
		
							i++;
							count++;

								
							cout<<"Would you like to add another bookmark? Please answer 1 for yes or 0 for no: "<<endl;
							cin>>answer;
						}
			
				}

	

		
		return count;

}
	


the I get this out put.
The number of URLs read is 1

Please choose whether you would like to amend your bookmarks.
To delete a bookmark, please enter 1. To add a bookmark, please enter 2. To quit
, please enter 3: 2

You entered a valid choice.

Your original list of bookmarks is:

╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠ ╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠
╠

You chose to add a bookmark. Please enter the bookmark and URL, separated by a s
pace:


Would you like to add another bookmark? Please answer 1 for yes or 0 for no:


You ar mixing getline and stream extraction.
http://stackoverflow.com/questions/9336209/mixing-ifstream-getline-and
Can you clarify?
You enter "2" and press enter.
Input stream contains: "2\n"
you do std::cin >> choice, it reads all digits until first whitespace symbol, so it leaves "\n" in input stream.
Then you do getline which reads characters until it finds newline symbol (\n). Guess what symbol it reads first?
I see I have to use cin.ignore(); and cin.clear(); Thank you!
Topic archived. No new replies allowed.