basic If control

[bradles]

ok so have just started to learn C++ and im wanting to check all arguments to call out errors when it finds a character. Ive been able to get it to work but having to manually tell it which argv to check, is there a loop or check all argv??

thanks in advance.
Brad

#include "stdafx.h"
#include <iostream>
using namespace std;


int main(int argc, char *argv[])
{

	if (isalpha(*argv[1]))

		cerr << "error" << endl;

		
	if (isalpha(*argv[2]))

		cerr << "error" << endl;

		
		return 0;
	}

[cire]

#include <iostream>
#include <cctype>


int main(int argc, char *argv[])
{
    for (int i=1; i<argc; ++i)
    {
       if (std::isalpha(*argv[i]))
       {
           std::cerr << "ERROR: argument is \"" << argv[i] << "\"\n";
           return 0 ;
       }
    }
}

[MiiNiPaa]

for(int i = 1; i < argc; ++i) {
    if (isalpha(*argv[i]))
        std::cerr << "error" << std::endl;
}

[Stormboy]

@ cire: Did you notice that you have put using namespace std;? Yet you are doing std::cerr.

[cire]

Did you notice that you have put using namespace std;? Yet you are doing std::cerr.

Sure. Let me fix that for you.

[MiiNiPaa]

http://stackoverflow.com/questions/1452721/why-is-using-namespace-std-considered-bad-practice

[Stormboy]

I know it is a bad practice. I meant to either remove the using statement or the std:: from cerr.

[cire]

I know it is a bad practice. I meant to either remove the using statement or the std:: from cerr.

Why? It is permissible to bring something into the global namespace and still use it's fully qualified name, and in this case it was simply an artifact of pasting the original code and then modifying it. Hardly worthwhile to point out.

[bradles]

thanks guys

[Stormboy]

@ cire: Because it kinda looked weird lol.