I am struggling with a while loop please help

[adamcampbell]

Write your question here.
I am making a program that that determines if someone has exceeded their credit limit. I have made a loop but when i execute i am in an infinite loop. Im looking in my book and can't find anything that looks similar to what i'm doing please help.

#include <iostream>
using namespace std;
int main()
{

//variables
double beginningbal, totalchargesthismonth,
totalcreditsthismonth, creditlimit, newbalance, accountnumber;
string  name;

//user enters information

cout <<"Enter your name: " << endl;
cin >> name;

cout <<"Enter account number: " << endl;
cin >> accountnumber;

cout <<"Enter beginning balance: " << endl;
cin >> beginningbal;

cout <<"Enter total charges this month: " <<  endl;
cin >> totalchargesthismonth;

cout <<"Enter total credits this month: " <<  endl;
cin >> totalcreditsthismonth;

cout <<"Enter your credit limit: " <<  endl;
cin >> creditlimit;

newbalance = (beginningbal - totalchargesthismonth +
totalcreditsthismonth);

    while (newbalance > creditlimit
{
    cout <<"Credit limit Exceeded" <<  endl;

}

   while (newbalance <= creditlimit)
{
cout <<"There is an available balance " << endl;
}

return 0;
}

[fafner]

Welcome to the forums! Please remember to use code-tags when posting:) You aren't changing the variables (newBalance and creditLimit) inside your loops, so of course they will never exit. Make sure you understand how while-loops work, from reading this code I'm guessing that you actually want to use if-statements rather than while-loops.

[adamcampbell]

what is a code tag

[fafner]

Surround your code with "[ code ]" and "[ /code ]" (without the quotes or spaces). It will make your code look like this:

int a = 42;

[adamcampbell]

thanks for that tip! Now im trying to think of what to change my variables to so that they won't loop but if i did something like newbalnce++ wouldnt it loop and display "Credit limit exeeded" like 1000 times?

[fafner]

Hmm, the program is supposed to ask the user for info, and then tell him/her ONCE whether or not they have an available balance, right? If so it makes sense to just use an if-else-statement:

if (newbalance > creditlimit) {
	cout <<"Credit limit Exceeded" <<  endl;
} else {
	cout <<"There is an available balance " << endl;
}

[adamcampbell]

That makes alot of since and I thought the same thing but the instructions says that i need to use a while loop sigh...

[fafner]

Hmm, I don't see the point of using a while-loop for this :P Are you sure that's exactly what the program is supposed to do?

[adamcampbell]

these are the instructions

The program should use a while loop to read the input, calculate the new balances, determine
whether the new balance exceeds the credit limit, display a message “Credit Limit Exceeded” in
case the limit is exceed or “There is an available balance” otherwise.

[fafner]

Ah, ok. Then you need to read the input and calculate the new balance inside the second while-loop (get rid of the first one).

[adamcampbell]

where i initialized new balance needs to be in the second while loop instead?
Also i need to remove the first while loop?

[fafner]

First you declare all the variables, like you've already done. Then get all the input from the user which will only be entered once. Then you enter a while-loop which checks if newBalance is less than creditLimit (like your second while-loop). In that loop you get input from the user about new credits and charges and calculate the new balance. After the loop you print the message saying that the credit limit has been exceeded :)

[adamcampbell]

Im missing something you told me to do. i dont know how to go abut this part "In that loop you get input from the user about new credits and charges and calculate the new balance."

#include <iostream>
using namespace std;
int main()
{

//variables
double beginningbal, totalchargesthismonth,
totalcreditsthismonth, creditlimit, newbalance, accountnumber;
string  name;

//user enters information

cout <<"Enter your name: " << endl;
cin >> name;

cout <<"Enter account number: " << endl;
cin >> accountnumber;

cout <<"Enter beginning balance: " << endl;
cin >> beginningbal;

cout <<"Enter total charges this month: " <<  endl;
cin >> totalchargesthismonth;

cout <<"Enter total credits this month: " <<  endl;
cin >> totalcreditsthismonth;

cout <<"Enter your credit limit: " <<  endl;
cin >> creditlimit;

newbalance = (beginningbal - totalchargesthismonth +
totalcreditsthismonth);

    while (newbalance < creditlimit)
{
cout  <<"You have an available balance " << endl;
}
cout <<" Credit Limit exeeded " <<  endl;
return 0;
}

[fafner]

You're almost there, just need to move some stuff around :) I haven't tried this, but it should work:

#include <iostream>

using namespace std;

int main() {

	//variables
	double beginningbal, totalchargesthismonth,
	totalcreditsthismonth, creditlimit, newbalance, accountnumber;
	string  name;

	//user enters information
	cout <<"Enter your name: " << endl;
	cin >> name;

	cout <<"Enter account number: " << endl;
	cin >> accountnumber;

	cout <<"Enter beginning balance: " << endl;
	cin >> beginningbal;

	cout <<"Enter your credit limit: " <<  endl;
	cin >> creditlimit;

	cout <<"Enter total charges this month: " <<  endl;
	cin >> totalchargesthismonth;

	cout <<"Enter total credits this month: " <<  endl;
	cin >> totalcreditsthismonth;

	newbalance = (beginningbal - totalchargesthismonth + totalcreditsthismonth);

	while (newbalance < creditlimit) {
		cout << "You have an available balance " << endl;

		cout <<"Enter total charges this month: " <<  endl;
		cin >> totalchargesthismonth;

		cout <<"Enter total credits this month: " <<  endl;
		cin >> totalcreditsthismonth;

		newbalance = (beginningbal - totalchargesthismonth + totalcreditsthismonth);
	}

	cout <<" Credit Limit exeeded " <<  endl;

	return 0;
}

[adamcampbell]

Yay it works i have 2 problems left

The first is i thought charge meant someone spent X amount of money
and Credit meant that they paid back X amount of money do i have that mixed up?

[fafner]

Woops, I made a mistake. Line 43 should be

newbalance = (newbalance - totalchargesthismonth + totalcreditsthismonth);

[adamcampbell]

Im still having my charge and credit flip-flopped

#include <iostream>
using namespace std;
int main()
{

//variables
double beginningbal, totalchargesthismonth,
totalcreditsthismonth, creditlimit, newbalance, accountnumber;
string  name;

//user enters information

                cout <<"Enter your name: " << endl;
                cin >> name;

                cout <<"Enter account number: " << endl;
                cin >> accountnumber;

                cout <<"Enter beginning balance: " << endl;
                cin >> beginningbal;

                cout <<"Enter total charges this month: " <<  endl;
                cin >> totalchargesthismonth;

                cout <<"Enter total credits this month: " <<  endl;
                cin >> totalcreditsthismonth;

                cout <<"Enter your credit limit: " <<  endl;
                cin >> creditlimit;
newbalance = (beginningbal - totalchargesthismonth + totalcreditsthismonth);

while (newbalance < creditlimit) {
                cout << "You have an available balance " << endl;

                cout <<"Enter total charges this month: " <<  endl;
                cin >> totalchargesthismonth;

                cout <<"Enter total credits this month: " <<  endl;
                cin >> totalcreditsthismonth;

                newbalance = (beginningbal - totalchargesthismonth + totalcreditsthismonth);
        }

                cout <<" Credit Limit exeeded " <<  endl;
return 0;
)

[fafner]

Im not sure about charge/credits to be honest, haha :P

[adamcampbell]

It's got them flipped. im switching stuff around and it still looks like this

Enter balance: (i say) 3000

Enter Charges: (i say) 3000

Enter Credits: (isay) 0

Enter Credit Limit: (i say) 5000

"You have an available ballance"

any ideas?