array of strings function

[fapyfapy]

-solved thanks-

[long double main]

Try replacing
if (o[i] == "word")
with
if (o[i] == word)
and see if that helps.

[fapyfapy]

--

[long double main]

What's count?

Anyways, I found two other problems with your function:

int number(const string o[], int n, string word)
{
    int number; // Uninitialized -- you should set this to 0 first
    for (int i = 0; i < n, i++;) // Should be: for (int i = 0; i < n; i++)
    {

[bufige]

You're doing it pretty wrong. You're comparing a char type with a string literal, which will lead to errors. You could do something like below.

#include <iostream>
#include <string>

int main()
{
    std::string str = "word-word-word-word-word-not w-o-r-d";
    std::size_t size = 0;

    int found = 0;

    while((size = str.find("word",size)) != std::string::npos)
        found++,size++;

    std::cout << found << std::endl;

    return 0;
}

[fapyfapy]

@long double main
Thanks, I made those two corrections. The output is similar nonetheless. Count changed to number.

[giblit]

You're comparing a char type with a string literal

He has an array of strings not an array of characters.

[bufige]

He has an array of strings not an array of characters.

Yes, i didn't noticed that, my mistake.

[zybCM4Gy]

Please explain to me what n is supposed to be doing?

[giblit]

Please explain to me what n is supposed to be doing?

He solved this I am pretty sure of. Anyways though n is for the number of elements there are in the array. otherwise you wouldn't know when to stop.

[long double main]

Please explain to me what n is supposed to be doing?

n is the size of the array.
Nothing wrong there...

[zybCM4Gy]

Yeah I figured that >.<;;;

Looks to me like you can't define a string array in that manner >.>;;;

You know what. INIT THE FUDGING number variable. *whacks C++ with a hammer*. Can't believe that was the problem.

//#include "stdafx.h" //Dunno why this is here but it's not required. 
#include <iostream>
#include <string>
using namespace std;

//Setting a default value for word and passing by reference for the lulz
/*
 * Search an array of strings for input
 */
int number(const string o[], const int &length_of_array, string word = "word")
{

	int number = 0;

	/*
	 * Step through array to count number of instances of words
	 */
	for (int i = 0; i <= (length_of_array-1) ; i++)
	{
		if (o[i] == word)
		{
			number++;
		}
	}
	return number;
}

int main()
{
	string array_of_words[] = { "word", "word", "word", "boo", "word" };
	cout << number(array_of_words, 5, "word");

	return 0;
}

[giblit]

That was not the issue he defined the string array perfectly fine. The issue he had was he never initialized his count to 0 so when he incremented it was undefined behavior and that he put quotes around a variable name.

[cire]

In

int number(const string o[], int n, string word)
{
	int number;
	for (int i = 0; i < n, i++;)
	{
		if (o[i] == "word")
		{
			number++;
		}
	}	
	return number;
}

int main ()
{
	string o[5] = {"l", "t", "t", "word", "word"};
	cout << number;
}

Line 17 prints the address of the function number. It does not call the function.

[zybCM4Gy]

That's...true but it wasn't the problem.

int number was initing to some really freaky number all on its very own >_>;; (see my earlier post)

@giblit

Perhaps, but it was still fun to debug :D

[fapyfapy]

Yes that was the problem, the cout was not calling the function.