overloading operator

[areyoupp]

#include <iostream>
#include <stdlib.h>
#include <cstring>
#include <string>
#include <sstream>

using namespace std;
//////////////////////////////////
class bMoney
{
      private:
         long double money;
         int n;
         char* end;
         int len;
         char* str;
         char* karakter;
      
      public:
             
       bMoney(): money(0.0),n(0),len(0)
       { }
       bMoney(long double par): money(par)
       { }
       ///////////////////////////
       void getMoney()
       {
       
      cout << "Enter money: "; 
      cin >> str;
      }
      //////////////////////////
      void putMoney()
      {cout <<"Your cash is:" << money << endl;}
      ////////////////////////////////////////////////////////////
      void mstold()
      {
          int n=0;
          
          char* end;
          int len = strlen(str);
                 for(int i=0; i<len+1; i++)    
                 {
                      if(str[i] >= '0' && str[i] <= '9')
                      {
                        karakter[n] = str[i];
                      n++;
                      }
                 }
     
                        
               money = strtold(karakter,NULL);
     
               
      }
        
///////////////////////////////////////////////////////
       void ldtombs()
        {
         std::ostringstream ss;
         ss << money;
        karakter = strdup( ss.str().c_str() );
         }
         
       void addmoney(bMoney a)
         {
            money +=a.money;
         }
//////////////////////////////////////////////////
       bMoney operator + (bMoney a2)
       {
              long double temp; 
              temp = money + a2.money;
              
              return bMoney(temp);
       
       
       }
/////////////////////////////////////////////////////       
       bMoney operator - (bMoney a2)
       {
              long double temp;
             temp = money - a2.money;
       
              return bMoney(temp);
       }
//////////////////////////////////////////////////////
       bMoney operator * (bMoney a2)
       {
              long double temp;
             temp = money * a2.money;
              
              return bMoney(temp);
       }
////////////////////////////////////////////////////////////7
      bMoney operator / (bMoney a2)
      {
             long double temp;
            temp = money / a2.money;
      
             return bMoney(temp);
      }
////////////////////////////////////////////////////////////////
      long double  operator / (long double a2)
      {
                    return (money / a2);
      }            
                   
              
};
            

   
int main(int argc, char *argv[])
{
    bMoney a1,a2,a3;
    a1.getMoney();  
    a1.mstold();
    a2.getMoney();
    a2.mstold();
    a3 = a1 + a2;
    a3.mstold();
    a3.putMoney();
   
   

    
    
    system("PAUSE");
    return EXIT_SUCCESS;
}

where is the problem in operator + ?

[R0mai]

You never allocate memory for str, karakter and end varibales, they are pointing to some memory garbage. you can dynamically allocate memory with new, and then deallocate with delete, but I recomend to use std::vector, which will do the memory (de)allocation for you, if you use arrays then you have to define copy construtor, and assignment operator, which will copy the contents of the arrays :

bMoney(const bMoney& other) {
    //copy and assign stuff from other to *this
}
bMoney& operator=(const bMoney& other) {
    //copy stuff and assign from other to *this
    return *this;
}

Hope this helps

[areyoupp]

//30.06.2009
//para karakter katarını long double'a çevirir.Long double'ı da para karakter katarına çevirir

#include <iostream>
#include <stdlib.h>
#include <cstring>
#include <string>
#include <sstream>

using namespace std;
//////////////////////////////////
class bMoney
{
      private: //declare variables
         long double money;
         int n;
         int len;
         char str[100];
         char karakter[100];
      
      public:
    
       bMoney(): money(0.0),n(0),len(0) // constructor
       { }
       bMoney(long double par): money(par) //what is this^_^
       { }
       
       bMoney(const bMoney& other) //copy constructor
       {
          money += other.money;
       }
       //////////////////////////////////
       bMoney& operator = (const bMoney& other) //assignment operator
       {
               money+=other.money;
               return *this;
       }
            ///////////////////////////
       void getMoney() //get money because i need money
       {
       
      cout << "Enter money: "; 
      cin >> str;
      }
      //////////////////////////
      void putMoney() // this is your money
      {cout <<"Your cash is:" << money << endl;}
      ////////////////////////////////////////////////////////////
      void mstold() // convert string to long double 
      {
          int n=0;
          int len = strlen(str);
                 for(int i=0; i<len+1; i++)    
                 {
                      if(str[i] >= '0' && str[i] <= '9')
                      {
                        karakter[n] = str[i];
                      n++;
                      }
                 }
     
                        
               money = strtold(karakter,NULL);
     
               
      }
        
///////////////////////////////////////////////////////

         
       void addmoney(bMoney a) // add money
         {
            money +=a.money;
         }
//////////////////////////////////////////////////
       bMoney operator + (bMoney a2) // + operator
       {
            this -> money += a2.money;
            return *this;
       
       }
/////////////////////////////////////////////////////       
       bMoney operator - (bMoney a2) // - operator
       {
               this -> money += a2.money;
            return *this;
       }
//////////////////////////////////////////////////////
       bMoney operator * (bMoney a2) //* operator
       {
               this -> money -= a2.money;
                return *this;
       }
////////////////////////////////////////////////////////////7
      bMoney operator / (bMoney a2)
      {
             this -> money /= a2.money;
                return *this;
      }

         
                                
};
////////////////////////////////////////////////////////////////
        
int main(int argc, char *argv[])
{
    bMoney a1,a2,a3;
    a1.getMoney();  
    a1.mstold();
    a2.getMoney();
    a2.mstold();
    a3 = a1 + a2;
    a3.mstold();
    a3.putMoney();
   

    system("PAUSE");
    return EXIT_SUCCESS;
}

i dont take error. but. out put is "Cash is 0 " i dont understand

[wmheric]

Those pointers point to the stack...

What does the function void bMoney::getMoney() do? It doesn't deal with any of the member variables.

Many other issues like...
the copy constructor and the assignment operator are doing += on money. Money isn't necessorily 0.
for other operators, better also pass in a const reference object...and, review all their bodys...- is with +=...* is with -=...and
e.g. + should not change *this, if you want to change *this overload +=, make the interface easier to use...

[areyoupp]

silly me.i review this code again.this is a trash.