Simple Dungeon Crawl, help with rand() or arrays?

[lorilew]

Hi,

I'm trying to build a simple Dungeon Crawl game. And so far I've managed to build the board. Next I wanted to place the treasure in a random square on the board.

This code works, but sometimes it outputs 2 treasures, WHY?

 #include <iostream>

using namespace std;

char board[10][8];


void buildboard();

void initialize();


int main()
{


	initialize();
	buildboard();
	
}

void initialize()
{
	for(int i=0; i<8; i++)
	{
		for(int j=0; j<10; j++)
		{
			board[i][j] = '.';
		}
	}	 
	
	int x, y;
	srand(time(0)); 					
	x = rand() % 8;
	y = rand() % 10;
	board[x][y] = 'T';

}

void buildboard()
{
	system ("cls");
	cout << "\n\tDUNGEON CRAWL \n\n";
	
 	for(int i=0; i<8; i++)
	{
		cout << "\t ";
		for(int j=0; j<10; j++)
		{
			cout << board[i][j];
		}
		cout << endl;
	}	 
}

[Disch]

You have the wrong dims for your board.

Your board is 10x8:

char board[10][8];

Yet you are treating it as 8x10 everywhere else in your code.

[lorilew]

cool thanks, spent too long looking at it, and changed all the 10s and 8s too many times.