C++ Calculator

[venros]

Hi Guys,

Im writing out my first calculator but for some reason its not building, nor is it showing me where the error is.

  #include <iostream>
#include <string>

 
using namespace std;



int multThis(int x, int y)
{
	return x*y;
}

int addThis(int x, int y)
{
	return x+y;
}

double divideThis(double x, int y)
{
	return x/y;
}
int subThis(int x, int y)
{
	return x-y;
}


double solve(double x, double y, char sym);
int calc(double x, double y, char sym);

int main()
{
double x;
double y;
char sym;
int solution;

cin >> x >> sym >> y;

solution = solve(x, y, sym);
cout << "Answer: " << solution << endl;

int solve(double x, double y, char sym);
{
	switch(sym)
{
case '+':
	cout << addThis(x,y);
	break;
case '-':
	cout << subThis(x,y);
	break;
case '*':
	cout << multThis(x,y);
	break;
case '/':
	cout << divideThis(x,y);
	break;
default:
   cout << "\nIncorrect operation!  Try again: ";
   cin >> x >> sym >> y;
   solve(x, y, sym);
}
}
cin.get();
}

ty in advance.

[LB]

How do you know that it isn't compiling if it isn't showing you any error messages that you can copy and paste here?

One thing I notice right away is that you accidentally defined your "solve" function inside the main function!

[venros]

my parameter:


double solve(double x, double y, char sym);

is outside of main, and im not seeing any errors.

[TwilightSpectre]

No, that is your definition, but you implemented it inside of main. Here is what you meant to do:

  #include <iostream>
#include <string>

 
using namespace std;



int multThis(int x, int y)
{
	return x*y;
}

int addThis(int x, int y)
{
	return x+y;
}

double divideThis(double x, int y)
{
	return x/y;
}
int subThis(int x, int y)
{
	return x-y;
}


double solve(double x, double y, char sym);
int calc(double x, double y, char sym);

int main()
{
double x;
double y;
char sym;
int solution;

cin >> x >> sym >> y;

solution = solve(x, y, sym);
cout << "Answer: " << solution << endl;

cin.get();
} 

int solve(double x, double y, char sym)
{
    switch(sym) {
        case '+':
            cout << addThis(x,y);
        break;

        case '-':
            cout << subThis(x,y);
        break;

        case '*':
            cout << multThis(x,y);
        break;

        case '/':
            cout << divideThis(x,y);
        break;

        default:
            cout << "\nIncorrect operation!  Try again: ";
            cin >> x >> sym >> y;
            solve(x, y, sym);
    }
}

Your problem is that you simply forward declared the function within your 'main' function (see the semicolon on the end?) which meant that you then simply put a block with the contents of the function inside. You can't define a function within another one (_{except for lambda funcs}).

[giblit]

You are forgetting the return statement in your solve function.

[edit] You also prototype the function to have a return type of a double but then when you define the solve function it has a return type of int and as mentioned by LB you have the function defined inside of the main function but NT3 show's you where to put it.