Program outputting <player> Wins two times instead of 1.

[yatch017]

Can someone help me out?

When Player x wins program says, X wins 2 times. I cant figure out why.

  #include <iostream>
#include <string>
#include <windows.h>

using namespace std;

string newgame;
int playerx;
int playero;
char board [9] = {'1', '2', '3', '4', '5', '6', '7', '8', '9'};
char player [2] = {'X', 'O'};
bool gamewon();
bool spot_validx();
bool spot_valido();
bool new_game();
int leaderboard_x = 0;
int leaderboard_o = 0;

//If playerx input is 1 and the spot is valid change that board piece to the players Symbol(X).
bool update_gameboardx ()
{
    if (playerx == 1 && spot_validx() == true)
    {
        board[0] = player[0];
    }
    else if  (playerx == 2 && spot_validx() == true)
    {
        board[1] = player[0];
    }
    else if  (playerx == 3 && spot_validx() == true)
    {
        board[2] = player[0];
    }
    else if  (playerx == 4 && spot_validx() == true)
    {
        board[3] = player[0];
    }
    else if  (playerx == 5 && spot_validx() == true)
    {
        board[4] = player[0];
    }
    else if  (playerx == 6 && spot_validx() == true)
    {
        board[5] = player[0];
    }
    else if  (playerx == 7 && spot_validx() == true)
    {
        board[6] = player[0];
    }
    else if  (playerx == 8 && spot_validx() == true)
    {
        board[7] = player[0];
    }
    else if  (playerx == 9 && spot_validx() == true)
    {
        board[8] = player[0];
    }

}

//If playerx input is 1 and the spot is valid change that board piece to the players Symbol(O).
bool update_gameboardo ()
{
    if (playero == 1 && spot_valido() == true)
    {
        board[0] = player[1];
    }
    else if  (playero == 2 && spot_valido() == true)
    {
        board[1] = player[1];
    }
    else if  (playero == 3 && spot_valido() == true)
    {
        board[2] = player[1];
    }
    else if  (playero == 4 && spot_valido() == true)
    {
        board[3] = player[1];
    }
    else if  (playero == 5 && spot_valido() == true)
    {
        board[4] = player[1];
    }
    else if  (playero == 6 && spot_valido() == true)
    {
        board[5] = player[1];
    }
    else if  (playero == 7 && spot_valido() == true)
    {
        board[6] = player[1];
    }
    else if  (playero == 8 && spot_valido() == true)
    {
        board[7] = player[1];
    }
    else if  (playero == 9 && spot_valido() == true)
    {
        board[8] = player[1];
    }

}

//Shows gameboard as it currently is.
void gameboard ()
{
    system ("cls");
    cout<<"          |          |            "<<endl;
    cout<<"     "<<board[0]<<"    |     "<<board[1]<<"    |     "<<board[2]<<"      "<<endl;
    cout<<"          |          |            "<<endl;
    cout<<"----------+----------+----------"<<endl;
    cout<<"          |          |            "<<endl;
    cout<<"     "<<board[3]<<"    |     "<<board[4]<<"    |     "<<board[5]<<"      "<<endl;
    cout<<"          |          |            "<<endl;
    cout<<"----------+----------+----------"<<endl;
    cout<<"          |          |            "<<endl;
    cout<<"     "<<board[6]<<"    |     "<<board[7]<<"    |     "<<board[8]<<"      "<<endl;
    cout<<"          |          |            "<<endl;
}

//The while loop to play through X and O turns
bool playerturn ()
{
    while (gamewon() == false)
    {
        cout<<"Player "<<player[0]<<" please enter a board position (1-9)."<<endl;
        cin>>playerx;
        spot_validx();
        while (spot_validx() == false)
        {
            cout<<"Please select an empty spot"<<endl;
            cin>>playerx;
            spot_validx();
        }
            update_gameboardx();
            gameboard();

        if (gamewon() == true)
        {
            continue;
        }


        cout<<"Player "<<player[1]<<" please enter a board position (1-9)."<<endl;
        cin>>playero;
        spot_valido();
        while (spot_valido() == false)
        {
            cout<<"Please select an empty spot"<<endl;
            cin>>playero;
            spot_valido();
        }

            update_gameboardo();
            gameboard();


    }


Sleep(2000);
system("cls");

    cout<<leaderboard_x - 1<<" Wins for X"<<" |  "<<leaderboard_o<<" Wins for O"<<endl;
    cout<<"             |           "<<endl;
    cout<<"             |           "<<endl;
    cout<<"             |           "<<endl;
    cout<<"             |           "<<endl;
    cout<<"             |           "<<endl;


Sleep(4000);

    new_game();
}

//Checks if spot isnt X or O
bool spot_validx()
{
    int i = playerx - 1  ;
        if (board[i] != 'X' && board[i] != 'O')
        {
            gamewon();
            return true;

        }
        else
        {
            return false;
        }



}

//Checks if spot isnt X or O
bool spot_valido()
{
    int i = playero - 1;
        if (board[i] != 'X' && board[i] != 'O')
        {
            gamewon();
            return true;
        }
        else
        {
            return false;
        }



}

//Game Win Conditions, If game is won leaderboard will be updated and player that won will be updated.
bool gamewon()
{
    //Horizontal Win Cases
    if ((board[0] == board[1]) && (board[0] == board [2]))
    {
        cout<<board[0]<<" Wins!"<<endl;
        if (board [0] == 'X')
        {
         leaderboard_x += 1;
        }
        else if (board[0] == 'O')
        {
            leaderboard_o += 1;
        }
        return true;
    }
    else if (board[3] == board[4] && board[3] == board [5])
    {
        cout<<board[3]<<" Wins!"<<endl;
        if (board [3] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[3] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    else if (board[6] == board[7] && board[6] == board [8])
    {
        cout<<board[6]<<" Wins!"<<endl;
        if (board [6] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[6] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    // Vertical Win Cases
    else if (board[0] == board[3] && board[0] == board [6])
    {
        cout<<board[0]<<" Wins!"<<endl;
        if (board [0] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[0] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    else if (board[1] == board[4] && board[1] == board [7])
    {
        cout<<board[1]<<" Wins!"<<endl;
        if (board [1] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[1] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    else if (board[2] == board[5] && board[2] == board [8])
    {
        cout<<board[2]<<" Wins!"<<endl;
        if (board [2] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[2] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    //Diagonal Win Cases
    else if (board[0] == board[4] && board[0] == board [8])
    {
        cout<<board[0]<<" Wins!"<<endl;
        if (board [0] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[0] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    else if (board[2] == board[4] && board[2] == board [6])
    {
        cout<<board[2]<<" Wins!"<<endl;
        if (board [2] == 'X')
        {
         leaderboard_x ++;
        }
        else if (board[2] == 'O')
        {
            leaderboard_o ++;
        }
        return true;
    }
    else
        return false;




}

//Will ask user if they want new game.
bool new_game()
{

        system("cls");
        cout<<"Would you like to play again? (Enter 'yes' or 'no')"<<endl;
        cin>>newgame;

        if (newgame == "yes" || newgame == "y" || newgame == "YES")
        {
            board[0] = '1';
            board[1] = '2';
            board[2] = '3';
            board[3] = '4';
            board[4] = '5';
            board[5] = '6';
            board[6] = '7';
            board[7] = '8';
            board[8] = '9';

            gameboard();
            playerturn();


        }
        else if (newgame == "no" || newgame == "n" || newgame == "NO")
        {
            system ("cls");
            cout<<endl<<endl<<endl<<"Thank you for playing!"<<endl;
        }
        else{
            cout<<"Please enter a correct response."<<endl;
            cin>>newgame;
        }

}
int main()
{
    cout<<"Tic tac Toe by Daniel"<<endl<<endl;
    gameboard();


    cout<<endl<<"Player X starts first"<<endl;

    playerturn();


}

[iAk3T05o]

You made mistakes with the winning part.
It's 3 == 4 && 4 == 5, 4 == 6 && 6 == 8 etc.

You also made other mistakes.

[yatch017]

I dont doubt that i've made other mistakes. I expected that however I still dont understand what the difference is between what i did:

if ((board[0] == board[1]) && (board[0] == board [2]))

and what your saying:

It's 3 == 4 && 4 == 5, 4 == 6 && 6 == 8 etc.

Both of these ways compare the same thing. If 3 spots are inhabited by the same symbol.

I also don't understand why my way would output "X wins" twice vs your way which is essentially saything the samething in a different way.

[S G H]

Try removing spot_valido() on line 145 (The one BEFORE the while).
Same for spot_validx() on line 127.

[yatch017]

I tried removing the spot_valido before the while loop and it still outputs "X wins twice". When O wins it only outputs it one time "O wins". "X wins" still says it twice each on a new line.