code for controls

[badvegeta]

I have been trying to write code for moving controls..
please look at the code and tell me wat i have done wrong.
necessary header files have been included

  while(i<79&&j<25)
{
if(kbhit())
{
ch=getch();

 if(ch=='d'||ch=='D')                          // for right
 {            gotoxy(i,j);
   cout<<"*";
    k=i;
   gotoxy(k-1,j);
   cout<<" ";
  i++ ;

  } ;



if(ch=='a'||ch=='A') // for left
{
int w=i;
gotoxy(w-1,j);
cout<<"*";
gotoxy(w,j);
cout<<" ";
i--;
}
if(ch=='s'||ch=='S')                // for down
{
gotoxy(i-1,j+1);
cout<<"$";

e=j;
gotoxy(i-1,e);
cout<<" ";

j++;
}
if(ch=='w'||ch=='W')       // for up
{
int f=j+1;
gotoxy(i-1,j-1);
cout<<"*";
gotoxy(i-1,f-1);
cout<<" ";
 j--;
 }

[kienme]

Cleaned it up a bit for you.

while(i<79&&j<24)
{
	if(kbhit())
	{
		ch=getch();

		if(ch=='d'||ch=='D')
 		{
			gotoxy(i,j);
   			cout<<" ";
			++i;
   			gotoxy(i,j);
   			cout<<"*";
  		}

		if(ch=='a'||ch=='A') 
		{
			gotoxy(i,j);
			cout<<" ";
			i--;
			gotoxy(i,j);
			cout<<"*";
			
		}
		
		if(ch=='s'||ch=='S')                
		{
			gotoxy(i,j);
			cout<<" ";
			j++;
                        gotoxy(i,j);
			cout<<"*";
			
		}
		
		if(ch=='w'||ch=='W')
		{
                        gotoxy(i,j);
			cout<<" ";
			j--;
			gotoxy(i,j);
			cout<<"*";
 		}
	}
}