urgently need help (while loop)

[xarmzon]

i keep getting run time error in this program. if I input a the loop still continue but if I put a for the second time, the loop will now stop and I can't figure out the bug. I want the loop to stop if user input either a,b,c,d to m. thanks

  // solution to question 2 chapter five

//write a menu program that  let the user
//select from a list of options, and if the
//input is not one of the options, reprint
//the list.

#include <iostream>
#include <string>
using namespace std; 

int main()
{

  string type = " ";

cout << "Welcome to xarm softdrinks shop" << endl << endl;

cout << "choose your order below! (a - n)" << endl << endl;
cout << "a - Coca-Cola \t\t b - Sprite" << endl; 
cout << "c - Fanta \t\t d - Limca" << endl; 
cout << "e - Mountain Dew \t f - Pepsi" << endl; 
cout << "g - 7-Up \t\t h - Maltina" << endl; 
cout << "i - Mirinda \t\t j - Malta Guiness \t" << endl; 
cout << "k - Malt \t\t l - Amstel Malta \t" << endl; 
cout << "m - maltina" << endl << endl;

cout << "Your order: ";

getline (cin, type);

while ((type != "a") || (type != "b") || (type != "c") || 
(type != "d") || (type != "e") || (type != "f") ||
 (type != "g") || (type != "h") || (type != "i") || 
(type != "j") || (type != "k") || (type != "l") ||
 (type != "m"))
{
    cout << endl;
    cout << "Invalid order! " << endl << endl;
    cout << "Choose from a - m only " << endl << endl;

    cout << "a - Coca-Cola \t\t b - Sprite" << endl; 
    cout << "c - Fanta \t\t d - Limca" << endl; 
    cout << "e - Mountain Dew \t f - Pepsi" << endl; 
    cout << "g - 7-Up \t\t h - Maltina" << endl; 
    cout << "i - Mirinda \t\t j - Malta Guiness \t" << endl; 
    cout << "k - Malt \t\t l - Amstel Malta \t" << endl; 
    cout << "m - maltina" << endl << endl;

    cout << "Your order again: ";

cin >> type; 

if ((type == "a") || (type == "b") || (type == "c") ||
 (type == "d") || (type == "e") || (type == "f") || 
(type == "g") || (type == "h") || (type == "i") || 
(type == "j") || (type == "k") || (type == "l") || 
(type == "m"))

{
 break; 
}

}



}

[MatthewRock]

Your while loop condition is false. Use AND instead of OR.

If you input "a", first condition(type != "a") is false, but next(type != "b") is true. Change it.

Cheers!

[xarmzon]

but if I use &&. the whole condition will become false. I used || since one of the condition must be true.

[MatthewRock]

You can take whole condition from your if and negate it.
And you are right about the first part, my bad.

[xarmzon]

thanks