goto function wont work

[eman2013]

my goto function wont work when I call it in the else if statement b==3. Thank you!

  #include <iostream>
#include <windows.h>
#include <stdio.h>

COORD coord= {0,0};

using namespace std;

void gotoxy(int x, int y)
{
    coord.X=x;
    coord.Y=y;
    SetConsoleCursorPosition(GetStdHandle(STD_OUTPUT_HANDLE),coord);
}
class Piece
{
private:
    int x,y,color;
public:
    Piece()
    {
        x=-1;
        y=-1;
        color=2;
    }
    void setcolor(int c)
    {
        color=c;
    }
    void setposition(int x_pos,int y_pos, int c)
    {
        x=x_pos;
        y=y_pos;
        color=c;
    }
    void set(int x_pos, int y_pos)
    {
        x=x_pos;
        y=y_pos;
    }
    int getc()
    {
        return color;
    }
    int getx()
    {
        return x;
    }
    int gety()
    {
        return y;
    }
    void display();
};
void Piece::display()
{
    int a=getc();
    int x=getx();
    int y=gety();
    if(a==0)
    {
        gotoxy(4*x+21,2*y+6);
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | FOREGROUND_RED );
        cout<<"O";
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
    }
    else if(a==1)
    {
        gotoxy(4*x+21,2*y+6);
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | 2);
        cout<<"X";
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
    }
    /*else if(a==2)//the piece has not been set so this outputs 0 on the default cordinates
    {
        gotoxy(4*x+21,2*y+5);
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), BACKGROUND_BLUE | FOREGROUND_INTENSITY | 7);
        cout<<"0";
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
    }*/
}
class Board
{
private:
    Piece list[64];
    int x1, y1, h;
    int status, redpiece, greenpiece, winner;
    int stat(int h);
    int inRange(int x, int y);
    int pieceAtLoc(int x, int y);
    int validPlacement(int x, int y);
    void flip(int x, int y);
    void display();
    void move();
public:
    Board();
    void execute();
};
Board::Board()
{
    list[1].setposition(4,4,1);
    list[2].setposition(5,4,0);
    list[3].setposition(4,5,0);
    list[4].setposition(5,5,1);
    char bb=186;
    char jj=205;
    system("Color 9");
    for(int j=0; j<9; j++)// = on the grid
    {
        for(int i=0; i<8; i++)
        {

            gotoxy(4*i+25,2*j+7);
            cout<<jj;
        }
    }
    for(int j=0; j<8; j++)// || on the grid
    {
        for(int i=0; i<9; i++)
        {
            gotoxy(4*i+23,2*j+8);
            cout<<bb;
        }
    }
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | 6);
    for(int i=1; i<9; i++)//creates the numbers for the x-axis
    {
        gotoxy(4*i+21,6);
        cout<<i;
    }
    for(int i=1; i<9; i++)//creates the numbers for the y-axis
    {
        gotoxy(21,2*i+6);
        cout<<i;
    }
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | FOREGROUND_RED );
    gotoxy(58,7);
    cout<<"2 of Player O pieces";
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | 2);
    gotoxy(58,9);
    cout<<"2 of Player X pieces";
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
    gotoxy(35,4);
    cout<<"Othello";
    gotoxy(30,5);
    cout<<"By: Ephraim Moges";
}
int Board::stat(int h)
{
    gotoxy(7,9);
    cout<<"Status";
    if(h==1)
    {
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | 2);// X turn
        gotoxy(5,12);
        cout<<"||     ||";
        gotoxy(5,13);
        cout<<" ||   ||";
        gotoxy(5,14);
        cout<<"  || ||  ";
        gotoxy(5,15);
        cout<<"   |||    ";
        gotoxy(5,16);
        cout<<"  || ||   ";
        gotoxy(5,17);
        cout<<" ||   || ";
        gotoxy(5,18);
        cout<<"||     ||";
        gotoxy(5,19);
        cout<<"          ";
        gotoxy(62,13);
        cout<<"Cordinates";
        gotoxy(63,15);
        cout<<"(   ,   )";
    }
    else
    {
        SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | FOREGROUND_RED );// O turn
        gotoxy(5,12);
        cout<<"   ||||  ";
        gotoxy(5,13);
        cout<<"  ||  ||";
        gotoxy(5,14);
        cout<<" ||    ||";
        gotoxy(5,15);
        cout<<"||      ||";
        gotoxy(5,16);
        cout<<"||      || ";
        gotoxy(5,17);
        cout<<" ||    ||";
        gotoxy(5,18);
        cout<<"  ||  || ";
        gotoxy(5,19);
        cout<<"   ||||";
        gotoxy(62,13);
        cout<<"Cordinates";
        gotoxy(63,15);
        cout<<"(   ,   )";
    }
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
}
int Board::inRange(int x, int y)
{
    if(((x>0) && (x<9)) && ((y>0) && (y<9))) //on the grid
    {
        return 1;
    }
    else
    {
        return 0;
    }
}
int Board::pieceAtLoc(int x, int y)
{
    int i=1;
    while(i!=0)
    {
        if((list[i].getx()==x) && (list[i].gety()==y))
        {
            return 1;
            i=0;
        }
        else if(list[i].getc()==2)
        {
            return 0;
            i=0;
        }
        i++;
    }

}
int Board::validPlacement(int x, int y)
{
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 4);
    cout<<"b";
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
}
void Board::move()
{

}
void Board::display()
{
    for(int i=1; i<65; i++)
    {
        list[i].display();
    }
}
void Board::execute()
{
    int b=1;
    int x=0;
    int y=0;
    gotoxy(62,11);
    cout<<"PASS:( )";
    while(b!=0)
    {
        int p=1;
        int an=1;
        two:
        if(b==1)
        {
            while(an==1)
            {
                display();
                if(p%2==0)
                {
                    stat(1);
                }
                else
                {
                    stat(0);
                }
                gotoxy(68,11);
                cin>>an;//0 means no and 1 means yes
                p++;
            }
            b=2;
        }
        else if(b==2)
        {
            while(inRange(x,y)==0)
            {
                gotoxy(65,15);
                cin>>x;
                gotoxy(69,15);
                cin>>y;
                if(inRange(x,y)==0)
                {
                    gotoxy(65,16);
                    cout<<"Again!";
                    gotoxy(65,15);
                    cout<<" ";
                    gotoxy(69,15);
                    cout<<" ";
                }
            }
            b=3;
        }
        else if(b==3)
        {
            if(pieceAtLoc(x,y)==1)
            {
                SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | 2);// X turn
                gotoxy(65,20);
                cout<<"done";
                SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
                b=2;
                goto two;
            }
            else if(pieceAtLoc(x,y)==0)
            {
                b=4;
            }
        }
        else if(b==4)
        {
            SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), FOREGROUND_INTENSITY | 2);// X turn
            gotoxy(65,20);
            cout<<"done";
            SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 15);
            b=0;
            /*if(valid)
            {

            }*/
        }

    }
    SetConsoleTextAttribute( GetStdHandle(STD_OUTPUT_HANDLE), 9);
    gotoxy(23,25);
    cout<<" ";
}
int main()
{
    Board b;
    b.execute();
    Piece p;
    p.display();
}

[yulingo]

I'm not on Windows, so I can't really see what's wrong, but I think you'll be much better off using the continue keyword rather than goto.

[Lowest0ne]

They should be if instead of else if

int b = 1;

while ( b ! = 0 )
{
  if ( b == 1 ) { std::cout << "One ";   b = 3; }
  if ( b == 2 ) { std::cout << "Two ";   b = 0; }
  if ( b == 3 ) { std::cout << "Three "; b = 2; }
}

Probably better to use a switch statement.

[MatthewRock]

If your goto doesn't work, I have one nice advice: don't use goto. If it works, don't use goto either.

Goto is not used too often, because it's considered bad programming practice. Why? Because its nature makes code that consists of goto operations harder to read. If you write really big program, it can be nearly impossible to get an idea of what is going on with gotos.

Good news: you can replace any goto you want with good design of your program. Try focusing on using conditionals, loops, etc. in such way so that you don't have to use goto. Really, these could not exist and it would be ok. Gotos are not mandatory, but they are annoying.

I also don't use windows, but couldn't it be because pieceAtLoc() returned 0?