Stack around the variable corrupted?

[jlpurnell]

I get this error:
Run-time check Failure #2 - Stack around the variable "city" was corrupted.

Please help! What is wrong? When I remove every instance of "city" (to troubleshoot), it then says:
Run-time check Failure #2 - Stack around the variable "address" was corrupted.

THANKS!

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int write(void)
{
    ofstream outfile;
    char firstname[50],
         lastname[60],
         address[60],
         city[50],
         state[10],
         zipcode[10],
         phonenumber[13];
    int index;

    outfile.open("PersonalData.txt",ios::app);
    cout<<"Enter your First Name: ";
    cin>>firstname;
    cin.ignore();
    cout<<"Enter your Last Name: ";
    cin>>lastname;
    cin.ignore();
    cout<<"Enter your Address: ";
    cin.getline(address, sizeof(address));
    cin.ignore();
    cout<<"Enter your City: ";
    cin.getline(city, 50);
    cout<<"Enter your State: ";
    cin.getline(state, sizeof(state));
    cin.ignore();
    cout<<"Enter your ZipCode: ";
    cin.getline(zipcode, 10);
    cout<<"Enter your Phone Number: ";
    cin.getline(phonenumber, 13);
    cin.ignore();

    outfile<<firstname<<setw(2)<<lastname<<setw(2)<<address<<setw(2)<<city<<setw(2)<<state<<setw(2)<<zipcode<<setw(2)<<phonenumber<<endl;
    outfile.close();
    cout<<"Writing Completed."<<endl;
    return 0;
}

int read(void)
{
    ifstream input;
    input.open("PersonalData.txt",ios::in);

    char firstname[50],
         lastname[60],
         address[60],
         city[50],
         state[10],
         zipcode[10],
         phonenumber[13];

    int counter =1;
    while(!input.eof())
    {
        input>>firstname>>lastname>>address>>city>>state>>zipcode>>phonenumber;
        
        cout<<firstname<<setw(1)<<lastname<<endl;
        cout<<address<<endl;
        cout<<city<<setw(2)<<state<<setw(2)<<zipcode<<endl;
        cout<<phonenumber<<endl;
        counter++;
        cout<<endl;
    }
    cout<<"Reading Completed. "<<endl;
    input.close();
    return 0;
}

int main()
{
      int choice;
      char ch;

      do{
          cout<<endl;
          cout<<"Please choose from the following: \n";
          cout<<"\t1. Read Data. \n";
          cout<<"\t2. Write Data. \n";
          cout<<"\t3. Quit. \n";
          cout<<endl;
          cout<<"Your choice: ";
          cin>>choice;


           switch(choice)
          {
             case 1:
                     read();
                   break;
             case 2:
                     write();
                   break;
             case 3:

                   break;
             default:
                   cout<<"\tInvalid entry!"<<endl;
           }
           cout<<"\nWould you like to try again (y/n): ";
           cin>>ch;

     }while(ch == 'y' || ch == 'Y');

      system("PAUSE");
      return 0;
}

[yulingo]

when you call sizeof() to get your array size, you are getting the number of bytes your array occupies, not the number of characters in your array. getline expects the number of characters, so it will continue to read from the stream into your buffer, irregardless of whether it overflows the buffer.

This post explains how to properly get the size of your array:
http://stackoverflow.com/questions/37538/how-do-i-determine-the-size-of-my-array-in-c