Debugging

[L6Rz8vqX]

Hi. I am having difficulty with seeing or interpreting the errors in this program. Any help with showing how/what needs to be fixed would be appreciated!

Thank you!

#include <iostream>
#include <iomanip>


using namespace std;

void readData(ifstream& inputFile, int list[], int size);
void holdscrn( );    // void function to hold screen open before exit


int main()
{
    int scores[8] = {0};
    
    ifstream infile;
    
    infile.open("TestScoresData.txt");
    
	if (infile)
	{
		cout << "Cannot open the input file. Program terminates!"
        << endl;
		holdscrn( );   // Hold screen before exit
		return 1;
	}
    
	readData(infile, scores, 8);
	print(scores, 8);
	cout << endl;
    
	infile.close();
	holdscrn( );   // Hold screen before exit
	return 0;
}

void readData(ifstream& inputFile, int list[], int size)
{
	int score;
	int index;
    
	cin >> score;
    
	while (inputFile)
	{
		index = score / 25;
        
		if (index == size)
			index--;
		if (index < size)
			list[index]++;
        
		inputFile >> score;
	}
    return 0;
}

void print(int list[], int size)
{
    int range;
    int lowRange = 0;
    int upperRange = 24;
    
    cout << "   Range       # of Students" << endl;
    
    for (range = 0; range < size; range++)
    {
        cout << setw(3) << lowRange << " - "
        << upperRange << setw(15)
        << list[range] << endl;
        lowRange = upperRange + 1;
        upperRange = upperRange + 25;
        if (range == size - 2)
            upperRange++;
    }
    cout << endl;
    return;
}

void holdscrn( )   // void function to hold screen open before exit
{
    char holdscreen;
    cout << "\n\n\tEnter one character and press return to exit program:  ";
    cin >> holdscreen;
    
    return;
}

[i like red pandas]

Try compiling it. Your compiler should give you error messages to help you debug.

But here are a few major issues:
1. You need to declare functions and variables before you can use them.
2. ifstream needs the header #include <fstream>
3. Your function readData is a void function yet it returns a value.

[booradley60]

1. #include <fstream>
2. Remove line 54. Can't return a value in a function declared to return void.
3. Forward declare void print(int list[], int size) like you did with your other functions.

[L6Rz8vqX]

Thank you for the help!

Booradley, could you please explain what you mean by "forward declare"? Sorry to be so obtuse about it!

[MatthewRock]

He meant function prototype.

http://opencbp.sourceforge.net/en_US.ISO8859-1/books/opencbook/func.prototypes.html
or
http://en.wikipedia.org/wiki/Function_prototype

You can have function declaration, or prototype and declaration. Prototype is a declaration of function before implementing it(writing function code).
It looks like this:

void holdscrn();//Now we know that function holdscrn() exists and what it looks like.
//some code...

void holdscrn()
{
 //code for function
}

Function prototypes are broadly used because it's just easier to have code in one place(usually at the end of file or in other file), and declarations at the beginning. It kind of looks like table of contents in book ;)

Cheers!

[booradley60]

More info if you're interested.

http://stackoverflow.com/questions/4757565/c-forward-declaration