Simple error.

[bridgster]

We was asked to create a program using a class called CounterType that counted things. Then we had to create a program using 3 CounterTypes, one for positive Numbers, Negative Numbers, and Zeroes. It reads in data from a text file which we customize the numbers to make sure it works. We have the program near perfect, with one fault. It adds an extra count to whatever the last digit of the text file is. For example if it ends in Negative, it adds an extra count to the negative counter.

#include <iostream>
#include <fstream>
using namespace std;

class CounterType
{
 public:
        void plus();
        void nega();
        void display();
        CounterType( )
         {
          counter = 0;
         }

        CounterType(int count)
         {
          counter = count;
         }

 private:
        int counter;

};

void CounterType::plus()
{
  counter++;
}

void CounterType::nega()
{
 if(counter == 0)
  {
   cout << "ERROR: Counter cannot become negative\n";
  }

 else
  {
  counter--;
  }

}

void CounterType::display()
{
        cout << counter << endl;

}

int main()
{
 int num;
 ifstream file1;
 file1.open("num.txt");
 CounterType positive;
 CounterType negative;
 CounterType zeroes;

while(file1)
  {
   file1 >> num;
   if(num > 0)
   {
    positive.plus();
   }
   else if(num < 0)
   {
    negative.plus();
   }
   else if(num == 0)
   {
    zeroes.plus();
   }
   else;

  }

 cout << "Positives:";
 positive.display();
 cout << "Negatives:";
 negative.display();
 cout << "Zeroes:";
 zeroes.display();
 return 0;
}

[bridgster]

Still looking for some help, thanks!

[cire]

  while(file1)
  {
   file1 >> num;
   if(num > 0)
   {
    positive.plus();

should be:

  while(file1 >> num)
  {
   if(num > 0)
   {
    positive.plus();

You usually want to see if the input extraction is successful, not check the state of the file prior to an extraction attempt and then just assume the extraction was successful.