Bool function used in procedure not working as expected

[Martin V]

Hello, this is my first post and I'm very new to programming. I need to create a bool function that is used in a procedure for validation.

What I want to do is: When user writes "0" bool should be false, otherwise do while stops iterating.

Help appreciated.

typedef struct ty_venta
{
    string sFech;
    int iCant;
    int iCod;
};


bool isValidDate(ty_venta rVenta)   //Corregir para que funcione
{
    bool isValid;

        if(rVenta.sFech == "0")
        {
            isValid = false;
        }
        else
        {
            isValid = true;
        };

        return isValid;
};

void ingreso(ty_venta & rVenta, bool  isValid)  
{

    do
    {
    cout << "ingrese fecha del show: " << endl;
    cin >> rVenta.sFech;
    }
    while(isValid==false);


}

void main()
{       

    ty_venta rVenta;

    bool isValid = isValidDate(rVenta);
    ingreso(rVenta, isValidDate);
}

[Garion]

I don't think you can do void main() (well without other special stuff that isn't for new guys)

I think this is what you are asking for.

#include <iostream>
#include <string>

using namespace std;


bool isValidDate(string a)
{   bool variable;
    if(a == "0"){variable = false;}
    else{variable = true;}
    return variable;
};

int main()
{
    string number_string;
    bool isValid;
    do
    {
    cout << "ingrese fecha del show: " << endl;
    cin >> number_string;
    isValid = isValidDate(number_string);
    }
    while(isValid==false);
}

[Thumper]

Hey there Martin V.
I have a few comments:

Firstly, main() must be of type int and no other type (per the C++ standard).

Secondly, what's the point of having the boolean parameter 'isValid' present at all in the ingreso function? It seems to serve no purpose. What it appears you want to be doing is to check if an inputted date is valid, in which case you should call the isValidDate function as a while loop condition.

do
{
    //...
} while(!isValidDate());

Otherwise the parameter 'isValid' is always going to be either true or false (and will never change) depending on the result of the first call to isValidDate inside of main.

[Martin V]

Thanks a lot Thumper, your response really helped. This is the code that finally worked as expected:

void ingreso(ty_venta & rVenta)  
{

    do
    {
        cout << "ingrese fecha del show: " << endl;
        cin >> rVenta.sFech;
    }while(!isValidDate(rVenta));


}