C++

Forum

 
Problem with hangman game

Jose94ji (63)
Everything works fine, but my question is in line 76 why does the x not increment. I want to make it so that everytime the letter guessed is wrong it will move on to the next hangman pic. Thanks in advance

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
 

 #include <iostream>
 #include <fstream>
#include  <string>
 #include <time.h>



 using namespace std;


 void drawing(int position);
 void guessword(string word);



 int main()
 {
 int number;
 int count = 0;
 int position;
 string word;
 char letter;
 ifstream infile;
 infile.open("square.txt");

 srand(time(NULL)); //initializes the random number generator
 while (count < 1)
 {

 number = rand()%10 +1; // rand returns a random integer from 0 to maxInt
 count++;
 }


 for (count=0;count<number;count++)
 getline (infile, word);


 guessword(word);


 cin.ignore(255,'\n');
 cin.get();
 return 0;
 }




 void guessword(string word)
 {
 char letter;
 int position;

 string blankword[4];
 blankword[0] = "_";
 blankword[1] = "_ ";
 blankword[2] = "_ ";
 blankword[3] = "_ ";





 for (int i=0;i<6;i++)
 {
 cout << "What letter would you like to guess?";
 cin >>letter;

 position = word.find(letter);
 if (position > word.length()){
	 cout<<letter<< " is not in the word "<<endl;
	 int x = 0;

	 drawing(++x);
		 }
 else
 {
 cout<< letter << " is in the word"<<endl;
 if(position==0)
 {
 blankword[0] = letter;
 cout << blankword[0]<<blankword[1]<<blankword[2]<<blankword[3];
 }
 else if(position==1)
 {
 blankword[1] = letter;
 cout<<blankword[0]<<blankword[1]<<blankword[2]<<blankword[3];
 }
 else if(position==2)
 {
 blankword[2] = letter;
 cout<<blankword[0]<<blankword[1]<<blankword[2]<<blankword[3];
 }
 else if (position==3)
 {
 blankword[3] = letter;
 cout<<blankword[0]<<blankword[1]<<blankword[2]<<blankword[3];
 }

 }

 }



 }



 void drawing(int position)
 {

 switch(position)
 {
 case 1:
 cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | " <<endl;
 cout << "_|______________"<<endl;
 position++;
 break;
 case 2:
 cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | \\ " <<endl;
 cout << "_|______________"<<endl;
 break;
 case 3: cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | \\ 0 " <<endl;
 cout << "_|______________"<<endl;
 break;
 case 4:
 cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | \\ 0 /" <<endl;
 cout << "_|______________"<<endl;
 break;
 case 5:
 cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | \\ 0 /" <<endl;
 cout << " | |"<<endl;
 cout << "_|______________"<<endl;
 break;
 case 6:
 cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | \\ 0 /" <<endl;
 cout << " | |"<<endl;
 cout << " | / "<<endl;
 cout << "_|______________"<<endl;
 break;
 case 7:
 cout << " ___________"<<endl;
 cout << " | }"<<endl;
 cout << " | \\ 0 /" <<endl;
 cout << " | |"<<endl;
 cout << " | / \\ "<<endl;
 cout << "_|______________"<<endl;
 }
 }
yulingo (233)
You are trying to increment x in your argument, which causes undefined behavior. Full details here: http://stackoverflow.com/questions/4176328/undefined-behavior-and-sequence-points

The short of it is, if you call ++x and then call drawing(x), you'll be fine.
Topic archived. No new replies allowed.