Problem with the heap

[alex1985]

The program compiles fine, it just gives me an error: Heap Corruption Detected. I appreciate any help.Thanks

#include <iostream>
using namespace std;
class Person
{
	char *name;
	char *surname;	
public:
	Person(char *name,char *surname)
	{
		Person::name=new char[strlen(name)+1];
		Person::surname=new char[strlen(surname)+1];
		strcpy(Person::name,name);
		strcpy(Person::surname,surname);
	}
	Person& operator=(const Person& ob1)
	{
		delete name;
		delete surname;
		name=new char[strlen(ob1.name)+1];
		name=new char[strlen(ob1.surname)+1];
		strcpy(name,ob1.name);
		strcpy(surname,ob1.surname);
		return *this;
	}
	~Person()
	{
		delete name;
		delete surname;
	}
};
int main(int argc,char* arguments[])
{
	Person ob1("john","doe");
	Person ob2("alex","me");	
	ob1=ob2;
}

[Hammurabi]

You need to use the delete[] form of delete. Also, you need to guard against self-assignment in you operator=.

[alex1985]

By self-assignment you are reffering if i wrote ob1=ob1 in main?

[jsmith]

That be what is meant.

[Disch]

I also think that line 20 is supposed to be changing surname, not name

[alex1985]

thanks.Everything is now ok.