Adding Another function

[MathNerd]

Warning 1 warning C4717: 'myStrCat' : recursive on all control paths, function will cause runtime stack overflow

I have the first Portion Correct, but somehow after myStrCat it doesn't compile.

  #include <iostream>
#include <cstring>

using namespace std;

int myStrCopy(char *, const char *);
int myStrCat(char *, const char *);

int main()
{

	char str1[20] = "Hello";
	char str2[20];

	myStrCopy(str2, str1);

	cout << str1;
	cout << endl;
	cout <<"Value of str2 is " << str2 << endl;
}
int myStrCopy(char *str1, const char *str2)
{
	int a = 0;

	while (str2[a] != '\0')
	{
		str1[a] = str2[a];
		a++;
	}
	str1[a] = '\0';
	return 0;
}
int myStrCat(char *, const char *)
{
	const int size = 20;
	char str1[20] = "Hello";
	char str2[20] = "World";

	cout << str1 << endl;
	cout << str2 << endl;
	myStrCat(str1, str2);
	cout << str1 << endl;
	return 0;

}

OutPut for myStrCopy

Hello
Value of str2 is Hello

[MathNerd]

please help

[giblit]

Why do you have line 41 in that function? It will just repeat an unlimited amount of times like the error says. What are you trying to achieve?

*edit
Also there are more returns types than just int. You should probably put void and not return anything since you arne't even using the value that is being returned. Most of the time when you pass by references or pointers and you modify the variables directly you will return void unless you are returning an error code but that doesn't seem to be the case.


Also you forgot to give parameter names on line 33.

[MathNerd]

i have to add another function called myStrCat with this

char str1[20] = "Hello";
char str2[20] = "World";

[D80DSL3A]

The function myStrCat() will be very similar to the myStrCopy() function.
Look at lines 25-30 in myStrCopy

while (str2[a] != '\0')
{
	str1[a] = str2[a];
	a++;
}
str1[a] = '\0';

In myStrCat those lines should be:

while (str2[a] != '\0')
{
	str1[a+len1] = str2[a];
	a++;
}
str1[a+len1] = '\0';

Where len1 is the length of str1 before concatenation. A myStrLen() function would be handy for finding len1.

[MathNerd]

im still getting the same output. I know im doing something wrong but i cant seem to figure it out

[eyenrique]

Allows private messages in your account settings, i can send to you an explanation of a similar exercise.

[MathNerd]

i enabled pm