Why does this code not work?

[Ch1156]

Ok so in my program it's supposed to load names from a file and i wanted to make soem error handling in case the file was empy or missing so i did, however the if statement for checking if the file is empty doesnt seem to be working, when i run my program the cmd box displays really strange symbols and starts beeping, so what am i doing wrong?

void GetCustomerNames(Player &player, Weapon &weapon, Customer &customer)
{
    ifstream loadCustomerNames;
    string tempNameStorage;
    string nameSize;

    loadCustomerNames.open("customer names.txt");

    if(loadCustomerNames.fail())
    {
        cout << "There was an error loading the customer names" << endl;
    }
    else if(!loadCustomerNames.fail())
    {
        for(int i = 0; i < 3; i++)
        {
            getline(loadCustomerNames, tempNameStorage);
            if(tempNameStorage.empty())
            {
                cout << "Error file was empty" << endl;
            }
            else if(!tempNameStorage.empty())
            {
                customer.customerName.push_back(tempNameStorage);
            }

        }

        for(int i = 0; i < 3; i++)
        {
            cout << customer.customerName[i] << endl;;
        }
    }
}

[LB]

Are you sure "customer names.txt" is really a plain text file? You didn't save it with Word, did you? Open it in Notepad to be sure it really is plain text.

[Ch1156]

im 110% sure its a plain text file

[xismn]

Let's see the file then, or part of it anyways.
Also, doesn't this seem a bit silly?
Line 9: if(loadCustomerNames.fail())
...
Line 13: else if(!loadCustomerNames.fail())
Same goes for lines 18 and 22.

[Ch1156]

the file is empty, theres nothin in it to see.

[LB]

That's your problem - the .fail() state is only set when you try to actually read something, not when you just open a blank file or read the last byte.

[Ch1156]

Ok so i did this, is this better? It works anyways

void GetCustomerNames(Player &player, Weapon &weapon, Customer &customer)
{
    ifstream loadCustomerNames;
    string tempNameStorage;
    string nameSize;

    loadCustomerNames.open("customer names.txt");

    //If the file is missing then execute this code

    if(loadCustomerNames.fail())
    {
        cout << "There was an error loading the customer names" << endl;
    }
    else
    {
        getline(loadCustomerNames, tempNameStorage);

        if(tempNameStorage.empty())
        {
            cout << "Error file was empty, cannot proceed." << endl;
        }
        else
        {
            for(int i = 0; i < 3; i++)
            {
                customer.customerName.push_back(tempNameStorage);
            }

            for(int i = 0; i < 3; i++)
            {
                cout << customer.customerName[i] << endl;;
            }
        }
    }
}