Program ends unexpectedly

[Lief Webster]

I'm making a grammar-based program for school. This is just the beginning of it, but once it reaches the function 'AskQuestion()' it just stops and the program terminates once you hit enter. What do I need to do to make it execute the 'AskQuestion()' function? (That would be at line 302 I think.)

/* PROJECT: Excelcior 2.0 */

#include <iostream>
#include <string>
#include <vector>
#include <ctime>
#include <cstdlib>
#include <algorithm>

using namespace std;

/* Global variables because I don't want to mess with local variables */

vector<string> Nouns, Verbs, Adjectives, Adverbs;
string ans1;

/* Function prototypes */

/* FillVectors also randomizes the vectors */
void FillVectors();

/* Set up the question and display it */
void AskQuestion();

bool CheckAns( char, string );

void WelcomeScreen( char );

/* Main function */
int main()
{
	WelcomeScreen( 1 );

	cin.get();
	return 0;
}

/* Function Definitions */

void FillVectors()
{
	/* Assign nouns */

    Nouns.push_back( "wombat" );
	Nouns.push_back( "monk" );
	Nouns.push_back( "vestry" );
	Nouns.push_back( "website" );
	Nouns.push_back( "whistles" );
	Nouns.push_back( "thistles" );
	Nouns.push_back( "roustabout" );
	Nouns.push_back( "otter" );
	Nouns.push_back( "zombie-flower" );
	Nouns.push_back( "jello" );

	/* Assign verbs */

	Verbs.push_back( "entwine" );
	Verbs.push_back( "shiver" );
	Verbs.push_back( "carve" );
	Verbs.push_back( "render" );
	Verbs.push_back( "divest" );
	Verbs.push_back( "ramble" );
	Verbs.push_back( "snipped" );
	Verbs.push_back( "snapped" );
	Verbs.push_back( "disappear" );
	Verbs.push_back( "reclaim" );

	/* Assign adjectives */

	Adjectives.push_back( "arduous" );
	Adjectives.push_back( "belated" );
	Adjectives.push_back( "threadbare" );
	Adjectives.push_back( "limber" );
	Adjectives.push_back( "akimbo" );
	Adjectives.push_back( "indolent" );
	Adjectives.push_back( "crooked" );
	Adjectives.push_back( "unparalleled" );
	Adjectives.push_back( "sprightly" );
	Adjectives.push_back( "nappy" );
	Adjectives.push_back( "magenta" );

	/* Assign adverbs */

	Adverbs.push_back( "chivalrously" );
	Adverbs.push_back( "strangely" );
	Adverbs.push_back( "ominously" );
	Adverbs.push_back( "genetically" );
	Adverbs.push_back( "comfortably" );
	Adverbs.push_back( "perfectly" );
	Adverbs.push_back( "transparently" );
	Adverbs.push_back( "superficially" );
	Adverbs.push_back( "jovially" );
	Adverbs.push_back( "deciduously" );

	/* Randomize each vector */

	random_shuffle( Nouns.begin(), Nouns.end() );
	random_shuffle( Verbs.begin(), Verbs.end() );
	random_shuffle( Adjectives.begin(), Adjectives.end() );
	random_shuffle( Adverbs.begin(), Adverbs.end() );
}

void AskQuestion()
{
    vector<string> temp;

    /* Select the first value from each already-randomized vector */
    /* and add it to the temp vector, from which the question will */
    /* be formed. */

    temp.push_back( Nouns[0] );
    temp.push_back( Verbs[0] );
    temp.push_back( Adjectives[0] );
    temp.push_back( Adverbs[0] );
    
    /* Shuffle the temp; i.e. the possible answers to the question */

    random_shuffle( temp.begin(), temp.end() );

    /* Choose which part of speech to ask for */
    
    char tchar = ( rand() % 4 ) + 1;

    switch( tchar )
    {
        case '1':
        cout << "Identify the noun from the choices below. \n\t(Enter the correct answer.)" << endl;
        cout << "\t" << temp[0] << endl;
        cout << "\t" << temp[1] << endl;
        cout << "\t" << temp[2] << endl;
        cout << "\t" << temp[3] << endl << endl;

        cin >> ans1;

        if( CheckAns( 1, ans1 ) == true )
        {
            cout << "\n\n\tCorrect!" << endl;
        }

        else
        {
            cout << "\n\n\tIncorrect." << endl;
        }

        break;

        case '2':
        cout << "Identify the verb from the choices below. \n\t(Enter the correct answer.)" << endl;
        cout << "\t" << temp[0] << endl;
        cout << "\t" << temp[1] << endl;
        cout << "\t" << temp[2] << endl;
        cout << "\t" << temp[3] << endl << endl;

        cin >> ans1;

        if( CheckAns( 2, ans1 ) == true )
        {
            cout << "\n\n\tCorrect!" << endl;
        }

        else
        {
            cout << "\n\n\tIncorrect." << endl;
        }

        break;

        case '3':
        cout << "Identify the adjective from the choices below. \n\n\t(Enter the correct answer.)" << endl;
        cout << "\t" << temp[0] << endl;
        cout << "\t" << temp[1] << endl;
        cout << "\t" << temp[2] << endl;
        cout << "\t" << temp[3] << endl << endl;

        cin >> ans1;

        if( CheckAns( 3, ans1 ) == true )
        {
            cout << "\n\n\tCorrect!" << endl;
        }

        else
        {
            cout << "\n\n\tIncorrect." << endl;
        }

        break;

        case '4':
        cout << "Identify the adverb from the choices below. \n\n\t(Enter the correct answer.)" << endl;
        cout << "\t" << temp[0] << endl;
        cout << "\t" << temp[1] << endl;
        cout << "\t" << temp[2] << endl;
        cout << "\t" << temp[3] << endl << endl;

        cin >> ans1;

        if( CheckAns( 4, ans1 ) == true )
        {
            cout << "\n\n\tCorrect!" << endl;
        }

        else
        {
            cout << "\n\n\tIncorrect." << endl;
        }

        break;
    }

    /* Finish up the function */
}

bool CheckAns( char choice, string answer )
{
    if( choice == '1' )
    {
		if( ( find( Nouns.begin(), Nouns.end(), answer ) ) == Nouns.end() )
        {
            return( false );
        }
    }

    else if( choice == '2' )
    {
        if( ( find( Verbs.begin(), Verbs.end(), answer ) ) == Verbs.end() )
        {
            return( false );
        }
    }

    else if( choice == '3' )
    {
        if( ( find( Adjectives.begin(), Adjectives.end(), answer ) ) == Adjectives.end() )
        {
            return( false );
        }
    }

    else if( choice == '4' )
    {
        if( ( find( Adverbs.begin(), Adverbs.end(), answer ) ) == Adjectives.end() )
        {
            return( false );
        }
    }

    else
    {
        return( false );
    }

    return( true );
}

void WelcomeScreen( char count = 1 )
{
	string temp1;

    cout << "*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-" << endl;
	cout << "   Welcome to GRAMMAR EXCELCIOR 2.0" << endl;
	cout << "*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-" << endl;

	cout << "\n\t[Press enter to continue]" << endl;
	cin.get();

	cout << "\n\tInstructions:" << endl;
	cout << "\t----------------------------" << endl;
	cout << "\t You will be asked to identify a certain part of speech" << endl;
	cout << "\t from a list of four words. Please enter your answer in" << endl;
	cout << "\t lowercase, just as it is shown to you." << endl;
	cout << "\n\t [Press enter to continue]" << endl;
	cin.get();

	cout << "\n\tFor example..." << endl;

	do{
		cout << "\n\t Identify the verb from the choices below." << endl;
		cout << "\n\t\tblubber" << endl;
		cout << "\n\t\tovertly" << endl;
		cout << "\n\t\tbluish-gray" << endl;
		cout << "\n\t\tsprint\n\t";

		cin >> temp1;

		if( temp1 == "sprint" )
			break;
		else
			cout << "\n\t 'Fraid not. Try again." << endl;
	} while( temp1 != "sprint" );

	cout << "\n\tGood job. Now it's time for the real game. (You get points.)" << endl;
	cout << "\n\t[Press enter to continue]" << endl;
	cin.get();

	FillVectors();

	cout << "\n\t--------------------" << endl;
	cout << "\n\t  Question " << count << endl;
	cout << "\n\t--------------------" << endl;

	AskQuestion();
}

[Hammurabi]

Your main problem is that you're assigning tchar a numeric value, but then testing it against a character value in the switch. Remove the single quotes around the numbers in the case statements. Do the same for the conditions of the ifs in CheckAns.

BTW, Excelsior is spelled with an "s". And in the first example, both "blubber" and "sprint" can be both nouns or verbs. And you have some overly long lines; split them. And you use endl when a simple \n within the string will do. And you're using chars as ints for no good reason. And you're using C-style (multi-line) comments for single line comments. And AskQuestion has a lot of repetition that could easily be removed. And:

/* Global variables because I don't want to mess with local variables */

I guess that's okay, as long as you're not planning to ever become a real programmer.

[Tevsky]

Another problem you will run into is that you aren't seeding your random number function. Add this line before you generate your random number.

srand( static_cast<unsigned>( time( 0 ) ) );

Even with this though, don't get too used to generating random numbers this way, it's the poor man's way.

[helios]

/* Global variables because I don't want to mess with local variables */

............................................________
....................................,.-‘”...................``~.,
.............................,.-”...................................“-.,
.........................,/...............................................”:,
.....................,?......................................................\,
.................../...........................................................,}
................./......................................................,:`^`..}
.............../...................................................,:”........./
..............?.....__.........................................:`.........../
............./__.(.....“~-,_..............................,:`........../
.........../(_....”~,_........“~,_....................,:`........_/
..........{.._$;_......”=,_.......“-,_.......,.-~-,},.~”;/....}
...........((.....*~_.......”=-._......“;,,./`..../”............../
...,,,___.\`~,......“~.,....................`.....}............../
............(....`=-,,.......`........................(......;_,,-”
............/.`~,......`-...............................\....../\
.............\`~.*-,.....................................|,./.....\,__
,,_..........}.>-._\...................................|..............`=~-,
.....`=~-,_\_......`\,.................................\
...................`=~-,,.\,...............................\
................................`:,,...........................`\..............__
.....................................`=-,...................,%`>--==``
........................................_\..........._,-%.......`\
...................................,<`.._|_,-&``................`\

[firedraco]

Even with this though, don't get too used to generating random numbers this way, it's the poor man's way.

Um, what? The only thing it isn't good enough for is cryptography, in which case you would be using something like boost's random generator for it.

[Tevsky]

Um, what? The only thing it isn't good enough for is cryptography, in which case you would be using something like boost's random generator for it.

I'm just saying that the numbers that you get from this approach are far from random. You can do things without using boost that would improve the "randomness" of your number generation that aren't even that complicated, a few lines. I know for this kind of stuff, it wouldn't matter, maybe I'm just picky.

[Hammurabi]

Facepalm! LOL!