Vector problem

[Tripic]

ok the problem i have is in the game function at the bottom. the program is suppised to open a file parse it and then ask each player in the playerID vector each question. the problem is after the first question i get a assertion failed subscript out of range error. any ideas what the hell it might be.

		#include <iostream>
		#include <fstream>
		#include <string>
		#include <stdlib.h>
		#include <vector>
		using namespace std;
		ifstream fIn;
		ifstream Gamefile;
		ofstream fOut;
		int menu();
		int Clist ();
		int menuOpt;
		void game ();
		vector<string> fileName;
		int main()
		{
		menu();
		}
		int menu()
		{
		char inp;

		do
		{
		cout << "Please chose from the following options" <<endl;
		cout << "A: Load Trivia type." <<endl;
		cout << "B: Start Game." <<endl;
		cout << "C: Exit Game" <<endl;
		cin >> inp;
		string bt;	

		switch(inp)
		{
		case 'A': case 'a':	
			Clist();	
			break;
		case 'B': case 'b': 
			game();
			break;
		case 'C': case 'c':
			return 0;
			break;
		default:
			cout << "error that is not an option\n Press enter to continue " << endl;
			cin.get();
			cin.get();
			system("cls");
			break;
		}}while(inp != 'c');
		}



		int Clist()
		{	
			vector<string> triviaName;
			string input;
			int a, b, c, d;
			fIn.open("list.csv");
		    a = 0;
			while(!fIn.eof())
			{
			
			getline( fIn, input, ',' );
			triviaName.push_back(input);
			getline( fIn, input);
			fileName.push_back(input);
			a++;
			fileName.resize(a);
			triviaName.resize(a);
				}
			c = 0;
			for(b = 1; b < a; b++)
			{
				
				cout << "option# "<< c << ": " << triviaName[c] << endl;
				c++;
			}
			cout << "Please Enter your option: ";
			cin >> d;

			fIn.close();
			fIn.clear();
		  system("cls");
		  return d;

		}

//Problem Should be in this function.
           void game()
		{   vector<string> PlayerID;
			string input;
			int PlayerNumber, counter, PlayerCount, GamePlay, vectorSize, vectorCounter, a;
			
			cout << "	How many Players will be playing? ";
			cin >> counter;
			cout << endl;
			PlayerCount = 0;
			for (PlayerNumber = 1; PlayerNumber <= counter; PlayerNumber++)
			{
				system("cls");
				cout << "	Please enter name for player " << PlayerNumber << endl;
				cin >> input;
				PlayerID.push_back(input);
				PlayerCount++;
				PlayerID.resize(PlayerCount);
			}


			GamePlay = Clist();
			//decla ration for vectors that will parce the game csv file
			vector<string> question;
			vector<string> Awns_A;
			vector<string> Awns_B;
			vector<string> Awns_C;
			vector<string> Awns_Correct;
			Gamefile.open(fileName[GamePlay].c_str());

			vectorSize = 1;
			while(!Gamefile.eof())
			{
			
			getline( Gamefile, input, ',' );
			question.push_back(input);
			getline( Gamefile, input, ',' );
			Awns_A.push_back(input);
			getline( Gamefile, input, ',' );
			Awns_B.push_back(input);
			getline( Gamefile, input, ',' );
			Awns_C.push_back(input);
			getline( Gamefile, input);
			Awns_Correct.push_back(input);
			vectorSize++;
			question.resize(vectorSize);
			Awns_A.resize(vectorSize);
			Awns_B.resize(vectorSize);
			Awns_C.resize(vectorSize);
			Awns_Correct.resize(vectorSize);
				}
            Gamefile.close();
			Gamefile.clear();
			vectorCounter = 0;
/*this will need to be put in a nested loop to give each player a chance  respond to the question*/
			for (PlayerNumber = 0; PlayerNumber <= PlayerCount; PlayerNumber++)
			{
				cout << PlayerID[PlayerNumber] << endl
					 << question[vectorCounter] << endl
					 << "	Option A:" << Awns_A[vectorCounter] << endl
					 << "	Option B:" << Awns_B[vectorCounter] << endl
					 << "	Option C:" << Awns_C[vectorCounter] << endl;
				cin.get();
				cin.get();
				

				PlayerCount++;
				}
				
			
		}

[kbw]

What's the input file?

BTW, if you find yourself with code like:

vector<string> question;
vector<string> Awns_A;
vector<string> Awns_B;
vector<string> Awns_C;
vector<string> Awns_Correct;

you probably need a collection of records, rather than many collections of fields.

[Tripic]

ok this is the list .csv file

_{Movie Trivia,movie.csv
Sports Trivia,sports.csv
Music Trivia,music.csv
Science Trivia,Science.csv}

As you can see it just gives the trivia type and then the file the questions are stored in.

and this one is movie.csv just as an example

_{Who stared in Predator 1?,Andrew Jackson,Bob Weaver,Arnold Scwarzadinger,C
What Type of Movie was AppleSeed?,Action,Annimation,forien,B
Who Makes the Best Trivia About Movies?,JohnDoe,Bob Home,Me,C}

this one is set
Question , Awns_A , Awns_B, Awns_C, AwnsCorrect

[Tripic]

"you probably need a collection of records, rather than many collections of fields" Keep in mind im new to programming but what do you mean

[kbw]

A suitable record might look like:

struct QAEntry
{
    std::string question;
    std::string a;
    std::string b;
    std::string c;
    std::string correct;
};

You could then keep all the information together all the time.

typedef std::vector<QAEntry> QAEntries;

As for reading each line, I'd read the whole line, then parse the components, and move the whole mess out to a separate function.

void ReadEntry(QAEntries &items, const std::string &line)
{
    QAEntry item;
    // find ?
    // copy from beginning to ? into item.question
    // do the other fields ...

    items.push_back(item);
}

I don't want to write the whole thing for you, but I hope this helps.

[Tripic]

I will have to try that

for (PlayerNumber = 0; PlayerNumber <= PlayerCount; PlayerNumber++)
			{
				cout << PlayerID[PlayerNumber] << endl
					 << question[vectorCounter] << endl
					 << "	Option A:" << Awns_A[vectorCounter] << endl
					 << "	Option B:" << Awns_B[vectorCounter] << endl
					 << "	Option C:" << Awns_C[vectorCounter] << endl;
				cin.get();
				cin.get();
				

				PlayerCount++;// Found the problem child
				}