Baseball Program

oh god whats wrong

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
#include <iostream>
using namespace std;

int firstInning();
int nextInning();

int firstInning()
{
     cout<<"\n\n****** Visitor Team now at Bat Home Team in the Field ********\n\n";
   
    int batter = 1, outs = 0, balls = 0, strikes = 0 , runs = 0, hits = 0;
    char call, choice;
    
    do 
    {

    
    cout<<"Inning Status   Batter # "<<batter;
    cout<<"     # Balls "<<balls<<" # Strikes "<<strikes<<" # Outs "<<outs<<" # Runs "<<runs;
    cout<<"\n1st Batter (Count of 1): ";
    cin>>call;
             if ((call == 'S')||(call == 's'))
             {
                strikes += 1;
             
                if (strikes == 3)
                {
                   batter += 1;
                   outs += 1;
                   strikes = 0;
                   if (outs == 3)
                   {
                      cout<<"                          Three Outs !!!";
                      cout<<"\n\nIs there another half inning (Y/N) ";
                      cin>>choice;
                      if ((choice == 'Y')||(choice == 'y'))
                      {
                                  nextInning();
                      }
                   }
                }
             }
             
             else if ((call == 'B')||(call == 'b'))
             {
                balls +=1;
                if ( balls == 4)
                {
                     batter += 1; 
                     balls = 0;
                }
             }
             
             else if ((call == 'F')||(call = 'f')&&(strikes > 2))
             {
                strikes += 1;
             }
             
             else if ((call == 'F')||(call = 'f')&&(strikes = 2))
             {
                strikes = 2;
             }
                           

                
             else if ((call == 'H')||(call == 'h'))
             {
                batter += 1;
                balls = 0;
                strikes = 0;
             }
             
             else if ((call == 'O')||(call = 'o'))
                {
                      outs += 1;
                      if (outs == 3)
                      {
                      cout<<"                          Three Outs !!!";
                      cout<<"\n\nIs there another half inning (Y/N) ";
                      cin>>choice;
                      if ((choice == 'Y')||(choice == 'y'))
                      {
                                  nextInning();
                      }
                      }
                }
                
             else if ((call == 'R')||(call == 'r'))
                runs += 1;
             else 
             cout<<"******** Invaled Please enter S,B,F,G,H,O or R";


    }
    while (outs < 3);  
}

int nextInning()
{
     cout<<"\n\n****** Home Team now at Bat Visitor Team in the Field ********\n\n";
   
    int batter = 1, outs = 0, balls = 0, strikes = 0 , runs = 0, hits = 0;
    char call, choice;
    
    do 
    {

    
    cout<<"Inning Status   Batter # "<<batter;
    cout<<"     # Balls "<<balls<<" # Strikes "<<strikes<<" # Outs "<<outs<<" # Runs "<<runs;
    cout<<"\n1st Batter (Count of 1): ";
    cin>>call;
             if ((call == 'S')||(call == 's'))
             {
                strikes += 1;
             
                if (strikes == 3)
                {
                   batter += 1;
                   outs += 1;
                   strikes = 0;
                   if (outs == 3)
                   {
                      cout<<"                          Three Outs !!!";
                      cout<<"\n\nIs there another half inning (Y/N) ";
                      cin>>choice;
                      if ((choice == 'Y')||(choice == 'y'))
                      {
                                  firstInning();
                      }
                   }
                }
             }
             
             else if ((call == 'B')||(call == 'b'))
             {
                balls +=1;
                if ( balls == 4)
                {
                     batter += 1; 
                     balls = 0;
                }
             }
             
             else if ((call == 'F')||(call = 'f')&&(strikes > 2))
             {
                strikes += 1;
             }
             
             else if ((call == 'F')||(call = 'f')&&(strikes = 2))
             {
                strikes = 2;
             }
                          
                    
                
             else if ((call == 'H')||(call == 'h'))
             {
                batter += 1;
                balls =0;
                strikes = 0;
                
             }
             
             else if ((call == 'O')||(call = 'o'))
                {
                      outs += 1;
                      if (outs == 3)
                      {
                      cout<<"                          Three Outs !!!";
                      cout<<"/n\nIs there another half inning (Y/N) ";
                      cin>>choice;
                      if ((choice == 'Y')||(choice == 'y'))
                      {
                                  firstInning();
                      }
                      }
                }
                
             else if ((call == 'R')||(call == 'r'))
                runs += 1;
             else 
             cout<<"******** Invaled Please enter S,B,F,G,H,O or R";

    }
    while (outs < 3);  
}
    



int main()
{

    
    cout<<"Boy's of Summer 2013\n";
    cout<<"Umpire's Assistant At Your Service";
    cout<<"\n\nThe Item Codes are as follows: ";
    cout<<"\nCode Description   Code Description";
    cout<<"\nS        Strike           H     Hit";
    cout<<"\nB        Ball             O     Out";
    cout<<"\nF        Foul Ball        R     Run in";
    cout<<"\nG        Game Canceled";
    
    firstInning();
    
                
    
    
cin.get();
cin.get();
return 0;
}
How do you know it's wrong?
Have you ever tried using the "switch" method instead of using else-ifs so much?

It would make your code much clearer.
Topic archived. No new replies allowed.