C++

Forum

 
ofstream not writing all variables

undeadsoldier (16)
Hello all.
I have this code here that is supposed to save all the values in a file, and it does that in vSave().
Also, you can load the values with vLoad().
vSave works just fine.
But when i try to load it via vLoad, it only loads the first couple variables, and I have no idea why.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
 
void vLoad()
{
    int woot = 0;
    int iLoopcount = 0;
    ifstream fileStream("save.dat", ios_base::binary);
    while(woot == 0)
    {
        iLoopcount++;
        if(iLoopcount == 1)
        {
            string tempName;
            fileStream >> tempName;
            int templength = tempName.length();
            tempName.copy(cName, templength);
            cout << "\nWelcome back, " << tempName;
            saveName = tempName;
            continue;
        }
        if(iLoopcount == 2)
        {
            fileStream >> aMap;
            continue;
        }
        if(iLoopcount == 3)
        {
            fileStream >> bAdmin;
            continue;
        }
        if(iLoopcount == 4)
        {
            fileStream >> bLabKey;
            continue;
        }
        if(iLoopcount == 5)
        {
            fileStream >> bGasmask;
            continue;
        }
        if(iLoopcount == 6)
        {
            fileStream >> bMaskOn;
            continue;
        }
        if(iLoopcount == 7)
        {
            fileStream >> bHazsuit;
            continue;

        if(iLoopcount == 8)
        {
            fileStream >> bWearingHazsuit;
            continue;

        }
        if(iLoopcount == 9)
        {
            fileStream >> bNote;
            continue;
        }
        if(iLoopcount == 10)
        {
            fileStream >> bNoteread;
            continue;
        }
        if(iLoopcount == 11)
        {
            fileStream >> bSearchEnabled;
            continue;
        }
        if(iLoopcount == 12)
        {
            fileStream >> bHasgun;
            continue;
        }
        if(iLoopcount == 13)
        {
            fileStream >> bGatelocked;
            continue;
        }
        if(iLoopcount == 14)
        {
            fileStream >> iBulletcount;
            continue;
        }
        else
        {
            break;
        }
    }
    fChoice();
}
}
void vSave()
{
    ofstream sv("save.dat");
    sv << saveName << endl;
    sv << aMap << endl
       << bAdmin << endl
       << bLabKey << endl
       << bGasmask << endl
       << bMaskOn << endl
       << bHazsuit << endl
       << bWearingHazsuit << endl
       << bNote << endl
       << bNoteread << endl
       << bSearchEnabled << endl
       << bHasgun << endl
       << bGatelocked << endl
       << iBulletcount << endl;
    cout << "\nSave Succesful\n";
    fChoice();
}
ats15 (423)
There are several things I would point out are not so nice:
1.Is your save.dat a binary file? My guess is that is an ascii file. You input aMap, than an endl. Then you read aMap, then bAdmin. In a binary file, you need to account for the endl as well.
2.I don't understand the logic of the while loop. Why do you need it?
3. It seems to me that saveName, aMap, badmin, and so on are global variables. That is a bad habit. Try not to use global variables unless you really need to.
undeadsoldier (16)
Ah I fixed it.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
 
void vLoad()
{
    ifstream fileStream("save.dat", ios_base::binary);
    fileStream >> saveName;
    int tempInt = saveName.length();
    saveName.copy(cName, tempInt);
    fileStream >> aMap;
    fileStream >> bAdmin;
    fileStream >> bLabKey;
    fileStream >> bGasmask;
    fileStream >> bMaskOn;
    fileStream >> bHazsuit;
    fileStream >> bWearingHazsuit;
    fileStream >> bNote;
    fileStream >> bNoteread;
    fileStream >> bSearchEnabled;
    fileStream >> bHasgun;
    fileStream >> bGatelocked;
    fileStream >> iBulletcount;
    fileStream >> bGotoEnabled;
    fileStream >> bCarssearched;
    fileStream >> bReceptionistgone;
    cout << "\nLoad Successful\nWelcome back, " << saveName << endl;
    fChoice();
}
void vSave()
{
    ofstream sv("save.dat");
    sv << saveName << endl;
    sv << aMap << endl
       << bAdmin << endl
       << bLabKey << endl
       << bGasmask << endl
       << bMaskOn << endl
       << bHazsuit << endl
       << bWearingHazsuit << endl
       << bNote << endl
       << bNoteread << endl
       << bSearchEnabled << endl
       << bHasgun << endl
       << bGatelocked << endl
       << iBulletcount << endl
       << bGotoEnabled << endl
       << bCarssearched << endl
       << bReceptionistgone << endl;
    cout << "\nSave Succesful\n";
    fChoice();
}

the loop was just a long way of doing this.
I just dont understand why the old one didnt work. Oh well.
Also, why is it bad practice to use global variables? Im not writing anything tat anyone else will use(probably)
Topic archived. No new replies allowed.