Problem with do-while

[tes4evr]

Hi iam new with c++ i started 2 days ago and in order to learn some basic stuff i decided to make a text game.
My problem is that at (He>0 or Hp>0) the program only uses the one i give the larger value in order to end the loop, the other can go negative and the program will still continue.

 #include <cstdlib>
#include <iostream>
#include <ctime>
using namespace std;

void combat()
{
    char x;
    int Hp=20;
    int He=20;
    srand((unsigned)time(0));
   do
    {cout <<"what is your action??"<< endl;
     cout <<"[A]ttack" << endl;
     cin >> x;
     if (x == 'A')
     {cout << "you attack!"<< endl;
     int Ap=(rand()%10)+1;
     cout <<"You inflict "<< Ap<<" dmg"<< endl;
     He -= Ap;
     cout <<"Enemy has "<< He<<" Hit points"<< endl;}
     cout <<"enemy attacks!"<< endl;
    int e=(rand()%10)+1;
    cout <<"enemy inflicts "<< e <<" damage" << endl;
    Hp -= e;
    cout << "your current HP is " << Hp<< endl;
    }while (He>0 or Hp>0);
}



int main()
{
combat();
}

[Dy7SLyTq]

make it an and

[tes4evr]

Thank you very much it works!
Question though doesnt 'and' mean both of them have to be true, in this case doesnt it mean both 'Hp' and 'He' have to become 0 or less in order to end the loop?

[Dy7SLyTq]

yes

[tes4evr]

Im confused when i run the program only one of them have to become 0 or less with 'and' in order to end the loop (thats what i wanted though thanks again!).

[MikeyBoy]

Question though doesnt 'and' mean both of them have to be true, in this case doesnt it mean both 'Hp' and 'He' have to become 0 or less in order to end the loop?

No. It means both conditions have to be true for the loop to keep looping.

If either one of those conditions stops being true, then your loop condition (He>0 or Hp>0) stops being true, and the loop will stop looping.

[Dy7SLyTq]

he said and not or so he is actually right

[MikeyBoy]

Sure. For an "and" condition to be true, both the conditions need to be true.

The problem with the statement was to do with what happens to the loop when the condition is true, and what happens when it's false. That's what I was correcting.

[Dy7SLyTq]

sorry got confused cause u referenced the and statement so i thought you were talking about that

[tes4evr]

thank you both :)

[MikeyBoy]

You're welcome :)