Dividing user input into strings

[DrZoidberg]

I'm trying to save the words of a sentence that is entered by the user in different strings. The problem is that I have no idea how to write that a space marks the beginning of a new word. Would appreciate any help or suggestions.

[vlad from moscow]

#include <iostream>
#include <string>
#include <vector>
#include <sstream>
#include <algorithm>
#include <iterator>

int main()
{
   std::cout << "Enter a sentence: ";

   std::string s;
   std::getline( std::cin, s );

   std::istringstream is( s );

   std::vector<std::string> v;

   std::copy( std::istream_iterator<std::string>( is ),
                   std::istream_iterator<std::string>(),
                   std::back_inserter( v ) );

   for ( std::string word : v ) std::cout << word << std::endl;
}

EDIT: I updated the code.

[Smac89]

http://www.cplusplus.com/reference/cstring/strtok/

[Duthomhas]

Please don't tell people to use strtok(). The function has serious limitations and almost no one (even among experienced programmers) knows how to use it properly.

[Smac89]

Whatever the limitations might be, I'm sure the extent of OP's problem does not uncover those limitation. And how do you know that almost no one uses this function?

[Lowest0ne]

@ vlad: you can construct the vector with the istream_iterators instead of using copy.

[Duthomhas]

I love it when some snot starts making wild statements.

If you understood strtok(), you would know that the OP (and every other beginner who has ever touched it) will almost certainly "uncover those limitation".

Forums all over the internet for three generations are filled with posts about how to make strtok() behave.

Also, be careful how you represent me. I didn't say "almost no one uses it". I said "almost no one knows how to use it properly."

The fact is that it is a dangerous function. So much so that I've written an entire FAQ on it:
http://www.cplusplus.com/faq/sequences/strings/strtok/

I know you won't bother to click the link, so, in a nutshell:

  - it is not reentrant!
  - it modifies its argument

Heck, its very manpage warns you to "be cautious when using [it]".


So, please don't tell people to use strtok().

There are plenty of safer alternatives.
http://www.cplusplus.com/faq/sequences/strings/split/

[vlad from moscow]

@LowestOne

@ vlad: you can construct the vector with the istream_iterators instead of using copy.

You are right. It would be simpler to write

std::vector<std::string> v( std::istream_iterator<std::string>( is ),
                            std::istream_iterator<std::string>() );

The same task can be done in several ways in C++.:)

[Cubbi]

That's a function declaration, make it at least

std::vector<std::string> v{ std::istream_iterator<std::string>( is ),
                            std::istream_iterator<std::string>() };

[vlad from moscow]

@Cubbi

That's a function declaration, make it at least

 std::vector<std::string> v{ std::istream_iterator<std::string>( is ),
                             std::istream_iterator<std::string>() };

You meant to make it for example as

 std::vector<std::string> v{ ( std::istream_iterator<std::string>( is ) ),
                             std::istream_iterator<std::string>() };

[Cubbi]

No, that's just silly (combining two different ways to avoid MVP)

[vlad from moscow]

Ah, I have not seen that you are using braces instead of parentheses.:)

[Smac89]

Ok @Douas you're right

[Duthomhas]

Sorry I was grouchy with you.