Player Efficiency Rating program problem

[hashtag include]

I'm currently trying to write a program to find an NBA players PER. Whenever I try to get the players different stats, the program won't let me input any information.

  #include <iostream>
using namespace std;

int main()
{

	string player[50];
	float uPER, MP, threeP, AST, factor, teamAST, teamFG, FG, FT, VOP, TOV, DRB, FGA, FTA, TRB, ORB, STL, BLK, PF, lgFT, lgPF, lgFTA, lgAST, lgFG, lgPTS, lgFGA, lgORB, lgTOV, lgTRB;

	cout << "This program calculates NBA players PER, or Player Efficiency Rating." << endl;
	cout << "Player's name? ";
	cin >> player[50];

	cout << "Enter " << player[50] << " per game stats when prompted." << endl;

	cout << "Minutes Played: ";
	cin >> MP;
	cout << endl;

	cout << "Three Pointers: ";
	cin >> threeP;
	cout << endl;

	cout << "Assists: ";
	cin >> AST;
	cout << endl;

	cout << "Team Assists: ";
	cin >> teamAST;
	cout << endl;

	cout << "Team Field Goals: ";
	cin >> teamFG;
	cout << endl;

	cout << "Field Goals: ";
	cin >> FG;
	cout << endl;

	cout << "Free Throws: ";
	cin >> FT;
	cout << endl;

	cout << "Turnovers: ";
	cin >> TOV;
	cout << endl;

	cout << "Field Goals Attempted: ";
	cin >> FGA;
	cout << endl;

	cout << "Free Throws Attempted: ";
	cin >> FTA;
	cout << endl;

	cout << "Total Rebounds: ";
	cin >> TRB;
	cout << endl;

	cout << "Offensive Rebounds: ";
	cin >> ORB;
	cout << endl;

	cout << "Steals: ";
	cin >> STL;
	cout << endl;

	cout << "BLocks: ";
	cin >> BLK;
	cout << endl;

	cout << "Personal Fouls: ";
	cin >> PF;
	cout << endl;

	cout << "League Average for the next stats.";
	cout << endl;

	cout << "Free Throws: ";
	cin >> lgFT;
	cout << endl;

	cout << "Personal Fouls: ";
	cin >> lgPF;
	cout << endl;

	cout << "Free Throws Attempted: ";
	cin >> lgFTA;
	cout << endl;

	cout << "Assists: ";
	cin >> lgAST;
	cout << endl;

	cout << "Field Goals: ";
	cin >> lgFG;
	cout << endl;

	cout << "Points: ";
	cin >> lgPTS;
	cout << endl;

	cout << "Field Goals Attempted: ";
	cin >> lgFGA;
	cout << endl;

	cout << "Offensive Rebounds: ";
	cin >> lgORB;
	cout << endl;

	cout << "Turnovers: ";
	cin >> lgTOV;
	cout << endl;

	cout << "Total Rebounds: ";
	cin >> lgTRB;
	cout << endl;

	factor = (2 / 3) - (0.5 * (lgAST / lgFG)) / (2 * (lgFG / lgFT));

	VOP    = lgPTS / (lgFGA - lgORB + lgTOV + 0.44 * lgFTA);

	DRB   = (lgTRB - lgORB) / lgTRB;

	cout << factor << " , " << VOP << " , " << DRB;
}

[giblit]

I'm not sure why you have an array of strings. I think you meant to do an array of chars or even just a string(which I would suggest.) Also arrays start at index 0 so the last element would be 49 not 50.

Also when ever you have to repeat something like you are it is best to use a function and then just call that a few times or even just use a loop. I'll simplify your code for you so you can get the picture.


ex:

int main()
{
    const int SIZE( 3 );
    const std::string types[ SIZE ]{ "Name: " , "Turnovers: " , "Total Rebounds: " };
    double values[ SIZE ]{ 0.0 };
    for( int i( 0 ); i < SIZE; ++i )
    {
         std::cout << types[ i ] << std::flush;
         std::cin >> values[ i ];
    }
}

You might have to initialize your arrays and ints differnelty if you do not have c++11 enabled. The c++98 way is like this

const int SIZE = 3;
double values[ 3 ] = { 0.0 };

I would also recommend a vector for storing the values.

#include <vector>

std::vector<double> values( 0 ); //The ( 0 ) is for setting the size you don't technically need it.

for( auto i( 0 ); i < SIZE; ++i ) //auto gets the type automatically. I was lazy
{
    std::cout << "enter something: " << std::flush;
    std::cin >> temp_value;
    values.push_back( temp_value );
}